bluetree-service/clover-reporter

View on GitHub
src/Console/Style.php

Summary

Maintainability
A
0 mins
Test Coverage

The class Style has 18 public methods. Consider refactoring Style to keep number of public methods under 10.
Open

class Style extends SymfonyStyle
{
    /**
     * @var \Symfony\Component\Console\Helper\FormatterHelper
     */
Severity: Minor
Found in src/Console/Style.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The method formatBlock has a boolean flag argument $large, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function formatBlock($messages, string $style, bool $large = false): self
Severity: Minor
Found in src/Console/Style.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

There are no issues that match your filters.

Category
Status