Sign upLogin

bnkamalesh/webgo

View on GitHub
Star

Showing 9 of 9 total issues

Function webgo has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const webgo = async () => {
  const clientID = Math.random()
    .toString(36)
    .replace(/[^a-z]+/g, "")
    .substring(0, 16);
Severity: Major
Found in cmd/static/js/main.js - About 2 hrs to fix

    Function sse has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const sse = (url, config = {}) => {
  const {
    onMessage,
    onError,
    initialBackoff = 10, // milliseconds
    Severity: Minor
    Found in cmd/static/js/sse.js - About 1 hr to fix

      Function getRoutes has 59 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func getRoutes(sse *sse.SSE) []*webgo.Route {
    return []*webgo.Route{
        {
            Name:          "root",
            Method:        http.MethodGet,
      Severity: Minor
      Found in cmd/main.go - About 1 hr to fix

        Function start has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          const start = () => {
    const source = new EventSource(url);
    const configState = { initialBackoff, maxBackoff, backoffStep, backoff };

    source.onopen = () => {
        Severity: Minor
        Found in cmd/static/js/sse.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func pushJS(pusher http.Pusher, r *http.Request, path string) {
    cssOpts := &http.PushOptions{
        Header: http.Header{
            "Accept-Encoding": r.Header["Accept-Encoding"],
            "Content-Type":    []string{"application/javascript"},
          Severity: Minor
          Found in cmd/handlers.go and 1 other location - About 55 mins to fix
          cmd/handlers.go on lines 61..72

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 125.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func pushCSS(pusher http.Pusher, r *http.Request, path string) {
    cssOpts := &http.PushOptions{
        Header: http.Header{
            "Accept-Encoding": r.Header["Accept-Encoding"],
            "Content-Type":    []string{"text/css; charset=UTF-8"},
          Severity: Minor
          Found in cmd/handlers.go and 1 other location - About 55 mins to fix
          cmd/handlers.go on lines 74..85

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 125.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function webgo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          const webgo = async () => {
  const clientID = Math.random()
    .toString(36)
    .replace(/[^a-z]+/g, "")
    .substring(0, 16);
          Severity: Minor
          Found in cmd/static/js/main.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method Route.matchWithWildcard has 5 return statements (exceeds 4 allowed).
          Open

          func (r *Route) matchWithWildcard(requestURI string) (bool, map[string]string) {
    // if r.fragments is empty, it means there are no variables in the URI pattern
    // hence no point checking
    if len(r.fragments) == 0 {
        return false, nil
          Severity: Major
          Found in route.go - About 35 mins to fix

            2: cannot find package "github.com/bnkamalesh/webgo/v7" in any of:
            Open

                "github.com/bnkamalesh/webgo/v7"
            Severity: Minor
            Found in cmd/handlers.go by govet
            Severity
            Category
            Status
            Source
            Language