Sign upLogin

bnomei/kirby-blueprints

View on GitHub
Star
classes/Blueprints/Schema/User.php

Summary

Maintainability
A
4 hrs
Test Coverage
A
100%

Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
Open

        public string $name,
        public string $title, // TODO: should be an string OR array of languages
        public ?string $description = null, // TODO: should be an string OR array of languages
        public ?string $home = null,
        public mixed $image = null,
Severity: Major
Found in classes/Blueprints/Schema/User.php - About 1 hr to fix

    Method make has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            string $name,
        string $title,
        ?string $description = null,
        ?string $home = null,
        mixed $image = null,
    Severity: Major
    Found in classes/Blueprints/Schema/User.php - About 1 hr to fix

      Method permissions has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              bool|array $access = true,
        bool|array $files = true,
        bool|array $pages = true,
        bool|array $site = true,
        bool|array $user = true,
      Severity: Major
      Found in classes/Blueprints/Schema/User.php - About 50 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            public function permissions(
        bool|array $access = true,
        bool|array $files = true,
        bool|array $pages = true,
        bool|array $site = true,
        Severity: Minor
        Found in classes/Blueprints/Schema/User.php and 2 other locations - About 35 mins to fix
        classes/Blueprints/Schema/UserPermissions.php on lines 21..29
        classes/Blueprints/Schema/UserPermissions.php on lines 31..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status