bnomei/kirby-blueprints

View on GitHub

Showing 43 of 43 total issues

Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
Open

        public string $name,
        public string $title, // TODO: should be an string OR array of languages
        public ?string $description = null, // TODO: should be an string OR array of languages
        public ?string $home = null,
        public mixed $image = null,
Severity: Major
Found in classes/Blueprints/Schema/User.php - About 1 hr to fix

    Method make has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            string $name,
            string $title,
            ?string $description = null,
            ?string $home = null,
            mixed $image = null,
    Severity: Major
    Found in classes/Blueprints/Schema/User.php - About 1 hr to fix

      Method make has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              string $title,
              mixed $image = null,
              mixed $accept = null,
              mixed $options = null,
              array $tabs = [],
      Severity: Major
      Found in classes/Blueprints/Schema/File.php - About 1 hr to fix

        Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                public string $title, // TODO: should be an string OR array of languages
                public mixed $image = null,
                public mixed $accept = null,
                public mixed $options = null,
                public array $tabs = [],
        Severity: Major
        Found in classes/Blueprints/Schema/File.php - About 1 hr to fix

          Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  public bool|array $access = true,
                  public bool|array $files = true,
                  public bool|array $pages = true,
                  public bool|array $site = true,
                  public bool|array $user = true,
          Severity: Major
          Found in classes/Blueprints/Schema/UserPermissions.php - About 50 mins to fix

            Method make has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    bool|array $access = true,
                    bool|array $files = true,
                    bool|array $pages = true,
                    bool|array $site = true,
                    bool|array $user = true,
            Severity: Major
            Found in classes/Blueprints/Schema/UserPermissions.php - About 50 mins to fix

              Method permissions has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      bool|array $access = true,
                      bool|array $files = true,
                      bool|array $pages = true,
                      bool|array $site = true,
                      bool|array $user = true,
              Severity: Major
              Found in classes/Blueprints/Schema/User.php - About 50 mins to fix

                Method options has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        bool|array $changeName = true,
                        bool|array $replace = true,
                        bool|array $delete = true,
                        bool|array $read = true,
                        bool|array $update = true,
                Severity: Minor
                Found in classes/Blueprints/Schema/File.php - About 45 mins to fix

                  Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          mixed $type = null,
                          public ?string $id = null,
                          public string|array|null $label = null,
                          public array $properties = [],
                          public string|float|null $width = null,
                  Severity: Minor
                  Found in classes/Blueprints/Schema/Field.php - About 45 mins to fix

                    Method make has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            bool|array $changeName = true,
                            bool|array $replace = true,
                            bool|array $delete = true,
                            bool|array $read = true,
                            bool|array $update = true,
                    Severity: Minor
                    Found in classes/Blueprints/Schema/FileOptions.php - About 45 mins to fix

                      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              public string|array $label = '',
                              public ?Icon $icon = null,
                              public ?string $id = null,
                              public array $columns = [],
                              public array $sections = [],
                      Severity: Minor
                      Found in classes/Blueprints/Schema/Tab.php - About 45 mins to fix

                        Method make has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                string $title,
                                mixed $options = null,
                                array $tabs = [],
                                array $columns = [],
                                array $sections = [],
                        Severity: Minor
                        Found in classes/Blueprints/Schema/Site.php - About 45 mins to fix

                          Method make has 6 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  array|string $label,
                                  ?Icon $icon = null,
                                  ?string $id = null,
                                  array $columns = [],
                                  array $sections = [],
                          Severity: Minor
                          Found in classes/Blueprints/Schema/Tab.php - About 45 mins to fix

                            Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    public string $title, // TODO: should be an string OR array of languages
                                    public mixed $options = null,
                                    public array $tabs = [],
                                    public array $columns = [],
                                    public array $sections = [],
                            Severity: Minor
                            Found in classes/Blueprints/Schema/Site.php - About 45 mins to fix

                              Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      public bool|array $changeName = true,
                                      public bool|array $replace = true,
                                      public bool|array $delete = true,
                                      public bool|array $read = true,
                                      public bool|array $update = true,
                              Severity: Minor
                              Found in classes/Blueprints/Schema/FileOptions.php - About 45 mins to fix

                                Function exists has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public static function exists(string $key, ?int $expire = null): bool
                                    {
                                        $file = static::cacheFile($key);
                                        if (! $file) {
                                            return false;
                                Severity: Minor
                                Found in classes/Blueprints/BlueprintCache.php - About 45 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Method make has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                        string|float|null $width = null,
                                        bool $sticky = false,
                                        ?string $id = null,
                                        array $sections = [],
                                        array $fields = [],
                                Severity: Minor
                                Found in classes/Blueprints/Schema/Column.php - About 35 mins to fix

                                  Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                          public string|float|null $width = null,
                                          public bool $sticky = false,
                                          public ?string $id = null,
                                          public array $sections = [],
                                          public array $fields = [],
                                  Severity: Minor
                                  Found in classes/Blueprints/Schema/Column.php - About 35 mins to fix

                                    Similar blocks of code found in 3 locations. Consider refactoring.
                                    Open

                                        public function __construct(
                                            public bool|array $access = true,
                                            public bool|array $files = true,
                                            public bool|array $pages = true,
                                            public bool|array $site = true,
                                    Severity: Minor
                                    Found in classes/Blueprints/Schema/UserPermissions.php and 2 other locations - About 35 mins to fix
                                    classes/Blueprints/Schema/User.php on lines 60..72
                                    classes/Blueprints/Schema/UserPermissions.php on lines 31..41

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 92.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Similar blocks of code found in 3 locations. Consider refactoring.
                                    Open

                                        public function permissions(
                                            bool|array $access = true,
                                            bool|array $files = true,
                                            bool|array $pages = true,
                                            bool|array $site = true,
                                    Severity: Minor
                                    Found in classes/Blueprints/Schema/User.php and 2 other locations - About 35 mins to fix
                                    classes/Blueprints/Schema/UserPermissions.php on lines 21..29
                                    classes/Blueprints/Schema/UserPermissions.php on lines 31..41

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 92.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language