Sign upLogin

bollu/symengine.hs

View on GitHub
Star

Showing 159 of 159 total issues

Missing NOINLINE pragma
Open

densematrix_new_eye = unsafePerformIO $ do
  let mat = densematrix_new_rows_cols
  throwOnSymIntException =<< with mat (\m -> cdensematrix_eye_ffi m
                 (fromIntegral . natVal $ (Proxy @ r))
                 (fromIntegral . natVal $ (Proxy @ c))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_eye
  = unsafePerformIO $
      do let mat = densematrix_new_rows_cols
         throwOnSymIntException =<<
           with mat
             (\ m ->
                cdensematrix_eye_ffi m (fromIntegral . natVal $ (Proxy @r))
                  (fromIntegral . natVal $ (Proxy @c))
                  (fromIntegral . natVal $ (Proxy @k)))
         return mat

Perhaps

{-# NOINLINE densematrix_new_eye #-}
densematrix_new_eye
  = unsafePerformIO $
      do let mat = densematrix_new_rows_cols
         throwOnSymIntException =<<
           with mat
             (\ m ->
                cdensematrix_eye_ffi m (fromIntegral . natVal $ (Proxy @r))
                  (fromIntegral . natVal $ (Proxy @c))
                  (fromIntegral . natVal $ (Proxy @k)))
         return mat

Missing NOINLINE pragma
Open

densematrix_new_zeros = unsafePerformIO $ do
  let mat = densematrix_new_rows_cols
  throwOnSymIntException =<< with mat (\m -> cdensematrix_zeros_ffi m
                  (fromIntegral . natVal $ (Proxy @ r))
                  (fromIntegral . natVal $ (Proxy @ c)))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_zeros
  = unsafePerformIO $
      do let mat = densematrix_new_rows_cols
         throwOnSymIntException =<<
           with mat
             (\ m ->
                cdensematrix_zeros_ffi m (fromIntegral . natVal $ (Proxy @r))
                  (fromIntegral . natVal $ (Proxy @c)))
         return mat

Perhaps

{-# NOINLINE densematrix_new_zeros #-}
densematrix_new_zeros
  = unsafePerformIO $
      do let mat = densematrix_new_rows_cols
         throwOnSymIntException =<<
           with mat
             (\ m ->
                cdensematrix_zeros_ffi m (fromIntegral . natVal $ (Proxy @r))
                  (fromIntegral . natVal $ (Proxy @c)))
         return mat

Redundant bracket
Open

  with (BasicSym (p)) f = withForeignPtr p f
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

(p)

Perhaps

p

Redundant bracket
Open

foreign import ccall "symengine/cwrapper.h dense_matrix_get_basic" cdensematrix_get_basic_ffi :: Ptr (CBasicSym)  -> Ptr CDenseMatrix -> CUInt -> CUInt -> IO CInt
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

(CBasicSym)

Perhaps

CBasicSym

Eta reduce
Open

    with (VecBasic p) f = withForeignPtr p f
Severity: Minor
Found in src/Symengine/VecBasic.hs by hlint

Found

with (VecBasic p) f = withForeignPtr p f

Perhaps

with (VecBasic p) = withForeignPtr p

Use fewer imports
Open

import Control.Monad -- for foldM
Severity: Minor
Found in src/Symengine.hs by hlint

Found

import Control.Monad
import Control.Monad

Perhaps

import Control.Monad

Eta reduce
Open

intToCLong i = toEnum i
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

intToCLong i = toEnum i

Perhaps

intToCLong = toEnum

Eta reduce
Open

  with (BasicSym (p)) f = withForeignPtr p f
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

with (BasicSym (p)) f = withForeignPtr p f

Perhaps

with (BasicSym (p)) = withForeignPtr p

Redundant bracket
Open

    return $ VecBasic (finalized)
Severity: Minor
Found in src/Symengine/VecBasic.hs by hlint

Found

(finalized)

Perhaps

finalized

Unused LANGUAGE pragma
Open

{-# LANGUAGE FunctionalDependencies #-}
Severity: Minor
Found in src/Symengine.hs by hlint

Found

{-# LANGUAGE FunctionalDependencies #-}

Perhaps

Applying this change:

  • may require {-# LANGUAGE MultiParamTypeClasses #-} adding to the top of the file

Missing NOINLINE pragma
Open

densematrix_new_rows_cols = 
    unsafePerformIO $ DenseMatrix <$>
      (mkForeignPtr (cdensematrix_new_rows_cols_ffi 
                      (fromIntegral . natVal $ (Proxy @ r))
                      (fromIntegral . natVal $ (Proxy @ c)))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_rows_cols
  = unsafePerformIO $
      DenseMatrix <$>
        (mkForeignPtr
           (cdensematrix_new_rows_cols_ffi
              (fromIntegral . natVal $ (Proxy @r))
              (fromIntegral . natVal $ (Proxy @c)))
           cdensematrix_free_ffi)

Perhaps

{-# NOINLINE densematrix_new_rows_cols #-}
densematrix_new_rows_cols
  = unsafePerformIO $
      DenseMatrix <$>
        (mkForeignPtr
           (cdensematrix_new_rows_cols_ffi
              (fromIntegral . natVal $ (Proxy @r))
              (fromIntegral . natVal $ (Proxy @c)))
           cdensematrix_free_ffi)

Unused LANGUAGE pragma
Open

{-# LANGUAGE RecordWildCards #-}
Severity: Minor
Found in src/Symengine/Internal.hs by hlint

Found

{-# LANGUAGE RecordWildCards #-}

Perhaps

Applying this change:

  • may require {-# LANGUAGE DisambiguateRecordFields #-} adding to the top of the file

Use fewer imports
Open

import Control.Monad -- for foldM
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

import Control.Monad
import Control.Monad

Perhaps

import Control.Monad

Use fewer imports
Open

import Control.Monad -- for foldM
Severity: Minor
Found in src/Symengine/Internal.hs by hlint

Found

import Control.Monad
import Control.Monad

Perhaps

import Control.Monad

Eta reduce
Open

complex a b = (lift_basicsym_binaryop complex_set_ffi) a b
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

complex a b = (lift_basicsym_binaryop complex_set_ffi) a b

Perhaps

complex = (lift_basicsym_binaryop complex_set_ffi)

Redundant bracket
Open

foreign import ccall "symengine/cwrapper.h dense_matrix_set_basic" cdensematrix_set_basic_ffi :: Ptr CDenseMatrix -> CUInt -> CUInt -> Ptr (CBasicSym)  -> IO CInt
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

(CBasicSym)

Perhaps

CBasicSym

Eta reduce
Open

throwOnSymIntException i = forceException . cIntToEnum $ i
Severity: Minor
Found in src/Symengine/Internal.hs by hlint

Found

throwOnSymIntException i = forceException . cIntToEnum $ i

Perhaps

throwOnSymIntException = forceException . cIntToEnum

Unused LANGUAGE pragma
Open

{-# LANGUAGE FunctionalDependencies #-}
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

{-# LANGUAGE FunctionalDependencies #-}

Perhaps

Applying this change:

  • may require {-# LANGUAGE MultiParamTypeClasses #-} adding to the top of the file

Unused LANGUAGE pragma
Open

{-# LANGUAGE RecordWildCards #-}
Severity: Minor
Found in src/Symengine.hs by hlint

Found

{-# LANGUAGE RecordWildCards #-}

Perhaps

Applying this change:

  • may require {-# LANGUAGE DisambiguateRecordFields #-} adding to the top of the file

Use fewer imports
Open

import Control.Monad -- for foldM
Severity: Minor
Found in src/Symengine/VecBasic.hs by hlint

Found

import Control.Monad
import Control.Monad

Perhaps

import Control.Monad
Severity
Category
Status
Source
Language