Sign upLogin

bollu/symengine.hs

View on GitHub
Star

Showing 159 of 159 total issues

Use camelCase
Open

densematrix_get :: forall r c. (KnownNat r, KnownNat c) => 
  DenseMatrix r c -> Finite r -> Finite c -> BasicSym
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_get ::
  forall r c.
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c -> Finite r -> Finite c -> BasicSym

Perhaps

densematrixGet ::
  forall r c.
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c -> Finite r -> Finite c -> BasicSym

Use camelCase
Open

densematrix_size :: forall r c. (KnownNat r, KnownNat c) => DenseMatrix r c -> (NRows, NCols)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_size ::
  forall r c.
  (KnownNat r, KnownNat c) => DenseMatrix r c -> (NRows, NCols)

Perhaps

densematrixSize ::
  forall r c.
  (KnownNat r, KnownNat c) => DenseMatrix r c -> (NRows, NCols)

Redundant bracket
Open

   (fromIntegral . natVal $ (Proxy @ r), fromIntegral . natVal $ (Proxy @ c))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral . natVal $ (Proxy @c)

Perhaps

fromIntegral . natVal $ Proxy @c

Redundant bracket
Open

mkForeignPtr :: (IO (Ptr a)) -> FunPtr (Ptr a -> IO ()) -> IO (ForeignPtr a)
Severity: Minor
Found in src/Symengine/Internal.hs by hlint

Found

(IO (Ptr a)) -> FunPtr (Ptr a -> IO ()) -> IO (ForeignPtr a)

Perhaps

IO (Ptr a) -> FunPtr (Ptr a -> IO ()) -> IO (ForeignPtr a)

Use camelCase
Open

vecbasic_new = do
    ptr <- vecbasic_new_ffi
    finalized <- newForeignPtr vecbasic_free_ffi ptr
    return $ VecBasic (finalized)
Severity: Minor
Found in src/Symengine/VecBasic.hs by hlint

Found

vecbasic_new = ...

Perhaps

vecbasicNew = ...

Redundant bracket
Open

    unsafePerformIO $ DenseMatrix <$>
      (mkForeignPtr (cdensematrix_new_rows_cols_ffi 
                      (fromIntegral . natVal $ (Proxy @ r))
                      (fromIntegral . natVal $ (Proxy @ c)))
                      cdensematrix_free_ffi)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

DenseMatrix <$>
  (mkForeignPtr
     (cdensematrix_new_rows_cols_ffi
        (fromIntegral . natVal $ (Proxy @r))
        (fromIntegral . natVal $ (Proxy @c)))
     cdensematrix_free_ffi)

Perhaps

DenseMatrix <$>
  mkForeignPtr
    (cdensematrix_new_rows_cols_ffi
       (fromIntegral . natVal $ (Proxy @r))
       (fromIntegral . natVal $ (Proxy @c)))
    cdensematrix_free_ffi

Use camelCase
Open

densematrix_ldl mat = unsafePerformIO $ do
  l <- densematrix_new
  d <- densematrix_new
  throwOnSymIntException =<< with3 l d mat cdensematrix_ldl
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_ldl mat = ...

Perhaps

densematrixLdl mat = ...

Use camelCase
Open

gcd_extended a b = unsafePerformIO $ do
  g <- basicsym_new
  s <- basicsym_new
  t <- basicsym_new
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

gcd_extended a b = ...

Perhaps

gcdExtended a b = ...

Use camelCase
Open

basic_int_signed i = unsafePerformIO $ do
    iptr <- basicsym_new
    with iptr (\iptr -> integer_set_si_ffi iptr (intToCLong i) )
    return iptr
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basic_int_signed i = ...

Perhaps

basicIntSigned i = ...

Redundant bracket
Open

                      (fromIntegral . natVal $ (Proxy @ r))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral . natVal $ (Proxy @r)

Perhaps

fromIntegral . natVal $ Proxy @r

Use camelCase
Open

densematrix_get mat getr getc = unsafePerformIO $ do
      sym <- basicsym_new
      let indexr = fromIntegral $ (getFinite getr)
      let indexc = fromIntegral $ (getFinite getc)
      throwOnSymIntException =<< with2 mat sym (\m s -> cdensematrix_get_basic_ffi s m indexr indexc)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_get mat getr getc = ...

Perhaps

densematrixGet mat getr getc = ...

Use camelCase
Open

densematrix_lu_solve a b = unsafePerformIO $ do
  x <- densematrix_new
  throwOnSymIntException =<< with3 x a b cdensematrix_lu_solve
  return x
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_lu_solve a b = ...

Perhaps

densematrixLuSolve a b = ...

Redundant $
Open

      let indexr = fromIntegral $ (getFinite getr)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral $ (getFinite getr)

Perhaps

fromIntegral (getFinite getr)

Use camelCase
Open

densematrix_set :: forall r c. (KnownNat r, KnownNat c) => 
  DenseMatrix r c -> Finite r -> Finite c -> BasicSym -> DenseMatrix r c
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_set ::
  forall r c.
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c
  -> Finite r -> Finite c -> BasicSym -> DenseMatrix r c

Perhaps

densematrixSet ::
  forall r c.
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c
  -> Finite r -> Finite c -> BasicSym -> DenseMatrix r c

Use camelCase
Open

gcd_extended :: BasicSym -> BasicSym -> (BasicSym, BasicSym, BasicSym)
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

gcd_extended ::
  BasicSym -> BasicSym -> (BasicSym, BasicSym, BasicSym)

Perhaps

gcdExtended ::
  BasicSym -> BasicSym -> (BasicSym, BasicSym, BasicSym)

Use camelCase
Open

mod_f :: BasicSym -> BasicSym -> Quotient
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

mod_f :: BasicSym -> BasicSym -> Quotient

Perhaps

modF :: BasicSym -> BasicSym -> Quotient

Use camelCase
Open

_densematrix_copy :: (KnownNat r, KnownNat c) => DenseMatrix r c -> IO (DenseMatrix r c)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

_densematrix_copy ::
  (KnownNat r, KnownNat c) => DenseMatrix r c -> IO (DenseMatrix r c)

Perhaps

_densematrixCopy ::
  (KnownNat r, KnownNat c) => DenseMatrix r c -> IO (DenseMatrix r c)

Use camelCase
Open

minus_one :: BasicSym
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

minus_one :: BasicSym

Perhaps

minusOne :: BasicSym

Use camelCase
Open

basicsym_construct :: (Ptr CBasicSym -> IO ()) -> BasicSym
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basicsym_construct :: (Ptr CBasicSym -> IO ()) -> BasicSym

Perhaps

basicsymConstruct :: (Ptr CBasicSym -> IO ()) -> BasicSym

Redundant bracket
Open

                      (fromIntegral . natVal $ (Proxy @ c)))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral . natVal $ (Proxy @c)

Perhaps

fromIntegral . natVal $ Proxy @c
Severity
Category
Status
Source
Language