Sign upLogin

bollu/symengine.hs

View on GitHub
Star
src/Symengine/BasicSym.hs

Summary

Maintainability
Test Coverage

Redundant bracket
Open

  with (BasicSym (p)) f = withForeignPtr p f
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

(p)

Perhaps

p

Eta reduce
Open

intToCLong i = toEnum i
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

intToCLong i = toEnum i

Perhaps

intToCLong = toEnum

Eta reduce
Open

  with (BasicSym (p)) f = withForeignPtr p f
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

with (BasicSym (p)) f = withForeignPtr p f

Perhaps

with (BasicSym (p)) = withForeignPtr p

Eta reduce
Open

complex a b = (lift_basicsym_binaryop complex_set_ffi) a b
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

complex a b = (lift_basicsym_binaryop complex_set_ffi) a b

Perhaps

complex = (lift_basicsym_binaryop complex_set_ffi)

Eta reduce
Open

diff expr symbol = (lift_basicsym_binaryop basic_diff_ffi) expr symbol
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

diff expr symbol
  = (lift_basicsym_binaryop basic_diff_ffi) expr symbol

Perhaps

diff = (lift_basicsym_binaryop basic_diff_ffi)

Unused LANGUAGE pragma
Open

{-# LANGUAGE GeneralizedNewtypeDeriving #-}
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

{-# LANGUAGE GeneralizedNewtypeDeriving #-}

Perhaps

Unused LANGUAGE pragma
Open

{-# LANGUAGE RecordWildCards #-}
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

{-# LANGUAGE RecordWildCards #-}

Perhaps

Applying this change:

  • may require {-# LANGUAGE DisambiguateRecordFields #-} adding to the top of the file

Use fewer imports
Open

import Control.Monad -- for foldM
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

import Control.Monad
import Control.Monad

Perhaps

import Control.Monad

Eta reduce
Open

intToCInt i = toEnum i
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

intToCInt i = toEnum i

Perhaps

intToCInt = toEnum

Unused LANGUAGE pragma
Open

{-# LANGUAGE FunctionalDependencies #-}
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

{-# LANGUAGE FunctionalDependencies #-}

Perhaps

Applying this change:

  • may require {-# LANGUAGE MultiParamTypeClasses #-} adding to the top of the file

Use camelCase
Open

basic_pow :: BasicSym -> BasicSym -> BasicSym
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basic_pow :: BasicSym -> BasicSym -> BasicSym

Perhaps

basicPow :: BasicSym -> BasicSym -> BasicSym

Use camelCase
Open

basic_int_signed i = unsafePerformIO $ do
    iptr <- basicsym_new
    with iptr (\iptr -> integer_set_si_ffi iptr (intToCLong i) )
    return iptr
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basic_int_signed i = ...

Perhaps

basicIntSigned i = ...

Use camelCase
Open

minus_one :: BasicSym
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

minus_one :: BasicSym

Perhaps

minusOne :: BasicSym

Use camelCase
Open

basicsym_construct :: (Ptr CBasicSym -> IO ()) -> BasicSym
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basicsym_construct :: (Ptr CBasicSym -> IO ()) -> BasicSym

Perhaps

basicsymConstruct :: (Ptr CBasicSym -> IO ()) -> BasicSym

Use camelCase
Open

basic_from_integer i = unsafePerformIO $ do
  s <- basicsym_new
  with s (\s -> integer_set_si_ffi s (fromInteger i))
  return s
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basic_from_integer i = ...

Perhaps

basicFromInteger i = ...

Redundant $
Open

    (-) = lift_basicsym_binaryop $ basic_sub_ffi
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

lift_basicsym_binaryop $ basic_sub_ffi

Perhaps

lift_basicsym_binaryop basic_sub_ffi

Use camelCase
Open

basicsym_new = do
    basic_ptr <- basic_new_heap_ffi
    finalized_ptr <- newForeignPtr ptr_basic_free_heap_ffi  basic_ptr

    return $ BasicSym finalized_ptr
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basicsym_new = ...

Perhaps

basicsymNew = ...

Avoid lambda using infix
Open

    with s (\s -> symbol_set_ffi s cname)
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

\ s -> symbol_set_ffi s cname

Perhaps

(`symbol_set_ffi` cname)

Use camelCase
Open

basic_str :: BasicSym -> String
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basic_str :: BasicSym -> String

Perhaps

basicStr :: BasicSym -> String

Use camelCase
Open

basic_str basic_ptr = unsafePerformIO $ with basic_ptr (basic_str_ffi >=> peekCString)
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basic_str basic_ptr = ...

Perhaps

basicStr basic_ptr = ...

Use camelCase
Open

lift_basicsym_binaryop f a b = unsafePerformIO $ do
    s <- basicsym_new
    with3 s a b f >>= throwOnSymIntException

    return s
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

lift_basicsym_binaryop f a b = ...

Perhaps

liftBasicsymBinaryop f a b = ...

Use camelCase
Open

symbol_new :: String -> BasicSym
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

symbol_new :: String -> BasicSym

Perhaps

symbolNew :: String -> BasicSym

Use camelCase
Open

symbol_new name = unsafePerformIO $ do
    s <- basicsym_new
    cname <- newCString name
    with s (\s -> symbol_set_ffi s cname)
    free cname
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

symbol_new name = ...

Perhaps

symbolNew name = ...

Use camelCase
Open

basic_rational_from_integer i j = unsafePerformIO $ do
    s <- basicsym_new
    with s (\s -> rational_set_si_ffi s (integerToCLong i) (integerToCLong j))
    return s
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basic_rational_from_integer i j = ...

Perhaps

basicRationalFromInteger i j = ...

Use camelCase
Open

basicsym_construct init_fn = unsafePerformIO $ do
    basic_ptr <- basicsym_new
    with basic_ptr init_fn
    return basic_ptr
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basicsym_construct init_fn = ...

Perhaps

basicsymConstruct init_fn = ...

Use camelCase
Open

ascii_art_str = ascii_art_str_ffi >>= peekCString
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

ascii_art_str = ...

Perhaps

asciiArtStr = ...

Use camelCase
Open

lift_basicsym_unaryop :: (Ptr CBasicSym -> Ptr CBasicSym -> IO CInt) -> BasicSym -> BasicSym
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

lift_basicsym_unaryop ::
  (Ptr CBasicSym -> Ptr CBasicSym -> IO CInt) -> BasicSym -> BasicSym

Perhaps

liftBasicsymUnaryop ::
  (Ptr CBasicSym -> Ptr CBasicSym -> IO CInt) -> BasicSym -> BasicSym

Redundant bracket
Open

diff expr symbol = (lift_basicsym_binaryop basic_diff_ffi) expr symbol
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

(lift_basicsym_binaryop basic_diff_ffi) expr

Perhaps

lift_basicsym_binaryop basic_diff_ffi expr

Use newtype instead of data
Open

data BasicSym = BasicSym !(ForeignPtr CBasicSym)
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

data BasicSym = BasicSym !(ForeignPtr CBasicSym)

Perhaps

newtype BasicSym = BasicSym (ForeignPtr CBasicSym)

Use camelCase
Open

basic_from_integer :: Integer -> BasicSym
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basic_from_integer :: Integer -> BasicSym

Perhaps

basicFromInteger :: Integer -> BasicSym

Use camelCase
Open

lift_basicsym_binaryop :: (Ptr CBasicSym -> Ptr CBasicSym -> Ptr CBasicSym -> IO CInt) -> 
    BasicSym -> BasicSym -> BasicSym
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

lift_basicsym_binaryop ::
  (Ptr CBasicSym -> Ptr CBasicSym -> Ptr CBasicSym -> IO CInt)
  -> BasicSym -> BasicSym -> BasicSym

Perhaps

liftBasicsymBinaryop ::
  (Ptr CBasicSym -> Ptr CBasicSym -> Ptr CBasicSym -> IO CInt)
  -> BasicSym -> BasicSym -> BasicSym

Use camelCase
Open

lift_basicsym_unaryop f a = unsafePerformIO $ do
    s <- basicsym_new 
    with2 s a f >>= throwOnSymIntException
    return $ s
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

lift_basicsym_unaryop f a = ...

Perhaps

liftBasicsymUnaryop f a = ...

Redundant $
Open

    (/) = lift_basicsym_binaryop $ basic_div_ffi
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

lift_basicsym_binaryop $ basic_div_ffi

Perhaps

lift_basicsym_binaryop basic_div_ffi

Use camelCase
Open

ascii_art_str :: IO String
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

ascii_art_str :: IO String

Perhaps

asciiArtStr :: IO String

Use camelCase
Open

basicsym_new :: IO BasicSym
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basicsym_new :: IO BasicSym

Perhaps

basicsymNew :: IO BasicSym

Use camelCase
Open

basic_pow = lift_basicsym_binaryop basic_pow_ffi
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basic_pow = ...

Perhaps

basicPow = ...

Redundant $
Open

    (+) = lift_basicsym_binaryop $ basic_add_ffi
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

lift_basicsym_binaryop $ basic_add_ffi

Perhaps

lift_basicsym_binaryop basic_add_ffi

Redundant $
Open

    (*) = lift_basicsym_binaryop $ basic_mul_ffi
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

lift_basicsym_binaryop $ basic_mul_ffi

Perhaps

lift_basicsym_binaryop basic_mul_ffi

Redundant bracket
Open

complex a b = (lift_basicsym_binaryop complex_set_ffi) a b
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

(lift_basicsym_binaryop complex_set_ffi) a

Perhaps

lift_basicsym_binaryop complex_set_ffi a

Use camelCase
Open

minus_one = basicsym_construct basic_const_minus_one_ffi
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

minus_one = ...

Perhaps

minusOne = ...

Redundant $
Open

    return $ s
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

return $ s

Perhaps

return s

Use camelCase
Open

basic_rational_from_integer :: Integer -> Integer -> BasicSym
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basic_rational_from_integer :: Integer -> Integer -> BasicSym

Perhaps

basicRationalFromInteger :: Integer -> Integer -> BasicSym

Use camelCase
Open

basic_int_signed :: Int -> BasicSym
Severity: Minor
Found in src/Symengine/BasicSym.hs by hlint

Found

basic_int_signed :: Int -> BasicSym

Perhaps

basicIntSigned :: Int -> BasicSym

There are no issues that match your filters.

Category
Status