Sign upLogin

bollu/symengine.hs

View on GitHub
Star
src/Symengine/DenseMatrix.hs

Summary

Maintainability
Test Coverage

Missing NOINLINE pragma
Open

densematrix_new_eye = unsafePerformIO $ do
  let mat = densematrix_new_rows_cols
  throwOnSymIntException =<< with mat (\m -> cdensematrix_eye_ffi m
                 (fromIntegral . natVal $ (Proxy @ r))
                 (fromIntegral . natVal $ (Proxy @ c))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_eye
  = unsafePerformIO $
      do let mat = densematrix_new_rows_cols
         throwOnSymIntException =<<
           with mat
             (\ m ->
                cdensematrix_eye_ffi m (fromIntegral . natVal $ (Proxy @r))
                  (fromIntegral . natVal $ (Proxy @c))
                  (fromIntegral . natVal $ (Proxy @k)))
         return mat

Perhaps

{-# NOINLINE densematrix_new_eye #-}
densematrix_new_eye
  = unsafePerformIO $
      do let mat = densematrix_new_rows_cols
         throwOnSymIntException =<<
           with mat
             (\ m ->
                cdensematrix_eye_ffi m (fromIntegral . natVal $ (Proxy @r))
                  (fromIntegral . natVal $ (Proxy @c))
                  (fromIntegral . natVal $ (Proxy @k)))
         return mat

Missing NOINLINE pragma
Open

densematrix_new_zeros = unsafePerformIO $ do
  let mat = densematrix_new_rows_cols
  throwOnSymIntException =<< with mat (\m -> cdensematrix_zeros_ffi m
                  (fromIntegral . natVal $ (Proxy @ r))
                  (fromIntegral . natVal $ (Proxy @ c)))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_zeros
  = unsafePerformIO $
      do let mat = densematrix_new_rows_cols
         throwOnSymIntException =<<
           with mat
             (\ m ->
                cdensematrix_zeros_ffi m (fromIntegral . natVal $ (Proxy @r))
                  (fromIntegral . natVal $ (Proxy @c)))
         return mat

Perhaps

{-# NOINLINE densematrix_new_zeros #-}
densematrix_new_zeros
  = unsafePerformIO $
      do let mat = densematrix_new_rows_cols
         throwOnSymIntException =<<
           with mat
             (\ m ->
                cdensematrix_zeros_ffi m (fromIntegral . natVal $ (Proxy @r))
                  (fromIntegral . natVal $ (Proxy @c)))
         return mat

Redundant bracket
Open

foreign import ccall "symengine/cwrapper.h dense_matrix_get_basic" cdensematrix_get_basic_ffi :: Ptr (CBasicSym)  -> Ptr CDenseMatrix -> CUInt -> CUInt -> IO CInt
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

(CBasicSym)

Perhaps

CBasicSym

Missing NOINLINE pragma
Open

densematrix_new_rows_cols = 
    unsafePerformIO $ DenseMatrix <$>
      (mkForeignPtr (cdensematrix_new_rows_cols_ffi 
                      (fromIntegral . natVal $ (Proxy @ r))
                      (fromIntegral . natVal $ (Proxy @ c)))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_rows_cols
  = unsafePerformIO $
      DenseMatrix <$>
        (mkForeignPtr
           (cdensematrix_new_rows_cols_ffi
              (fromIntegral . natVal $ (Proxy @r))
              (fromIntegral . natVal $ (Proxy @c)))
           cdensematrix_free_ffi)

Perhaps

{-# NOINLINE densematrix_new_rows_cols #-}
densematrix_new_rows_cols
  = unsafePerformIO $
      DenseMatrix <$>
        (mkForeignPtr
           (cdensematrix_new_rows_cols_ffi
              (fromIntegral . natVal $ (Proxy @r))
              (fromIntegral . natVal $ (Proxy @c)))
           cdensematrix_free_ffi)

Redundant bracket
Open

foreign import ccall "symengine/cwrapper.h dense_matrix_set_basic" cdensematrix_set_basic_ffi :: Ptr CDenseMatrix -> CUInt -> CUInt -> Ptr (CBasicSym)  -> IO CInt
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

(CBasicSym)

Perhaps

CBasicSym

Redundant bracket
Open

instance Matrix (DenseMatrix) where
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

(DenseMatrix)

Perhaps

DenseMatrix

Unused LANGUAGE pragma
Open

{-# LANGUAGE FunctionalDependencies #-}
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

{-# LANGUAGE FunctionalDependencies #-}

Perhaps

Applying this change:

  • may require {-# LANGUAGE MultiParamTypeClasses #-} adding to the top of the file

Unused LANGUAGE pragma
Open

{-# LANGUAGE RecordWildCards #-}
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

{-# LANGUAGE RecordWildCards #-}

Perhaps

Applying this change:

  • may require {-# LANGUAGE DisambiguateRecordFields #-} adding to the top of the file

Eta reduce
Open

    with (DenseMatrix p) f = withForeignPtr p f
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

with (DenseMatrix p) f = withForeignPtr p f

Perhaps

with (DenseMatrix p) = withForeignPtr p

Use fewer imports
Open

import Control.Monad -- for foldM
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

import Control.Monad
import Control.Monad

Perhaps

import Control.Monad

Use camelCase
Open

densematrix_new_zeros :: forall r c. (KnownNat r, KnownNat c) => DenseMatrix r c
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_zeros ::
  forall r c. (KnownNat r, KnownNat c) => DenseMatrix r c

Perhaps

densematrixNewZeros ::
  forall r c. (KnownNat r, KnownNat c) => DenseMatrix r c

Use camelCase
Open

densematrix_get :: forall r c. (KnownNat r, KnownNat c) => 
  DenseMatrix r c -> Finite r -> Finite c -> BasicSym
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_get ::
  forall r c.
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c -> Finite r -> Finite c -> BasicSym

Perhaps

densematrixGet ::
  forall r c.
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c -> Finite r -> Finite c -> BasicSym

Use camelCase
Open

densematrix_size :: forall r c. (KnownNat r, KnownNat c) => DenseMatrix r c -> (NRows, NCols)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_size ::
  forall r c.
  (KnownNat r, KnownNat c) => DenseMatrix r c -> (NRows, NCols)

Perhaps

densematrixSize ::
  forall r c.
  (KnownNat r, KnownNat c) => DenseMatrix r c -> (NRows, NCols)

Redundant bracket
Open

   (fromIntegral . natVal $ (Proxy @ r), fromIntegral . natVal $ (Proxy @ c))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral . natVal $ (Proxy @c)

Perhaps

fromIntegral . natVal $ Proxy @c

Redundant bracket
Open

    unsafePerformIO $ DenseMatrix <$>
      (mkForeignPtr (cdensematrix_new_rows_cols_ffi 
                      (fromIntegral . natVal $ (Proxy @ r))
                      (fromIntegral . natVal $ (Proxy @ c)))
                      cdensematrix_free_ffi)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

DenseMatrix <$>
  (mkForeignPtr
     (cdensematrix_new_rows_cols_ffi
        (fromIntegral . natVal $ (Proxy @r))
        (fromIntegral . natVal $ (Proxy @c)))
     cdensematrix_free_ffi)

Perhaps

DenseMatrix <$>
  mkForeignPtr
    (cdensematrix_new_rows_cols_ffi
       (fromIntegral . natVal $ (Proxy @r))
       (fromIntegral . natVal $ (Proxy @c)))
    cdensematrix_free_ffi

Use camelCase
Open

densematrix_ldl mat = unsafePerformIO $ do
  l <- densematrix_new
  d <- densematrix_new
  throwOnSymIntException =<< with3 l d mat cdensematrix_ldl
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_ldl mat = ...

Perhaps

densematrixLdl mat = ...

Redundant bracket
Open

                      (fromIntegral . natVal $ (Proxy @ r))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral . natVal $ (Proxy @r)

Perhaps

fromIntegral . natVal $ Proxy @r

Use camelCase
Open

densematrix_get mat getr getc = unsafePerformIO $ do
      sym <- basicsym_new
      let indexr = fromIntegral $ (getFinite getr)
      let indexc = fromIntegral $ (getFinite getc)
      throwOnSymIntException =<< with2 mat sym (\m s -> cdensematrix_get_basic_ffi s m indexr indexc)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_get mat getr getc = ...

Perhaps

densematrixGet mat getr getc = ...

Use camelCase
Open

densematrix_lu_solve a b = unsafePerformIO $ do
  x <- densematrix_new
  throwOnSymIntException =<< with3 x a b cdensematrix_lu_solve
  return x
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_lu_solve a b = ...

Perhaps

densematrixLuSolve a b = ...

Redundant $
Open

      let indexr = fromIntegral $ (getFinite getr)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral $ (getFinite getr)

Perhaps

fromIntegral (getFinite getr)

Use camelCase
Open

densematrix_set :: forall r c. (KnownNat r, KnownNat c) => 
  DenseMatrix r c -> Finite r -> Finite c -> BasicSym -> DenseMatrix r c
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_set ::
  forall r c.
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c
  -> Finite r -> Finite c -> BasicSym -> DenseMatrix r c

Perhaps

densematrixSet ::
  forall r c.
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c
  -> Finite r -> Finite c -> BasicSym -> DenseMatrix r c

Use camelCase
Open

_densematrix_copy :: (KnownNat r, KnownNat c) => DenseMatrix r c -> IO (DenseMatrix r c)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

_densematrix_copy ::
  (KnownNat r, KnownNat c) => DenseMatrix r c -> IO (DenseMatrix r c)

Perhaps

_densematrixCopy ::
  (KnownNat r, KnownNat c) => DenseMatrix r c -> IO (DenseMatrix r c)

Redundant bracket
Open

                      (fromIntegral . natVal $ (Proxy @ c)))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral . natVal $ (Proxy @c)

Perhaps

fromIntegral . natVal $ Proxy @c

Use camelCase
Open

densematrix_new_vec :: forall r c. (KnownNat r, KnownNat c, KnownNat (r * c)) => V.Vector (r * c) BasicSym -> DenseMatrix r c
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_vec ::
  forall r c.
  (KnownNat r, KnownNat c, KnownNat (r * c)) =>
  V.Vector (r * c) BasicSym -> DenseMatrix r c

Perhaps

densematrixNewVec ::
  forall r c.
  (KnownNat r, KnownNat c, KnownNat (r * c)) =>
  V.Vector (r * c) BasicSym -> DenseMatrix r c

Redundant bracket
Open

      let indexc = fromIntegral $ (getFinite getc)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral $ (getFinite getc)

Perhaps

fromIntegral $ getFinite getc

Use camelCase
Open

densematrix_mul_scalar :: forall r c. (KnownNat r, KnownNat c) => 
  DenseMatrix r c -> BasicSym -> DenseMatrix r c
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_mul_scalar ::
  forall r c.
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c -> BasicSym -> DenseMatrix r c

Perhaps

densematrixMulScalar ::
  forall r c.
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c -> BasicSym -> DenseMatrix r c

Use camelCase
Open

densematrix_ldl :: (KnownNat r, KnownNat c) => DenseMatrix r c-> (L r c, D r c)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_ldl ::
  (KnownNat r, KnownNat c) => DenseMatrix r c -> (L r c, D r c)

Perhaps

densematrixLdl ::
  (KnownNat r, KnownNat c) => DenseMatrix r c -> (L r c, D r c)

Redundant bracket
Open

                 (fromIntegral . natVal $ (Proxy @ c))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral . natVal $ (Proxy @c)

Perhaps

fromIntegral . natVal $ Proxy @c

Use camelCase
Open

densematrix_ffldu mat = unsafePerformIO $ do
  l <- densematrix_new
  d <- densematrix_new
  u <- densematrix_new
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_ffldu mat = ...

Perhaps

densematrixFfldu mat = ...

Use camelCase
Open

densematrix_size mat = 
   (fromIntegral . natVal $ (Proxy @ r), fromIntegral . natVal $ (Proxy @ c))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_size mat = ...

Perhaps

densematrixSize mat = ...

Use camelCase
Open

densematrix_lu :: (KnownNat r, KnownNat c) => DenseMatrix r c-> (L r c, U r c)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_lu ::
  (KnownNat r, KnownNat c) => DenseMatrix r c -> (L r c, U r c)

Perhaps

densematrixLu ::
  (KnownNat r, KnownNat c) => DenseMatrix r c -> (L r c, U r c)

Redundant bracket
Open

densematrix_new = DenseMatrix <$> (mkForeignPtr cdensematrix_new_ffi cdensematrix_free_ffi)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

DenseMatrix <$>
  (mkForeignPtr cdensematrix_new_ffi cdensematrix_free_ffi)

Perhaps

DenseMatrix <$>
  mkForeignPtr cdensematrix_new_ffi cdensematrix_free_ffi

Redundant bracket
Open

                                     (fromIntegral . natVal $ (Proxy @ r))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral . natVal $ (Proxy @r)

Perhaps

fromIntegral . natVal $ Proxy @r

Use camelCase
Open

densematrix_new_eye :: forall k r c. (KnownNat r,  KnownNat c, KnownNat k, KnownNat (r + k), KnownNat (c + k)) => DenseMatrix (r + k) (c + k)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_eye ::
  forall k r c.
  (KnownNat r,
   KnownNat c,
   KnownNat k,
   KnownNat (r + k),
   KnownNat (c + k)) =>
  DenseMatrix (r + k) (c + k)

Perhaps

densematrixNewEye ::
  forall k r c.
  (KnownNat r,
   KnownNat c,
   KnownNat k,
   KnownNat (r `+` k),
   KnownNat (c `+` k)) =>
  DenseMatrix (r `+` k) (c `+` k)

Redundant bracket
Open

                  (fromIntegral . natVal $ (Proxy @ c)))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral . natVal $ (Proxy @c)

Perhaps

fromIntegral . natVal $ Proxy @c

Use camelCase
Open

densematrix_new_diag :: forall k d. (KnownNat d, KnownNat k, KnownNat (d + k)) => V.Vector d BasicSym -> DenseMatrix (d + k) (d + k)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_diag ::
  forall k d.
  (KnownNat d, KnownNat k, KnownNat (d + k)) =>
  V.Vector d BasicSym -> DenseMatrix (d + k) (d + k)

Perhaps

densematrixNewDiag ::
  forall k d.
  (KnownNat d, KnownNat k, KnownNat (d `+` k)) =>
  V.Vector d BasicSym -> DenseMatrix (d `+` k) (d `+` k)

Use camelCase
Open

_densematrix_copy mat = do
   newmat <- densematrix_new
   throwOnSymIntException =<< with2 newmat mat cdensematrix_set_ffi
   return newmat
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

_densematrix_copy mat = ...

Perhaps

_densematrixCopy mat = ...

Redundant bracket
Open

                 (fromIntegral . natVal $ (Proxy @ k)))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral . natVal $ (Proxy @k)

Perhaps

fromIntegral . natVal $ Proxy @k

Use camelCase
Open

densematrix_fflu mat = unsafePerformIO $ do
  fflu <- densematrix_new
  throwOnSymIntException =<< with2 fflu mat cdensematrix_fflu
  return (FFLU fflu)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_fflu mat = ...

Perhaps

densematrixFflu mat = ...

Use camelCase
Open

densematrix_new_rows_cols ::  forall r c . (KnownNat r, KnownNat c) => DenseMatrix r c
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_rows_cols ::
  forall r c. (KnownNat r, KnownNat c) => DenseMatrix r c

Perhaps

densematrixNewRowsCols ::
  forall r c. (KnownNat r, KnownNat c) => DenseMatrix r c

Use camelCase
Open

densematrix_lu mat = unsafePerformIO $ do
   l <- densematrix_new
   u <- densematrix_new
   throwOnSymIntException =<< with3 l u mat cdensematrix_lu
   return (L l, U u)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_lu mat = ...

Perhaps

densematrixLu mat = ...

Use camelCase
Open

densematrix_fflu :: (KnownNat r, KnownNat c) => DenseMatrix r c -> FFLU r c
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_fflu ::
  (KnownNat r, KnownNat c) => DenseMatrix r c -> FFLU r c

Perhaps

densematrixFflu ::
  (KnownNat r, KnownNat c) => DenseMatrix r c -> FFLU r c

Use camelCase
Open

densematrix_new :: (KnownNat r, KnownNat c) => IO (DenseMatrix r c)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new :: (KnownNat r, KnownNat c) => IO (DenseMatrix r c)

Perhaps

densematrixNew :: (KnownNat r, KnownNat c) => IO (DenseMatrix r c)

Use camelCase
Open

densematrix_new = DenseMatrix <$> (mkForeignPtr cdensematrix_new_ffi cdensematrix_free_ffi)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new = ...

Perhaps

densematrixNew = ...

Avoid lambda
Open

  let cdensemat =  with vec (\v -> cdensematrix_new_vec_ffi
                                     (fromIntegral . natVal $ (Proxy @ r))
                                     (fromIntegral . natVal $ (Proxy @ c)) v)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

\ v ->
  cdensematrix_new_vec_ffi (fromIntegral . natVal $ (Proxy @r))
    (fromIntegral . natVal $ (Proxy @c))
    v

Perhaps

cdensematrix_new_vec_ffi (fromIntegral . natVal $ (Proxy @r))
  (fromIntegral . natVal $ (Proxy @c))

Use camelCase
Open

densematrix_new_diag syms  = unsafePerformIO $ do
  let offset = fromIntegral $ natVal (Proxy @ k)
  let diagonal = fromIntegral $ natVal (Proxy @ d)
  let dim = offset + diagonal
  vecsyms <- vector_to_vecbasic syms
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_diag syms = ...

Perhaps

densematrixNewDiag syms = ...

Redundant bracket
Open

foreign import ccall unsafe "symengine/cwrapper.h &dense_matrix_free" cdensematrix_free_ffi :: FunPtr ((Ptr CDenseMatrix) -> IO ())
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

(Ptr CDenseMatrix) -> IO ()

Perhaps

Ptr CDenseMatrix -> IO ()

Redundant $
Open

      let indexc = fromIntegral $ (getFinite getc)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral $ (getFinite getc)

Perhaps

fromIntegral (getFinite getc)

Use camelCase
Open

densematrix_set mat r c sym = unsafePerformIO $ do
    mat' <- _densematrix_copy mat
    throwOnSymIntException =<< with2 mat' sym (\m s -> cdensematrix_set_basic_ffi 
                              m
                              (fromIntegral . getFinite $ r)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_set mat r c sym = ...

Perhaps

densematrixSet mat r c sym = ...

Use camelCase
Open

densematrix_add mata matb = unsafePerformIO $ do
   res <- densematrix_new
   throwOnSymIntException =<< with3 res mata matb cdensematrix_add_matrix_ffi
   return res
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_add mata matb = ...

Perhaps

densematrixAdd mata matb = ...

Redundant bracket
Open

                                     (fromIntegral . natVal $ (Proxy @ c)) v)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral . natVal $ (Proxy @c)

Perhaps

fromIntegral . natVal $ Proxy @c

Redundant bracket
Open

      let indexr = fromIntegral $ (getFinite getr)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral $ (getFinite getr)

Perhaps

fromIntegral $ getFinite getr

Use camelCase
Open

densematrix_add :: forall r c. (KnownNat r, KnownNat c) => 
  DenseMatrix r c -> DenseMatrix r c -> DenseMatrix r c
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_add ::
  forall r c.
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c -> DenseMatrix r c -> DenseMatrix r c

Perhaps

densematrixAdd ::
  forall r c.
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c -> DenseMatrix r c -> DenseMatrix r c

Use camelCase
Open

densematrix_mul_matrix :: forall r k c. (KnownNat r, KnownNat k, KnownNat c) => 
  DenseMatrix r k -> DenseMatrix k c -> DenseMatrix r c
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_mul_matrix ::
  forall r k c.
  (KnownNat r, KnownNat k, KnownNat c) =>
  DenseMatrix r k -> DenseMatrix k c -> DenseMatrix r c

Perhaps

densematrixMulMatrix ::
  forall r k c.
  (KnownNat r, KnownNat k, KnownNat c) =>
  DenseMatrix r k -> DenseMatrix k c -> DenseMatrix r c

Use camelCase
Open

densematrix_new_vec syms = unsafePerformIO $ do
  vec <- vector_to_vecbasic syms
  let cdensemat =  with vec (\v -> cdensematrix_new_vec_ffi
                                     (fromIntegral . natVal $ (Proxy @ r))
                                     (fromIntegral . natVal $ (Proxy @ c)) v)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_vec syms = ...

Perhaps

densematrixNewVec syms = ...

Use camelCase
Open

densematrix_new_zeros = unsafePerformIO $ do
  let mat = densematrix_new_rows_cols
  throwOnSymIntException =<< with mat (\m -> cdensematrix_zeros_ffi m
                  (fromIntegral . natVal $ (Proxy @ r))
                  (fromIntegral . natVal $ (Proxy @ c)))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_zeros = ...

Perhaps

densematrixNewZeros = ...

Use camelCase
Open

densematrix_ffldu ::  (KnownNat r, KnownNat c) =>
  DenseMatrix r c -> (L r c, D r c, U r c)
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_ffldu ::
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c -> (L r c, D r c, U r c)

Perhaps

densematrixFfldu ::
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c -> (L r c, D r c, U r c)

Redundant bracket
Open

                  (fromIntegral . natVal $ (Proxy @ r))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral . natVal $ (Proxy @r)

Perhaps

fromIntegral . natVal $ Proxy @r

Use camelCase
Open

densematrix_mul_scalar mata sym = unsafePerformIO $ do
   res <- densematrix_new
   throwOnSymIntException =<< with3 res mata sym cdensematrix_mul_scalar_ffi
   return res
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_mul_scalar mata sym = ...

Perhaps

densematrixMulScalar mata sym = ...

Use camelCase
Open

densematrix_lu_solve :: (KnownNat r, KnownNat c) => 
  DenseMatrix r c -> DenseMatrix r c -> DenseMatrix r c
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_lu_solve ::
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c -> DenseMatrix r c -> DenseMatrix r c

Perhaps

densematrixLuSolve ::
  (KnownNat r, KnownNat c) =>
  DenseMatrix r c -> DenseMatrix r c -> DenseMatrix r c

Redundant bracket
Open

  DenseMatrix :: (KnownNat r, KnownNat c) => (ForeignPtr CDenseMatrix) -> DenseMatrix r c
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

(ForeignPtr CDenseMatrix) -> DenseMatrix r c

Perhaps

ForeignPtr CDenseMatrix -> DenseMatrix r c

Use camelCase
Open

densematrix_new_rows_cols = 
    unsafePerformIO $ DenseMatrix <$>
      (mkForeignPtr (cdensematrix_new_rows_cols_ffi 
                      (fromIntegral . natVal $ (Proxy @ r))
                      (fromIntegral . natVal $ (Proxy @ c)))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_rows_cols = ...

Perhaps

densematrixNewRowsCols = ...

Use camelCase
Open

densematrix_new_eye = unsafePerformIO $ do
  let mat = densematrix_new_rows_cols
  throwOnSymIntException =<< with mat (\m -> cdensematrix_eye_ffi m
                 (fromIntegral . natVal $ (Proxy @ r))
                 (fromIntegral . natVal $ (Proxy @ c))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_new_eye = ...

Perhaps

densematrixNewEye = ...

Redundant bracket
Open

                 (fromIntegral . natVal $ (Proxy @ r))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral . natVal $ (Proxy @r)

Perhaps

fromIntegral . natVal $ Proxy @r

Redundant bracket
Open

   (fromIntegral . natVal $ (Proxy @ r), fromIntegral . natVal $ (Proxy @ c))
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

fromIntegral . natVal $ (Proxy @r)

Perhaps

fromIntegral . natVal $ Proxy @r

Use camelCase
Open

densematrix_mul_matrix mata matb = unsafePerformIO $ do
   res <- densematrix_new
   throwOnSymIntException =<< with3 res mata matb cdensematrix_mul_matrix_ffi
   return res
Severity: Minor
Found in src/Symengine/DenseMatrix.hs by hlint

Found

densematrix_mul_matrix mata matb = ...

Perhaps

densematrixMulMatrix mata matb = ...

There are no issues that match your filters.

Category
Status