Sign upLogin

bollu/symengine.hs

View on GitHub
Star
src/Symengine/NumberTheory.hs

Summary

Maintainability
Test Coverage

Use fewer imports
Open

import Control.Monad -- for foldM
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

import Control.Monad
import Control.Monad

Perhaps

import Control.Monad

Unused LANGUAGE pragma
Open

{-# LANGUAGE FunctionalDependencies #-}
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

{-# LANGUAGE FunctionalDependencies #-}

Perhaps

Applying this change:

  • may require {-# LANGUAGE MultiParamTypeClasses #-} adding to the top of the file

Unused LANGUAGE pragma
Open

{-# LANGUAGE RecordWildCards #-}
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

{-# LANGUAGE RecordWildCards #-}

Perhaps

Applying this change:

  • may require {-# LANGUAGE DisambiguateRecordFields #-} adding to the top of the file

Use camelCase
Open

gcd_extended a b = unsafePerformIO $ do
  g <- basicsym_new
  s <- basicsym_new
  t <- basicsym_new
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

gcd_extended a b = ...

Perhaps

gcdExtended a b = ...

Use camelCase
Open

gcd_extended :: BasicSym -> BasicSym -> (BasicSym, BasicSym, BasicSym)
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

gcd_extended ::
  BasicSym -> BasicSym -> (BasicSym, BasicSym, BasicSym)

Perhaps

gcdExtended ::
  BasicSym -> BasicSym -> (BasicSym, BasicSym, BasicSym)

Use camelCase
Open

mod_f :: BasicSym -> BasicSym -> Quotient
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

mod_f :: BasicSym -> BasicSym -> Quotient

Perhaps

modF :: BasicSym -> BasicSym -> Quotient

Use camelCase
Open

mod_f = lift_basicsym_binaryop ntheory_mod_f_ffi
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

mod_f = ...

Perhaps

modF = ...

Use camelCase
Open

quotient_and_mod a b = unsafePerformIO $ do
  quotient <- basicsym_new
  modulo <- basicsym_new
  with4 quotient modulo a b ntheory_quotient_mod_ffi
  return $  (quotient, modulo)
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

quotient_and_mod a b = ...

Perhaps

quotientAndMod a b = ...

Use camelCase
Open

mod_inverse = lift_basicsym_binaryop ntheory_mod_inverse_ffi
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

mod_inverse = ...

Perhaps

modInverse = ...

Use camelCase
Open

quotient_f = lift_basicsym_binaryop ntheory_quotient_f_ffi
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

quotient_f = ...

Perhaps

quotientF = ...

Use camelCase
Open

quotient_and_mod_f a b = unsafePerformIO $ do
  quotient <- basicsym_new
  modulo <- basicsym_new
  with4 quotient modulo a b ntheory_quotient_mod_f_ffi
  return $  (quotient, modulo)
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

quotient_and_mod_f a b = ...

Perhaps

quotientAndModF a b = ...

Use camelCase
Open

next_prime :: BasicSym -> BasicSym
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

next_prime :: BasicSym -> BasicSym

Perhaps

nextPrime :: BasicSym -> BasicSym

Redundant $
Open

  return $  (quotient, modulo)
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

return $ (quotient, modulo)

Perhaps

return (quotient, modulo)

Use camelCase
Open

next_prime = lift_basicsym_unaryop ntheory_nextprime_ffi
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

next_prime = ...

Perhaps

nextPrime = ...

Use camelCase
Open

quotient_f :: BasicSym -> BasicSym -> BasicSym
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

quotient_f :: BasicSym -> BasicSym -> BasicSym

Perhaps

quotientF :: BasicSym -> BasicSym -> BasicSym

Use camelCase
Open

quotient_and_mod_f :: BasicSym -> BasicSym -> (Quotient, Modulo)
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

quotient_and_mod_f :: BasicSym -> BasicSym -> (Quotient, Modulo)

Perhaps

quotientAndModF :: BasicSym -> BasicSym -> (Quotient, Modulo)

Redundant $
Open

  return $  (quotient, modulo)
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

return $ (quotient, modulo)

Perhaps

return (quotient, modulo)

Use camelCase
Open

mod_inverse :: BasicSym -> BasicSym -> Quotient
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

mod_inverse :: BasicSym -> BasicSym -> Quotient

Perhaps

modInverse :: BasicSym -> BasicSym -> Quotient

Avoid lambda
Open

                    with b (\b ->
                              ntheory_gcd_ext_ffi g s t a b))
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

\ b -> ntheory_gcd_ext_ffi g s t a b

Perhaps

ntheory_gcd_ext_ffi g s t a

Use camelCase
Open

quotient_and_mod :: BasicSym -> BasicSym -> (Quotient, Modulo)
Severity: Minor
Found in src/Symengine/NumberTheory.hs by hlint

Found

quotient_and_mod :: BasicSym -> BasicSym -> (Quotient, Modulo)

Perhaps

quotientAndMod :: BasicSym -> BasicSym -> (Quotient, Modulo)

There are no issues that match your filters.

Category
Status