bookbrainz/bookbrainz-site

Similar blocks of code found in 4 locations. Consider refactoring.

Open

                        <Nav.Item>
                            <Nav.Link
                                active={tabActive === 3}
                                href={`/editor/${editor.id}/collections`}
                            >

• Read up
  Read up

Function diffRevisionsWithParents has 46 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function diffRevisionsWithParents(orm, entityRevisions, entityType) {
    // entityRevisions - collection of *entityType*_revisions matching id
    const promises = entityRevisions.map(
        async (revision) => {
            const dataId = revision.get('dataId');

Function dateValidator has 46 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export function dateValidator(dayObj, monthObj, yearObj) {
    const year = Number.parseInt(yearObj, 10);
    const month = Number.parseInt(monthObj, 10);
    const day = Number.parseInt(dayObj, 10);

Function constructPrivsChangeStatement has 46 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function constructPrivsChangeStatement(logData: AdminLogDataT) {
    const {newPrivs, oldPrivs, targetUserId, targetUser, adminId, admin} = logData;
    const {privsAdded, privsRemoved} = getPrivsChanged(newPrivs, oldPrivs);

    let grantStatement = '';

Function loadEntityRelationships has 45 lines of code (exceeds 25 allowed). Consider refactoring.

Open

async function loadEntityRelationships(entity, orm, transacting): Promise<any> {
    async function getEntityWithAlias(relEntity) {
        const redirectBbid = await orm.func.entity.recursivelyGetRedirectBBID(orm, relEntity.bbid, null);
        const model = commonUtils.getEntityModelByType(orm, relEntity.type);
        return model.forge({bbid: redirectBbid})

Function handleDelete has 45 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export function handleDelete(
    orm: any, req: PassportRequest, res: $Response, HeaderModel: any,
    RevisionModel: any
) {
    const {entity}: {entity?: any} = res.locals;

Function cleanupOnExit has 45 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function cleanupOnExit(cleanupPromise) {
    process.on('asyncExit', () => {
        cleanupPromise().then(() => {
            console.log('Cleanup process finished');
            process.exit(0);

Similar blocks of code found in 6 locations. Consider refactoring.

Open

router.get('/:bbid',
    makeEntityLoader('Publisher', publisherBasicRelations, publisherError),
    async (req, res) => {
        const publisherBasicInfo = await getPublisherBasicInfo(res.locals.entity);
        return res.status(200).send(publisherBasicInfo);

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

router.get('/:bbid',
    makeEntityLoader('EditionGroup', editionGroupBasicRelations, editionGroupError),
    async (req, res) => {
        const editionGroupBasicInfo = await getEditionGroupBasicInfo(res.locals.entity);
        return res.status(200).send(editionGroupBasicInfo);

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

router.get('/:bbid',
    makeEntityLoader('Edition', editionBasicRelations, editionError),
    async (req, res) => {
        const editionBasicInfo = await getEditionBasicInfo(res.locals.entity);
        return res.status(200).send(editionBasicInfo);

• Read up
  Read up

Function mapDispatchToProps has 45 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function mapDispatchToProps(dispatch: Dispatch<Action>): DispatchProps {
    return {
        onDepthChange: (event) => dispatch(debouncedUpdateDepth(
            event.target.value ? parseInt(event.target.value, 10) : null
        )),

Similar blocks of code found in 6 locations. Consider refactoring.

Open

router.get('/:bbid',
    makeEntityLoader('Author', authorBasicRelations, authorError),
    async (req, res) => {
        const authorBasicInfo = await getAuthorBasicInfo(res.locals.entity);
        return res.status(200).send(authorBasicInfo);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (_.findIndex(sortNameOptions, ['label', entity.defaultAlias.sortName]) === -1) {
            sortNameOptions.push({label: entity.defaultAlias.sortName, value: entity.defaultAlias.sortName});
        }

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

router.get('/:bbid',
    makeEntityLoader('Series', seriesBasicRelations, seriesError),
    async (req, res) => {
        const seriesBasicInfo = await getSeriesBasicInfo(res.locals.entity);
        return res.status(200).send(seriesBasicInfo);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (_.findIndex(nameOptions, ['label', entity.defaultAlias.name]) === -1) {
            nameOptions.push({label: entity.defaultAlias.name, value: entity.defaultAlias.name});
        }

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

router.get('/:bbid',
    makeEntityLoader('Work', workBasicRelations, workError),
    async (req, res) => {
        const workBasicInfo = await getWorkBasicInfo(res.locals.entity);
        return res.status(200).send(workBasicInfo);

• Read up
  Read up

Function render has 45 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    render() {
        const {type, query, results} = this.state;
        const querySearchParams = `q=${query}${type ? `&type=${type}` : ''}`;
        return (
            <div id="pageWithPagination">

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                        <Form.Label>
                            {annotationLabel}
                            <OverlayTrigger delay={50} overlay={tooltip}>
                                <FontAwesomeIcon
                                    className="margin-left-0-5"

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                        <Form.Label>
                            {editNoteLabel}
                            <OverlayTrigger delay={50} overlay={tooltip}>
                                <FontAwesomeIcon
                                    className="margin-left-0-5"

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

            <Form.Label>
                {label}
                <OverlayTrigger delay={50} overlay={tooltip}>
                    <FontAwesomeIcon className="margin-left-0-5" icon={faQuestionCircle}/>
                </OverlayTrigger>

• Read up
  Read up