Sign upLogin

bookbrainz/bookbrainz-site

View on GitHub
Star

Showing 1,033 of 1,033 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            <Form.Label>
                {label}
                <OverlayTrigger delay={50} overlay={tooltip}>
                    <FontAwesomeIcon
                        className="margin-left-0-5"
Severity: Major
Found in src/client/entity-editor/common/language-field.tsx and 3 other locations - About 1 hr to fix
src/client/entity-editor/author-credit-editor/author-credit-section.tsx on lines 161..169
src/client/entity-editor/common/sort-name-field.tsx on lines 174..179
src/client/entity-editor/name-section/disambiguation-field.tsx on lines 69..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

                    <Form.Label>
                        {label}
                        <OverlayTrigger delay={50} overlay={tooltip}>
                            <FontAwesomeIcon
                                className="margin-left-0-5"
Severity: Major
Found in src/client/entity-editor/author-credit-editor/author-credit-section.tsx and 3 other locations - About 1 hr to fix
src/client/entity-editor/common/language-field.tsx on lines 99..107
src/client/entity-editor/common/sort-name-field.tsx on lines 174..179
src/client/entity-editor/name-section/disambiguation-field.tsx on lines 69..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            <Form.Label>
                {label}
                <OverlayTrigger delay={50} overlay={tooltip}>
                    <FontAwesomeIcon
                        className="margin-left-0-5"
Severity: Major
Found in src/client/entity-editor/name-section/disambiguation-field.tsx and 3 other locations - About 1 hr to fix
src/client/entity-editor/author-credit-editor/author-credit-section.tsx on lines 161..169
src/client/entity-editor/common/language-field.tsx on lines 99..107
src/client/entity-editor/common/sort-name-field.tsx on lines 174..179

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    <Row>
                        <Col lg={lgCol}>
                            <EntitySearchFieldOption
                                instanceId="endArea"
                                label={endAreaLabel}
Severity: Major
Found in src/client/entity-editor/author-section/author-section.tsx and 1 other location - About 1 hr to fix
src/client/entity-editor/author-section/author-section.tsx on lines 231..241

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            <Row>
                <Col lg={lgCol}>
                    <EntitySearchFieldOption
                        instanceId="beginArea"
                        label={beginAreaLabel}
Severity: Major
Found in src/client/entity-editor/author-section/author-section.tsx and 1 other location - About 1 hr to fix
src/client/entity-editor/author-section/author-section.tsx on lines 265..275

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function processEdit has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function processEdit(orm, userId, revisionId) {
    const revisionist = await processRevisionist(orm, userId);
    const authorCreator = await processAuthorCreator(orm, userId);
    const limitedEdition = await processLimitedEdition(orm, userId);
    const publisher = await processPublisher(orm, userId);
Severity: Minor
Found in src/server/helpers/achievement.js - About 1 hr to fix

    Function formatEntityDiffs has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function formatEntityDiffs(diffs, entityType, entityFormatter) {
    if (!diffs) {
        return [];
    }
    Severity: Minor
    Found in src/server/helpers/diffFormatters/entity.js - About 1 hr to fix

      Function getEntityRelations has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getEntityRelations(entityType) {
    const authorRelations = [
        'defaultAlias.language',
        'disambiguation',
        'authorType',
      Severity: Minor
      Found in src/server/routes/collection.js - About 1 hr to fix

        Function EditionSection has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        function EditionSection({
    depthValue,
    editionFormats,
    editionStatuses,
    formatValue,
        Severity: Minor
        Found in src/client/entity-editor/edition-section/edition-section.tsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function mapDispatchToProps has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        function mapDispatchToProps(dispatch):ISBNDispatchProps {
    let autoAddedISBN:dispatchResultProps|null;
    function onChange(value:string, autoISBN = false) {
        const isbn10rgx = new
        RegExp('^(?:ISBN(?:-10)?:?●)?(?=[0-9X]{10}$|(?=(?:[0-9]+[-●]){3})[-●0-9X]{13}$)[0-9]{1,5}[-●]?[0-9]+[-●]?[0-9]+[-●]?[0-9X]$');
        Severity: Minor
        Found in src/client/unified-form/cover-tab/isbn-field.tsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getEntityDiff has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            static getEntityDiff(diff) {
        let mergeBadge = null;
        let deleteBadge = null;
        if (diff.isDeletion) {
            if (diff.entityRevision.isMerge) {
        Severity: Minor
        Found in src/client/components/pages/revision.js - About 1 hr to fix

          Function init has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function init(app, config) {
    const influxConfig = config.influx;

    const influx = new Influx.InfluxDB({
        database: influxConfig.database || 'bookbrainz',
          Severity: Minor
          Found in src/server/influx.js - About 1 hr to fix

            Function renderEntitySelect has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                renderEntitySelect() {
        const {baseEntity, relationshipTypes} = this.props;
        const {targetEntity} = this.state;
        const types = getValidOtherEntityTypes(relationshipTypes, baseEntity);
        if (!types.length) {
            Severity: Minor
            Found in src/client/entity-editor/relationship-editor/relationship-editor.tsx - About 1 hr to fix

              Function getBrowsedRelationships has 43 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export async function getBrowsedRelationships(orm, locals, browsedEntityType,
                                              getEntityInfoMethod, fetchRelated, filterRelationshipMethod) {
    const {entity, relationships} = locals;

    if (!relationships.length > 0) {
              Severity: Minor
              Found in src/api/helpers/utils.js - About 1 hr to fix

                Function render has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    render() {
        const {query, results} = this.state;
        const querySearchParams = `q=${query}&type=editor`;
        return (
            <Card>
                Severity: Minor
                Found in src/client/components/pages/admin-panel-search.tsx - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      const helpIconElement = tooltipText && (
        <OverlayTrigger
            delay={50}
            overlay={<Tooltip>{tooltipText}</Tooltip>}
        >
                  Severity: Major
                  Found in src/client/entity-editor/common/name-field.tsx and 1 other location - About 1 hr to fix
                  src/client/entity-editor/common/merge-field.tsx on lines 66..70

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 69.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      const helpIconElement = tooltipText && (
        <OverlayTrigger delay={50} overlay={<Tooltip>{tooltipText}</Tooltip>}>
            <FontAwesomeIcon className="margin-left-0-5" icon={faQuestionCircle}/>
        </OverlayTrigger>
    );
                  Severity: Major
                  Found in src/client/entity-editor/common/merge-field.tsx and 1 other location - About 1 hr to fix
                  src/client/entity-editor/common/name-field.tsx on lines 64..74

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 69.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function AdminLogsTable has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function AdminLogsTable(props) {
    const {results, tableHeading} = props;
    return (
        <div>
            <div>
                  Severity: Minor
                  Found in src/client/components/pages/parts/admin-logs-table.js - About 1 hr to fix

                    Function DevelopPage has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function DevelopPage(): JSX.Element {
    return (
        <div>
            <div className="page-header">
                <h1>Developing with BookBrainz</h1>
                    Severity: Minor
                    Found in src/client/components/pages/develop.tsx - About 1 hr to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                      <Col lg={2}>
                    <dl>
                        <dt>Ordering Type</dt>
                        <dd>{series.seriesOrderingType.label}</dd>
                    </dl>
                      Severity: Major
                      Found in src/client/components/pages/entities/series.js and 1 other location - About 1 hr to fix
                      src/client/components/pages/entities/series.js on lines 67..72

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 68.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language