bparzella/secsgem

View on GitHub
data/data_item.py

Summary

Maintainability
A
2 hrs
Test Coverage

DataItem has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

class DataItem:
    """Data item configuration from yaml."""

    def __init__(self, name, data) -> None:
        """Initialize item config."""
Severity: Minor
Found in data/data_item.py - About 2 hrs to fix

    Function _extra_variables_binary has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def _extra_variables_binary(self) -> str:
            if "values" not in self._data:
                return ""
    
            variables = []
    Severity: Minor
    Found in data/data_item.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Merge this if statement with the enclosing one.
    Open

                if self.type[0] in ("Boolean"):
    Severity: Major
    Found in data/data_item.py by sonar-python

    Merging collapsible if statements increases the code's readability.

    Noncompliant Code Example

    if condition1:
        if condition2:
            # ...
    

    Compliant Solution

    if condition1 and condition2:
        # ...
    

    Merge this if statement with the enclosing one.
    Open

                if self.type[0] == "Boolean":
    Severity: Major
    Found in data/data_item.py by sonar-python

    Merging collapsible if statements increases the code's readability.

    Noncompliant Code Example

    if condition1:
        if condition2:
            # ...
    

    Compliant Solution

    if condition1 and condition2:
        # ...
    

    There are no issues that match your filters.

    Category
    Status