Sign upLogin

bq/composr-core

View on GitHub
Star

Showing 38 of 38 total issues

Function currifiedToArrayPromise has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function currifiedToArrayPromise (itemOrItems) {
  if (!itemOrItems) {
    return function () {
      return Promise.reject()
    }
Severity: Minor
Found in src/lib/utils/currifiedToArrayPromise.js - About 1 hr to fix

    Function init has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function init (options, fetch) {
  var module = this

  this.reset()
    Severity: Minor
    Found in src/lib/init.js - About 1 hr to fix

      Function loadSome has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      BaseDao.prototype.loadSome = function loadSome (ids) {
  var that = this

  if (!ids || !Array.isArray(ids)) {
    return Promise.reject('missing:ids')
      Severity: Minor
      Found in src/lib/daos/BaseDao.js - About 1 hr to fix

        Function initCorbelDriver has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function initCorbelDriver () {
  if (!this.config.credentials.clientId) {
    return Promise.reject('Missing config.credentials.clientId')
  }
        Severity: Minor
        Found in src/lib/initCorbelDriver.js - About 1 hr to fix

          Function send has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          MockedResponse.prototype.send = function send (maybeCode, maybeBody) {
  if (!this.finished) {
    var status = this.statusCode || 200
    var data
          Severity: Minor
          Found in src/lib/mock/mockedResponse.js - About 1 hr to fix

            Function regexp has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              var regexp = pathParams.reduce(function (prev, item, index) {
    var newValue = ''

    if (index !== 0) {
      // Theres a previous value, add a slash
            Severity: Minor
            Found in src/lib/regexpGenerator.js - About 1 hr to fix

              Function runByPath has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              PhraseManager.prototype.runByPath = function runByPath (domain, path, verb, params, version, cb) {
  if (utils.values.isFalsy(verb)) {
    verb = 'get'
  }
              Severity: Minor
              Found in src/lib/managers/Phrase.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function runByPath has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              PhraseManager.prototype.runByPath = function runByPath (domain, path, verb, params, version, cb) {
              Severity: Minor
              Found in src/lib/managers/Phrase.js - About 45 mins to fix

                Function validate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                function validate (snippet) {
  var errors = []

  var errorAccumulator = utils.errorAccumulator(errors)
                Severity: Minor
                Found in src/lib/validators/snippet.validator.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    var queryParamsString = path.indexOf('?') !== -1 ? path.substring(path.indexOf('?'), path.length) : ''
                Severity: Minor
                Found in src/lib/managers/Phrase.js and 1 other location - About 40 mins to fix
                src/lib/managers/Phrase.js on lines 258..258

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                  var queryParamsString = path.indexOf('?') !== -1 ? path.substring(path.indexOf('?'), path.length) : ''
                Severity: Minor
                Found in src/lib/managers/Phrase.js and 1 other location - About 40 mins to fix
                src/lib/managers/Phrase.js on lines 94..94

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function documentation has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function documentation (phrases, snippets, domain, version, basePathDoc) {
                Severity: Minor
                Found in src/lib/doc/documentation.js - About 35 mins to fix

                  Function getAllRecursively has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  var getAllRecursively = function getAllRecursively (caller, pageNumber, pageSize, items, promise) {
                  Severity: Minor
                  Found in src/lib/utils.js - About 35 mins to fix

                    Function __executeScriptMode has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    PhraseModel.prototype.__executeScriptMode = function __executeScriptMode (verb, parameters, timeout, file, events) {
                    Severity: Minor
                    Found in src/lib/models/PhraseModel.js - About 35 mins to fix

                      Function _run has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      PhraseManager.prototype._run = function _runPhrase (phrase, verb, params, domain, cb) {
                      Severity: Minor
                      Found in src/lib/managers/Phrase.js - About 35 mins to fix

                        Function getByMatchingPath has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                        PhraseManager.prototype.getByMatchingPath = function getByMatchingPath (domain, path, verb, version) {
  var candidate = null

  if (!verb) {
    verb = 'get'
                        Severity: Minor
                        Found in src/lib/managers/Phrase.js - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Avoid too many return statements within this function.
                        Open

                          return new Promise(function (resolve, reject) {
    try {
      var options = {
        clientId: module.config.credentials.clientId,
        clientSecret: module.config.credentials.clientSecret,
                        Severity: Major
                        Found in src/lib/initCorbelDriver.js - About 30 mins to fix

                          Function __executeScriptMode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          PhraseModel.prototype.__executeScriptMode = function __executeScriptMode (verb, parameters, timeout, file, events) {
  var options = {
    timeout: timeout || 10000,
    displayErrors: true
  }
                          Severity: Minor
                          Found in src/lib/models/PhraseModel.js - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language