Sign upLogin

bq/composr-core

View on GitHub
Star

Showing 38 of 38 total issues

Function documentation has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function documentation (phrases, snippets, domain, version, basePathDoc) {
  if (!phrases) {
    phrases = []
  }
Severity: Major
Found in src/lib/doc/documentation.js - About 3 hrs to fix

    Function regexpUrl has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    function regexpUrl (url) {
  var pathParams = url.split('/')
  var EMPTY_PARAMS_REGEXP = '^$|^/$'

  var paramsLength = pathParams.length
    Severity: Minor
    Found in src/lib/regexpGenerator.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function validate has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function validate (phrase) {
  var errors = []

  var errorAccumulator = utils.errorAccumulator(errors)
    Severity: Major
    Found in src/lib/validators/phrase.validator.js - About 2 hrs to fix

      Function transform has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function transform (phrases, urlBase, domain, version) {
  var doc = {}

  phrases.forEach(function (phrase) {
    _.extend(doc, buildPhraseDefinition(phrase))
      Severity: Minor
      Found in src/lib/compilers/raml.compiler.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        VirtualDomainManager.prototype._saveSnippets = function (snippets) {
  var module = this

  var promises = snippets.map(function (snippet) {
    return module.Snippet.save(snippet)
        Severity: Major
        Found in src/lib/managers/VirtualDomain.js and 1 other location - About 1 hr to fix
        src/lib/managers/VirtualDomain.js on lines 64..72

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        VirtualDomainManager.prototype._savePhrases = function (phrases) {
  var module = this

  var promises = phrases.map(function (phrase) {
    return module.Phrase.save(phrase)
        Severity: Major
        Found in src/lib/managers/VirtualDomain.js and 1 other location - About 1 hr to fix
        src/lib/managers/VirtualDomain.js on lines 74..82

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function exports has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function (grunt) {
  // show elapsed time at the end
  require('time-grunt')(grunt)
  // load all grunt tasks
  require('load-grunt-tasks')(grunt)
        Severity: Minor
        Found in Gruntfile.js - About 1 hr to fix

          Function regexpUrl has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function regexpUrl (url) {
  var pathParams = url.split('/')
  var EMPTY_PARAMS_REGEXP = '^$|^/$'

  var paramsLength = pathParams.length
          Severity: Minor
          Found in src/lib/regexpGenerator.js - About 1 hr to fix

            Function send has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

            MockedResponse.prototype.send = function send (maybeCode, maybeBody) {
  if (!this.finished) {
    var status = this.statusCode || 200
    var data
            Severity: Minor
            Found in src/lib/mock/mockedResponse.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function MockedRequest has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

            function MockedRequest (req, options) {
  if (!options) {
    options = {}
  }
            Severity: Minor
            Found in src/lib/mock/mockedRequest.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function requirerWrapper has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

            function requirerWrapper (Snippet) {
  return function requirer (domain, version, functionMode) {
    return function requirerForDomain (libName) {
      if (!libName || typeof (libName) !== 'string') {
        libName = ''
            Severity: Minor
            Found in src/lib/requirer.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              if (codeCompiled.error) {
    events.emit('warn', model.getId() + ':evaluatecode:wrong_code', codeCompiled.error)
  } else {
    events.emit('debug', model.getId() + ':evaluatecode:good')
  }
            Severity: Major
            Found in src/lib/models/SnippetModel.js and 1 other location - About 1 hr to fix
            src/lib/models/PhraseModel.js on lines 115..119

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (codeCompiled.error) {
          events.emit('warn', model.getId() + ':evaluatecode:wrong_code', codeCompiled.error)
        } else {
          events.emit('debug', model.getId() + ':evaluatecode:good')
        }
            Severity: Major
            Found in src/lib/models/PhraseModel.js and 1 other location - About 1 hr to fix
            src/lib/models/SnippetModel.js on lines 35..39

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function parseToComposrError has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

            function parseToComposrError (e, defaultError, defaultStatus) {
  var status = defaultStatus || 500
  var error = defaultError || 'Internal error'
  var errorDescription = e
            Severity: Minor
            Found in src/lib/parseToComposrError.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function validate has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function validate (snippet) {
  var errors = []

  var errorAccumulator = utils.errorAccumulator(errors)
            Severity: Minor
            Found in src/lib/validators/snippet.validator.js - About 1 hr to fix

              Function getByMatchingPath has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              PhraseManager.prototype.getByMatchingPath = function getByMatchingPath (domain, path, verb, version) {
  var candidate = null

  if (!verb) {
    verb = 'get'
              Severity: Minor
              Found in src/lib/managers/Phrase.js - About 1 hr to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                  return utils.getAllRecursively(caller)
    .catch(function (response) {
      var error = parseToComposrError(response.data, 'Invalid ' + that.COLLECTION + ' load', response.status)
      throw error
    })
                Severity: Major
                Found in src/lib/daos/BaseDao.js and 1 other location - About 1 hr to fix
                src/lib/daos/BaseDao.js on lines 59..63

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    return utils.getAllRecursively(caller)
      .catch(function (response) {
        var error = parseToComposrError(response.data, 'Invalid ' + that.COLLECTION + ' load', response.status)
        throw error
      })
                Severity: Major
                Found in src/lib/daos/BaseDao.js and 1 other location - About 1 hr to fix
                src/lib/daos/BaseDao.js on lines 83..87

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function _runPhrase has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                PhraseManager.prototype._run = function _runPhrase (phrase, verb, params, domain, cb) {
  this.events.emit('debug', 'running:phrase:' + phrase.getId() + ':' + verb)

  var urlBase = params.config && params.config.urlBase ? params.config.urlBase : this.config.urlBase
                Severity: Minor
                Found in src/lib/managers/Phrase.js - About 1 hr to fix

                  Function __executeFunctionMode has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  PhraseModel.prototype.__executeFunctionMode = function __executeFunctionMode (verb, parameters, timeout, file) {
  // @TODO: configure timeout
  // @TODO: enable VM if memory bug gets solved
  var url = this.getUrl()
                  Severity: Minor
                  Found in src/lib/models/PhraseModel.js - About 1 hr to fix
                    Severity
                    Category
                    Status
                    Source
                    Language