Sign upLogin

brainopia/sidekiq-limit_fetch

View on GitHub
Star
lib/sidekiq/limit_fetch/global/semaphore.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class Semaphore has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Semaphore
        PREFIX = 'limit_fetch'

        attr_reader :local_busy
Severity: Minor
Found in lib/sidekiq/limit_fetch/global/semaphore.rb - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              if value
            redis { |it| it.set "#{PREFIX}:limit:#{@name}", value }
          else
            redis { |it| it.del "#{PREFIX}:limit:#{@name}" }
    Severity: Minor
    Found in lib/sidekiq/limit_fetch/global/semaphore.rb and 1 other location - About 15 mins to fix
    lib/sidekiq/limit_fetch/global/semaphore.rb on lines 42..45

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              if value
            redis { |it| it.set "#{PREFIX}:process_limit:#{@name}", value }
          else
            redis { |it| it.del "#{PREFIX}:process_limit:#{@name}" }
    Severity: Minor
    Found in lib/sidekiq/limit_fetch/global/semaphore.rb and 1 other location - About 15 mins to fix
    lib/sidekiq/limit_fetch/global/semaphore.rb on lines 25..28

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status