bramp/js-sequence-diagrams

View on GitHub

Showing 25 of 25 total issues

File daniel_400.font.js has 910 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * The following copyright notice may not be removed under any circumstances.
 * 
 * Copyright:
 * Copyright (c) 2011 by Daniel Midgley. All rights reserved.
Severity: Major
Found in fonts/daniel/daniel_400.font.js - About 2 days to fix

    File daniel_black_900.font.js has 906 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*!
     * The following copyright notice may not be removed under any circumstances.
     * 
     * Copyright:
     * Copyright (c) 2011 by Daniel Midgley. All rights reserved.
    Severity: Major
    Found in fonts/daniel/daniel_black_900.font.js - About 2 days to fix

      File daniel_700.font.js has 878 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*!
       * The following copyright notice may not be removed under any circumstances.
       * 
       * Copyright:
       * Copyright (c) 2011 by Daniel Midgley. All rights reserved.
      Severity: Major
      Found in fonts/daniel/daniel_700.font.js - About 2 days to fix

        Function layout has 104 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          layout: function() {
            // Local copies
            var diagram = this.diagram;
            var font    = this.font_;
            var actors  = diagram.actors;
        Severity: Major
        Found in src/theme.js - About 4 hrs to fix

          File theme.js has 313 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          /** js sequence diagrams
           *  https://bramp.github.io/js-sequence-diagrams/
           *  (c) 2012-2017 Andrew Brampton (bramp.net)
           *  Simplified BSD license.
           */
          Severity: Minor
          Found in src/theme.js - About 3 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                "face": {
                    "font-family": "Daniel",
                    "font-weight": 700,
                    "font-stretch": "normal",
                    "units-per-em": "360",
            Severity: Major
            Found in fonts/daniel/daniel_700.font.js and 1 other location - About 1 hr to fix
            fonts/daniel/daniel_400.font.js on lines 29..42

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                "face": {
                    "font-family": "Daniel",
                    "font-weight": 400,
                    "font-stretch": "normal",
                    "units-per-em": "360",
            Severity: Major
            Found in fonts/daniel/daniel_400.font.js and 1 other location - About 1 hr to fix
            fonts/daniel/daniel_700.font.js on lines 29..42

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                drawSignal: function(signal, offsetY) {
                  this.beginGroup();
                  BaseTheme.prototype.drawSignal.call(this, signal, offsetY);
                  return this.finishGroup().addClass('signal');
                },
            Severity: Major
            Found in src/theme-snap.js and 2 other locations - About 1 hr to fix
            src/theme-snap.js on lines 242..246
            src/theme-snap.js on lines 248..252

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                drawNote: function(note, offsetY) {
                  this.beginGroup();
                  BaseTheme.prototype.drawNote.call(this, note, offsetY);
                  return this.finishGroup().addClass('note');
                },
            Severity: Major
            Found in src/theme-snap.js and 2 other locations - About 1 hr to fix
            src/theme-snap.js on lines 236..240
            src/theme-snap.js on lines 242..246

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                drawSelfSignal: function(signal, offsetY) {
                  this.beginGroup();
                  BaseTheme.prototype.drawSelfSignal.call(this, signal, offsetY);
                  return this.finishGroup().addClass('signal');
                },
            Severity: Major
            Found in src/theme-snap.js and 2 other locations - About 1 hr to fix
            src/theme-snap.js on lines 236..240
            src/theme-snap.js on lines 248..252

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              var SnapTheme = function(diagram, options, resume) {
                    _.defaults(options, {
                        'css-class': 'simple',
                        'font-size': 16,
                        'font-family': 'Andale Mono, monospace'
            Severity: Major
            Found in src/theme-snap.js and 1 other location - About 1 hr to fix
            src/theme-snap.js on lines 259..267

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              var SnapHandTheme = function(diagram, options, resume) {
                    _.defaults(options, {
                        'css-class': 'hand',
                        'font-size': 16,
                        'font-family': 'danielbd'
            Severity: Major
            Found in src/theme-snap.js and 1 other location - About 1 hr to fix
            src/theme-snap.js on lines 30..38

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              var p2 = {
                x: (x2 - x1) * r2 + x1 - xfactor,
                y: (y2 - y1) * r2 + y1 - yfactor
              };
            Severity: Minor
            Found in src/theme.js and 1 other location - About 45 mins to fix
            src/theme.js on lines 108..111

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function drawLine has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    drawLine: function(x1, y1, x2, y2, linetype, arrowhead) {
            Severity: Minor
            Found in src/theme-raphael.js - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                var p1 = {
                  x: (x2 - x1) * r1 + x1 + xfactor,
                  y: (y2 - y1) * r1 + y1 + yfactor
                };
              Severity: Minor
              Found in src/theme.js and 1 other location - About 45 mins to fix
              src/theme.js on lines 113..116

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function layout has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                layout: function() {
                  // Local copies
                  var diagram = this.diagram;
                  var font    = this.font_;
                  var actors  = diagram.actors;
              Severity: Minor
              Found in src/theme.js - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function drawTextBox has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                drawTextBox: function(box, text, margin, padding, font, align) {
              Severity: Minor
              Found in src/theme.js - About 45 mins to fix

                Function drawLine has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    drawLine: function(x1, y1, x2, y2, linetype, arrowhead) {
                Severity: Minor
                Found in src/theme-raphael.js - About 45 mins to fix

                  Function drawLine has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      drawLine: function(x1, y1, x2, y2, linetype, arrowhead) {
                  Severity: Minor
                  Found in src/theme-snap.js - About 45 mins to fix

                    Function drawText has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        drawText: function(x, y, text, font, align) {
                          text = this.cleanText(text);
                          font = font || {};
                          align = align || ALIGN_LEFT;
                    
                    
                    Severity: Minor
                    Found in src/theme-raphael.js - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language