bramp/js-sequence-diagrams

View on GitHub

Showing 25 of 25 total issues

Function drawLine has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        drawLine: function(x1, y1, x2, y2, linetype, arrowhead) {
Severity: Minor
Found in src/theme-raphael.js - About 45 mins to fix

    Function drawText has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        drawText: function(x, y, text, font, align) {
    Severity: Minor
    Found in src/theme-raphael.js - About 35 mins to fix

      Function drawText has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          drawText: function(x, y, text, font, align) {
      Severity: Minor
      Found in src/theme-snap.js - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          var RaphaelTheme = function(diagram, options, resume) {
                this.init(diagram, _.defaults(options, {
                    'font-size': 16,
                    'font-family': 'Andale Mono, monospace'
                  }), resume);
        Severity: Minor
        Found in src/theme-raphael.js and 1 other location - About 35 mins to fix
        src/theme-raphael.js on lines 165..170

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          var RaphaelHandTheme = function(diagram, options, resume) {
            this.init(diagram, _.defaults(options, {
                      'font-size': 16,
                      'font-family': 'daniel'
                    }), resume);
        Severity: Minor
        Found in src/theme-raphael.js and 1 other location - About 35 mins to fix
        src/theme-raphael.js on lines 34..39

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language