Sign upLogin

bueltge/wp-rest-api-filter-items

View on GitHub
Star
inc/Items/Post.php

Summary

Maintainability
A
1 hr
Test Coverage

__construct accesses the super-global variable $_GET.
Open

    public function __construct() {

        if ( ! isset( $_GET[ 'items' ] ) ) {
            return;
        }
Severity: Minor
Found in inc/Items/Post.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

__construct accesses the super-global variable $_GET.
Open

    public function __construct() {

        if ( ! isset( $_GET[ 'items' ] ) ) {
            return;
        }
Severity: Minor
Found in inc/Items/Post.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php # -*- coding: utf-8 -*-

namespace RestApiFilterItems\Items;

use RestApiFilterItems\Core\Filter;
Severity: Major
Found in inc/Items/Post.php and 2 other locations - About 1 hr to fix
inc/Items/Comments.php on lines 1..44
inc/Items/Taxonomy.php on lines 1..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

The variable $filtered_data is not named in camelCase.
Open

    public function filter_data( $data ) {

        $_data = $data->data;
        $filtered_data = new Filter( $this->request, $_data );
Severity: Minor
Found in inc/Items/Post.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_data is not named in camelCase.
Open

    public function filter_data( $data ) {

        $_data = $data->data;
        $filtered_data = new Filter( $this->request, $_data );
Severity: Minor
Found in inc/Items/Post.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_data is not named in camelCase.
Open

    public function filter_data( $data ) {

        $_data = $data->data;
        $filtered_data = new Filter( $this->request, $_data );
Severity: Minor
Found in inc/Items/Post.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $filtered_data is not named in camelCase.
Open

    public function filter_data( $data ) {

        $_data = $data->data;
        $filtered_data = new Filter( $this->request, $_data );
Severity: Minor
Found in inc/Items/Post.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The method filter_data is not named in camelCase.
Open

    public function filter_data( $data ) {

        $_data = $data->data;
        $filtered_data = new Filter( $this->request, $_data );
Severity: Minor
Found in inc/Items/Post.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status