Sign upLogin

bueltge/wp-rest-api-filter-items

View on GitHub
Star
lib/Requisite/Rule/NamespaceDirectoryMapper.php

Summary

Maintainability
A
0 mins
Test Coverage

Add curly braces around the nested statement(s).
Open

        if ( $this->base_ns === substr( $class, 0, strlen( $this->base_ns ) ) )
Severity: Critical
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by sonar-php

While not technically incorrect, the omission of curly braces can be misleading, and may lead to the introduction of errors during maintenance.

Noncompliant Code Example

if (condition)  // Noncompliant
  executeSomething();

Compliant Solution

if (condition) {
  executeSomething();
}

See

  • MISRA C:2004, 14.8 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
  • MISRA C:2004, 14.9 - An if (expression) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
  • MISRA C++:2008, 6-3-1 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
  • MISRA C++:2008, 6-4-1 - An if (condition) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
  • MISRA C:2012, 15.6 - The body of an iteration-statement or a selection-statement shall be a compound-statement
  • CERT, EXP19-C. - Use braces for the body of an if, for, or while statement
  • CERT, EXP52-J. - Use braces for the body of an if, for, or while statement

Add curly braces around the nested statement(s).
Open

        if ( ! empty( $base_ns ) )
Severity: Critical
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by sonar-php

While not technically incorrect, the omission of curly braces can be misleading, and may lead to the introduction of errors during maintenance.

Noncompliant Code Example

if (condition)  // Noncompliant
  executeSomething();

Compliant Solution

if (condition) {
  executeSomething();
}

See

  • MISRA C:2004, 14.8 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
  • MISRA C:2004, 14.9 - An if (expression) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
  • MISRA C++:2008, 6-3-1 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
  • MISRA C++:2008, 6-4-1 - An if (condition) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
  • MISRA C:2012, 15.6 - The body of an iteration-statement or a selection-statement shall be a compound-statement
  • CERT, EXP19-C. - Use braces for the body of an if, for, or while statement
  • CERT, EXP52-J. - Use braces for the body of an if, for, or while statement

Add curly braces around the nested statement(s).
Open

        if ( ! $file_loader )
Severity: Critical
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by sonar-php

While not technically incorrect, the omission of curly braces can be misleading, and may lead to the introduction of errors during maintenance.

Noncompliant Code Example

if (condition)  // Noncompliant
  executeSomething();

Compliant Solution

if (condition) {
  executeSomething();
}

See

  • MISRA C:2004, 14.8 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
  • MISRA C:2004, 14.9 - An if (expression) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
  • MISRA C++:2008, 6-3-1 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
  • MISRA C++:2008, 6-4-1 - An if (condition) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
  • MISRA C:2012, 15.6 - The body of an iteration-statement or a selection-statement shall be a compound-statement
  • CERT, EXP19-C. - Use braces for the body of an if, for, or while statement
  • CERT, EXP52-J. - Use braces for the body of an if, for, or while statement

Add curly braces around the nested statement(s).
Open

        else
Severity: Critical
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by sonar-php

While not technically incorrect, the omission of curly braces can be misleading, and may lead to the introduction of errors during maintenance.

Noncompliant Code Example

if (condition)  // Noncompliant
  executeSomething();

Compliant Solution

if (condition) {
  executeSomething();
}

See

  • MISRA C:2004, 14.8 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
  • MISRA C:2004, 14.9 - An if (expression) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
  • MISRA C++:2008, 6-3-1 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
  • MISRA C++:2008, 6-4-1 - An if (condition) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
  • MISRA C:2012, 15.6 - The body of an iteration-statement or a selection-statement shall be a compound-statement
  • CERT, EXP19-C. - Use braces for the body of an if, for, or while statement
  • CERT, EXP52-J. - Use braces for the body of an if, for, or while statement

Add curly braces around the nested statement(s).
Open

        if ( 0 !== strpos( $class, '\\' ) )
Severity: Critical
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by sonar-php

While not technically incorrect, the omission of curly braces can be misleading, and may lead to the introduction of errors during maintenance.

Noncompliant Code Example

if (condition)  // Noncompliant
  executeSomething();

Compliant Solution

if (condition) {
  executeSomething();
}

See

  • MISRA C:2004, 14.8 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
  • MISRA C:2004, 14.9 - An if (expression) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
  • MISRA C++:2008, 6-3-1 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
  • MISRA C++:2008, 6-4-1 - An if (condition) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
  • MISRA C:2012, 15.6 - The body of an iteration-statement or a selection-statement shall be a compound-statement
  • CERT, EXP19-C. - Use braces for the body of an if, for, or while statement
  • CERT, EXP52-J. - Use braces for the body of an if, for, or while statement

Add curly braces around the nested statement(s).
Open

        else
Severity: Critical
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by sonar-php

While not technically incorrect, the omission of curly braces can be misleading, and may lead to the introduction of errors during maintenance.

Noncompliant Code Example

if (condition)  // Noncompliant
  executeSomething();

Compliant Solution

if (condition) {
  executeSomething();
}

See

  • MISRA C:2004, 14.8 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
  • MISRA C:2004, 14.9 - An if (expression) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
  • MISRA C++:2008, 6-3-1 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
  • MISRA C++:2008, 6-4-1 - An if (condition) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
  • MISRA C:2012, 15.6 - The body of an iteration-statement or a selection-statement shall be a compound-statement
  • CERT, EXP19-C. - Use braces for the body of an if, for, or while statement
  • CERT, EXP52-J. - Use braces for the body of an if, for, or while statement

Add curly braces around the nested statement(s).
Open

        if ( 0 !== strpos( $class, $this->base_ns ) )
Severity: Critical
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by sonar-php

While not technically incorrect, the omission of curly braces can be misleading, and may lead to the introduction of errors during maintenance.

Noncompliant Code Example

if (condition)  // Noncompliant
  executeSomething();

Compliant Solution

if (condition) {
  executeSomething();
}

See

  • MISRA C:2004, 14.8 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
  • MISRA C:2004, 14.9 - An if (expression) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
  • MISRA C++:2008, 6-3-1 - The statement forming the body of a switch, while, do ... while or for statement shall be a compound statement
  • MISRA C++:2008, 6-4-1 - An if (condition) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement
  • MISRA C:2012, 15.6 - The body of an iteration-statement or a selection-statement shall be a compound-statement
  • CERT, EXP19-C. - Use braces for the body of an if, for, or while statement
  • CERT, EXP52-J. - Use braces for the body of an if, for, or while statement

The parameter $file_loader is not named in camelCase.
Open

    function __construct( $base_dir, $base_ns = '', Loader\FileLoaderInterface $file_loader = NULL ) {

        // trim potential trailing slashes
        $this->base_dir = rtrim( (string) $base_dir, '\\/' );
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $file_loader is not named in camelCase.
Open

class NamespaceDirectoryMapper implements AutoLoadRuleInterface {

    /**
     * @type Loader\FileLoaderInterface
     */
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $base_dir is not named in camelCase.
Open

    function __construct( $base_dir, $base_ns = '', Loader\FileLoaderInterface $file_loader = NULL ) {

        // trim potential trailing slashes
        $this->base_dir = rtrim( (string) $base_dir, '\\/' );
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $base_ns is not named in camelCase.
Open

    function __construct( $base_dir, $base_ns = '', Loader\FileLoaderInterface $file_loader = NULL ) {

        // trim potential trailing slashes
        $this->base_dir = rtrim( (string) $base_dir, '\\/' );
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $base_dir is not named in camelCase.
Open

class NamespaceDirectoryMapper implements AutoLoadRuleInterface {

    /**
     * @type Loader\FileLoaderInterface
     */
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The property $base_ns is not named in camelCase.
Open

class NamespaceDirectoryMapper implements AutoLoadRuleInterface {

    /**
     * @type Loader\FileLoaderInterface
     */
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The variable $base_ns is not named in camelCase.
Open

    function __construct( $base_dir, $base_ns = '', Loader\FileLoaderInterface $file_loader = NULL ) {

        // trim potential trailing slashes
        $this->base_dir = rtrim( (string) $base_dir, '\\/' );
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $base_ns is not named in camelCase.
Open

    function __construct( $base_dir, $base_ns = '', Loader\FileLoaderInterface $file_loader = NULL ) {

        // trim potential trailing slashes
        $this->base_dir = rtrim( (string) $base_dir, '\\/' );
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $file_loader is not named in camelCase.
Open

    function __construct( $base_dir, $base_ns = '', Loader\FileLoaderInterface $file_loader = NULL ) {

        // trim potential trailing slashes
        $this->base_dir = rtrim( (string) $base_dir, '\\/' );
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $base_ns is not named in camelCase.
Open

    function __construct( $base_dir, $base_ns = '', Loader\FileLoaderInterface $file_loader = NULL ) {

        // trim potential trailing slashes
        $this->base_dir = rtrim( (string) $base_dir, '\\/' );
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $file_loader is not named in camelCase.
Open

    function __construct( $base_dir, $base_ns = '', Loader\FileLoaderInterface $file_loader = NULL ) {

        // trim potential trailing slashes
        $this->base_dir = rtrim( (string) $base_dir, '\\/' );
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $base_ns is not named in camelCase.
Open

    function __construct( $base_dir, $base_ns = '', Loader\FileLoaderInterface $file_loader = NULL ) {

        // trim potential trailing slashes
        $this->base_dir = rtrim( (string) $base_dir, '\\/' );
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $base_ns is not named in camelCase.
Open

    function __construct( $base_dir, $base_ns = '', Loader\FileLoaderInterface $file_loader = NULL ) {

        // trim potential trailing slashes
        $this->base_dir = rtrim( (string) $base_dir, '\\/' );
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $base_ns is not named in camelCase.
Open

    function __construct( $base_dir, $base_ns = '', Loader\FileLoaderInterface $file_loader = NULL ) {

        // trim potential trailing slashes
        $this->base_dir = rtrim( (string) $base_dir, '\\/' );
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $base_ns is not named in camelCase.
Open

    function __construct( $base_dir, $base_ns = '', Loader\FileLoaderInterface $file_loader = NULL ) {

        // trim potential trailing slashes
        $this->base_dir = rtrim( (string) $base_dir, '\\/' );
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $base_dir is not named in camelCase.
Open

    function __construct( $base_dir, $base_ns = '', Loader\FileLoaderInterface $file_loader = NULL ) {

        // trim potential trailing slashes
        $this->base_dir = rtrim( (string) $base_dir, '\\/' );
Severity: Minor
Found in lib/Requisite/Rule/NamespaceDirectoryMapper.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status