Sign upLogin

bykovme/nswallet

View on GitHub
Star

Showing 488 of 488 total issues

Method UpdateBackup has a Cognitive Complexity of 36 (exceeds 20 allowed). Consider refactoring.
Open

        public static void UpdateBackup(string pathFrom, string pathTo, bool isAuthorized = false)
        {
            try {
                bool errorState = false;
                var tempDBFolder = createTempDBFolder();
Severity: Minor
Found in src/NSWallet/NSWallet/Helpers/Backups/BackupManager.cs - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method LocalizationExceptionsLangCA has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        static bool LocalizationExceptionsLangCA(string trTag)
        {
            switch (trTag)
            {
                case "error":
Severity: Major
Found in src/NSWallet/NSWallet.UnitTests/Localization/LocalizationExceptionsLangCA.cs - About 2 hrs to fix

    Method LocalizationExceptionsLangES has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            static bool LocalizationExceptionsLangES(string trTag)
        {
            switch (trTag)
            {
                case "error":
    Severity: Major
    Found in src/NSWallet/NSWallet.UnitTests/Localization/LocalizationExceptionsLangES.cs - About 2 hrs to fix

      Method AddSettingButton has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              void AddSettingButton(StackLayout stack, string modelCommand, string menuName, string menuIcon, string chosenSelectionProperty = null, bool isPremium = false)
        {
            var itemSettingLayout = new StackLayout {
                VerticalOptions = LayoutOptions.CenterAndExpand,
                HorizontalOptions = LayoutOptions.Fill,
      Severity: Major
      Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs - About 2 hrs to fix

        Method onActionSend has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
        Open

                void onActionSend()
        {
            try {
                if (Intent.Action == Intent.ActionSend) {
                    var uriFromExtras = Intent.GetParcelableExtra(Intent.ExtraStream) as Android.Net.Uri;
        Severity: Minor
        Found in src/NSWallet/Droid/MainActivity.cs - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method Purchase has 68 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public static async Task<string> Purchase(PremiumStatus premiumStatus)
        {
            string productID = undetected_product_id;

            switch (premiumStatus)
        Severity: Major
        Found in src/NSWallet/NSWallet/Premium/PremiumManagement.cs - About 2 hrs to fix

          Method GetBottomMenu has 67 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  public StackLayout GetBottomMenu()
        {
            var mainPanel = new Grid {
                BackgroundColor = Theme.Current.AppHeaderBackground,
                HeightRequest = 100,
          Severity: Major
          Found in src/NSWallet/NSWallet/Views/MainScreen/Fields/ManageFieldViewBottomMenu.cs - About 2 hrs to fix

            Class FileService has 24 methods (exceeds 20 allowed). Consider refactoring.
            Open

                public class FileService : IFile
    {
        const string OLD_DROID_FILEPATH = "/app_nswallet/nswallet.dat";
        const string OLD_DROID_DIRPATH = "/app_nswallet";
            Severity: Minor
            Found in src/NSWallet/Droid/Interfaces/FileService.cs - About 2 hrs to fix

              Class FileService has 24 methods (exceeds 20 allowed). Consider refactoring.
              Open

                  public class FileService : IFile
    {
        const string DATABASE_IOS_FOLDER = @"/.nsw/nswallet";

        public string CheckOldFile()
              Severity: Minor
              Found in src/NSWallet/iOS/Interfaces/FileService.cs - About 2 hrs to fix

                Class FileService has 24 methods (exceeds 20 allowed). Consider refactoring.
                Open

                    public class FileService : IFile
    {
        const string DATABASE_IOS_FOLDER = @"/.nsw/nswallet";

        public string CheckOldFile()
                Severity: Minor
                Found in src/NSWallet/NSWallet.Mac/Interfaces/FileService.cs - About 2 hrs to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              {
                var first = Fields[index];
                var second = Fields[index + 1];
                Fields[index] = Fields[index + 1];
                Fields[index + 1] = first;
                  Severity: Major
                  Found in src/NSWallet/NSWallet/ViewModel/MainScreen/Fields/ReorderFieldViewModel.cs and 1 other location - About 2 hrs to fix
                  src/NSWallet/NSWallet/ViewModel/MainScreen/Fields/ReorderFieldViewModel.cs on lines 70..79

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 188.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              {
                var first = Fields[index];
                var second = Fields[index - 1];
                Fields[index] = Fields[index - 1];
                Fields[index - 1] = first;
                  Severity: Major
                  Found in src/NSWallet/NSWallet/ViewModel/MainScreen/Fields/ReorderFieldViewModel.cs and 1 other location - About 2 hrs to fix
                  src/NSWallet/NSWallet/ViewModel/MainScreen/Fields/ReorderFieldViewModel.cs on lines 85..94

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 188.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method LocalizationExceptionsLangDE has 64 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          static bool LocalizationExceptionsLangDE(string trTag)
        {
            switch (trTag)
            {
                case "version_label":
                  Severity: Major
                  Found in src/NSWallet/NSWallet.UnitTests/Localization/LocalizationExceptionsLangDE.cs - About 2 hrs to fix

                    Class IFile has 23 methods (exceeds 20 allowed). Consider refactoring.
                    Open

                        public interface IFile
    {
        string GetInternalFilePath();
        string GetInternalDirPath();
        string CheckOldFile();
                    Severity: Minor
                    Found in src/NSWallet/NSWallet/Interfaces/IFile.cs - About 2 hrs to fix

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                                  if (!string.IsNullOrEmpty(menuIcon)) {
                var itemImage = new CachedImage {
                    HeightRequest = Theme.Current.MenuIconHeight,
                    WidthRequest = Theme.Current.MenuIconWidth,
                    Source = ImageSource.FromStream(() => NSWRes.GetImage(menuIcon)),
                      Severity: Major
                      Found in src/NSWallet/NSWallet/Views/ExportImportScreen/ExportImportScreenView.cs and 2 other locations - About 2 hrs to fix
                      src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs on lines 440..452
                      src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs on lines 541..553

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 179.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                                  if (!string.IsNullOrEmpty(menuIcon)) {
                var itemImage = new CachedImage {
                    HeightRequest = Theme.Current.MenuIconHeight,
                    WidthRequest = Theme.Current.MenuIconWidth,
                    Source = ImageSource.FromStream(() => NSWRes.GetImage(menuIcon)),
                      Severity: Major
                      Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs and 2 other locations - About 2 hrs to fix
                      src/NSWallet/NSWallet/Views/ExportImportScreen/ExportImportScreenView.cs on lines 98..110
                      src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs on lines 541..553

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 179.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                                  if (!string.IsNullOrEmpty(menuIcon)) {
                var itemImage = new CachedImage {
                    HeightRequest = Theme.Current.MenuIconHeight,
                    WidthRequest = Theme.Current.MenuIconWidth,
                    Source = ImageSource.FromStream(() => NSWRes.GetImage(menuIcon)),
                      Severity: Major
                      Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs and 2 other locations - About 2 hrs to fix
                      src/NSWallet/NSWallet/Views/ExportImportScreen/ExportImportScreenView.cs on lines 98..110
                      src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs on lines 440..452

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 179.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Method AddViewToLayoutAutoHeightEnabled has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              void AddViewToLayoutAutoHeightEnabled(View view, int containerCount, int colNumber)
        {
            if (_desiredColumnCount > containerCount)
            {
                int diff = _desiredColumnCount - containerCount;
                      Severity: Major
                      Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListViewInternalCell.cs - About 2 hrs to fix

                        File FileService.cs has 267 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        using NSWallet.Droid;
using Xamarin.Forms;
using NSWallet.Shared;
using System.IO;
using System.IO.Compression;
                        Severity: Minor
                        Found in src/NSWallet/Droid/Interfaces/FileService.cs - About 2 hrs to fix

                          Method LocalizationExceptionsLangPL has 60 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  static bool LocalizationExceptionsLangPL(string trTag)
        {
            switch (trTag)
            {
                case "build_label":
                          Severity: Major
                          Found in src/NSWallet/NSWallet.UnitTests/Localization/LocalizationExceptionsLangPL.cs - About 2 hrs to fix
                            Severity
                            Category
                            Status
                            Source
                            Language