Sign upLogin

bykovme/nswallet

View on GitHub
Star

Showing 488 of 488 total issues

Method LocalizationExceptionsLangBG has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        static bool LocalizationExceptionsLangBG(string trTag)
        {
            switch (trTag)
            {
                case "airplane":
Severity: Minor
Found in src/NSWallet/NSWallet.UnitTests/Localization/LocalizationExceptionsLangBG.cs - About 1 hr to fix

    Method EnumerateItems has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            static void EnumerateItems(string id, bool recursive = false)
        {
            try {
                foreach (var item in BL.GetListByParentID(id, true)) {
                    if (!recursive)
    Severity: Minor
    Found in src/NSWallet/Droid/Interfaces/ExportService.cs - About 1 hr to fix

      Method EnumerateItems has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              static void EnumerateItems(string id, bool recursive = false)
        {
            try {
                foreach (var item in BL.GetListByParentID(id, true)) {
                    if (!recursive)
      Severity: Minor
      Found in src/NSWallet/NSWallet.Mac/Interfaces/ExportService.cs - About 1 hr to fix

        Method EnumerateItems has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                static void EnumerateItems(string id, bool recursive = false)
        {
            try {
                foreach (var item in BL.GetListByParentID(id, true)) {
                    if (!recursive)
        Severity: Minor
        Found in src/NSWallet/iOS/Interfaces/ExportService.cs - About 1 hr to fix

          Method CheckPreviousPremium has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
          Open

                  public static bool CheckPreviousPremium(Page page)
        {
            try
            {
                bool premiumRecovered = false;
          Severity: Minor
          Found in src/NSWallet/NSWallet/Premium/PremiumManagement.cs - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method CustomActionButton has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  static StackLayout CustomActionButton(string icon, string text, string command)
        {
            var iconLabel = new Label {
                HorizontalOptions = LayoutOptions.Center,
                HorizontalTextAlignment = TextAlignment.Center,
          Severity: Minor
          Found in src/NSWallet/NSWallet/Views/MainScreen/Fields/ManageFieldViewBottomMenu.cs - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (imageStream == null) {
                    if (item.Image != null) {
                        var customIcons = BL.GetIcons();
                        var customIcon = customIcons.Find(x => item.Image.Contains(x.IconID));
                        imageStream = customIcon != null ?
            Severity: Major
            Found in src/NSWallet/Droid/Interfaces/ExportService.cs and 1 other location - About 1 hr to fix
            src/NSWallet/iOS/Interfaces/ExportService.cs on lines 166..176

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 133.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (icon == null) {
                    if (item.Image != null) {
                        var customIcons = BL.GetIcons();
                        var customIcon = customIcons.Find(x => item.Image.Contains(x.IconID));
                        icon = customIcon != null ?
            Severity: Major
            Found in src/NSWallet/iOS/Interfaces/ExportService.cs and 1 other location - About 1 hr to fix
            src/NSWallet/Droid/Interfaces/ExportService.cs on lines 164..174

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 133.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method GetSettingsIcon has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    static Grid GetSettingsIcon(bool solid, string iconFont, string iconText, string popupCommandName = "")
        {
            var icon = new Label {
                TextColor = Theme.Current.MainTitleTextColor,
                FontSize = 40,
            Severity: Minor
            Found in src/NSWallet/NSWallet/Views/MainScreen/MainScreenViewHelpers.cs - About 1 hr to fix

              Method GetFieldTypeNameByShortName has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      public static string GetFieldTypeNameByShortName(string fieldTypeShortName)
        {
            switch (fieldTypeShortName) {
                case GConsts.FLDTYPE_ACNT:
                    return TR.Tr("ACNT");
              Severity: Minor
              Found in src/NSWallet/NSWallet.Shared/Business/BusinessLayer.cs - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        public void AutoBackupSelector()
        {
            DisplayActionSheet(TR.Tr("settings_autobackup"), TR.Cancel, null,
                               TR.Tr("autobackup_no_backup"),
                               TR.Tr("autobackup_weekly"),
                Severity: Major
                Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs and 1 other location - About 1 hr to fix
                src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs on lines 247..257

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 128.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        public void ExpiringPeriodSelector()
        {
            DisplayActionSheet(TR.Tr("settings_expiring_period"), TR.Cancel, null,
                               TR.Tr("settings_expiring_period_10"),
                               TR.Tr("settings_expiring_period_30"),
                Severity: Major
                Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs and 1 other location - About 1 hr to fix
                src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs on lines 259..269

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 128.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method TestCaseDecrypt has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        [Test]
        public void TestCaseDecrypt()
        {
            const string password = "Sun001!";
            const string expectedString = "nhh86c4uQKXu8rTjp4sL8rr2fxRMmnhWWhan8LiaVb4ZhTdF4RTlX4xcHYjwsfDu";
                Severity: Minor
                Found in src/NSWallet/NSWallet.UnitTests/SecurityFixture.cs - About 1 hr to fix

                  Method CheckPreviousPremium has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          public static bool CheckPreviousPremium(Page page)
        {
            try
            {
                bool premiumRecovered = false;
                  Severity: Minor
                  Found in src/NSWallet/NSWallet/Premium/PremiumManagement.cs - About 1 hr to fix

                    Method EnterPassword has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
                    Open

                            public void EnterPassword()
        {
            // FIXME: create correct model view separation, change password should go to model!!!
            var popup = new EntryPopup(TR.Tr("enter_new_password"), string.Empty, true);
            popup.PopupClosed += (o, closedArgs) => {
                    Severity: Minor
                    Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method AddListButton has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            static void AddListButton(StackLayout stack, string modelCommand, string menuName, string menuIcon)
        {
            var itemsImportLayout = new StackLayout {
                VerticalOptions = LayoutOptions.CenterAndExpand,
                HorizontalOptions = LayoutOptions.Fill,
                    Severity: Minor
                    Found in src/NSWallet/NSWallet/Views/ExportImportScreen/ExportImportScreenView.cs - About 1 hr to fix

                      Method ChangePassword has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              public bool ChangePassword(string newPassword)
        {
            try
            {
                nswdb.BeginTransaction();
                      Severity: Minor
                      Found in src/NSWallet/NSWallet.Shared/DataAccess/DataAccessLayer.cs - About 1 hr to fix

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                public static byte[] ReadFully(Stream input)
        {
            byte[] buffer = new byte[16 * 1024];
            using (MemoryStream ms = new MemoryStream()) {
                int read;
                        Severity: Major
                        Found in src/NSWallet/iOS/Interfaces/ExportService.cs and 1 other location - About 1 hr to fix
                        src/NSWallet/NSWallet.Mac/Interfaces/ExportService.cs on lines 127..137

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 121.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                public static byte[] ReadFully(Stream input)
        {
            byte[] buffer = new byte[16 * 1024];
            using (MemoryStream ms = new MemoryStream()) {
                int read;
                        Severity: Major
                        Found in src/NSWallet/NSWallet.Mac/Interfaces/ExportService.cs and 1 other location - About 1 hr to fix
                        src/NSWallet/iOS/Interfaces/ExportService.cs on lines 136..146

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 121.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Method wasSubscriptionPurchased has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                static async Task<bool> wasSubscriptionPurchased(string productID)
        {
            var billing = CrossInAppBilling.Current;

            try
                        Severity: Minor
                        Found in src/NSWallet/NSWallet/Premium/PremiumManagement.cs - About 1 hr to fix
                          Severity
                          Category
                          Status
                          Source
                          Language