Sign upLogin

bykovme/nswallet

View on GitHub
Star
src/NSWallet/Droid/Interfaces/ExportService.cs

Summary

Maintainability
F
3 days
Test Coverage

Method GeneratePDF has 107 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public void GeneratePDF()
        {
            CleanCache();

            // Get NSWItems
Severity: Major
Found in src/NSWallet/Droid/Interfaces/ExportService.cs - About 4 hrs to fix

    Method GeneratePDF has a Cognitive Complexity of 37 (exceeds 20 allowed). Consider refactoring.
    Open

            public void GeneratePDF()
        {
            CleanCache();

            // Get NSWItems
    Severity: Minor
    Found in src/NSWallet/Droid/Interfaces/ExportService.cs - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method EnumerateItems has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            static void EnumerateItems(string id, bool recursive = false)
        {
            try {
                foreach (var item in BL.GetListByParentID(id, true)) {
                    if (!recursive)
    Severity: Minor
    Found in src/NSWallet/Droid/Interfaces/ExportService.cs - About 1 hr to fix

      Method EnumerateItems has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
      Open

              static void EnumerateItems(string id, bool recursive = false)
        {
            try {
                foreach (var item in BL.GetListByParentID(id, true)) {
                    if (!recursive)
      Severity: Minor
      Found in src/NSWallet/Droid/Interfaces/ExportService.cs - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method GenerateTXT has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public void GenerateTXT()
        {
            CleanCache();

            // Get NSWItems
      Severity: Minor
      Found in src/NSWallet/Droid/Interfaces/ExportService.cs - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                                    if (counter == 20) {
                                PDFDoc.FinishPage(page);
                                xPosMatrix = 20;
                                yPosMatrix = 10;
                                xPosText = 270;
        Severity: Major
        Found in src/NSWallet/Droid/Interfaces/ExportService.cs - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                          if (TR.Tr(field.FieldType) == field.FieldType) {
                                    fieldType = field.Label;
                                } else {
                                    fieldType = TR.Tr(field.FieldType);
                                }
          Severity: Major
          Found in src/NSWallet/Droid/Interfaces/ExportService.cs - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    public void GenerateTXT()
        {
            CleanCache();

            // Get NSWItems
            Severity: Major
            Found in src/NSWallet/Droid/Interfaces/ExportService.cs and 1 other location - About 5 hrs to fix
            src/NSWallet/NSWallet.Mac/Interfaces/ExportService.cs on lines 90..125

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 356.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    static void EnumerateItems(string id, bool recursive = false)
        {
            try {
                foreach (var item in BL.GetListByParentID(id, true)) {
                    if (!recursive)
            Severity: Major
            Found in src/NSWallet/Droid/Interfaces/ExportService.cs and 2 other locations - About 5 hrs to fix
            src/NSWallet/NSWallet.Mac/Interfaces/ExportService.cs on lines 37..88
            src/NSWallet/iOS/Interfaces/ExportService.cs on lines 46..96

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 352.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    public static string[] WrapString(string text, int max)
        {
            var charCount = 0;
            var lines = text.Split(new[] { ' ' }, StringSplitOptions.RemoveEmptyEntries);
            return lines.GroupBy(w => (charCount += (((charCount % max) + w.Length + 1 >= max)
            Severity: Major
            Found in src/NSWallet/Droid/Interfaces/ExportService.cs and 2 other locations - About 2 hrs to fix
            src/NSWallet/NSWallet.Mac/Interfaces/ExportService.cs on lines 201..209
            src/NSWallet/iOS/Interfaces/ExportService.cs on lines 225..233

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 162.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (imageStream == null) {
                    if (item.Image != null) {
                        var customIcons = BL.GetIcons();
                        var customIcon = customIcons.Find(x => item.Image.Contains(x.IconID));
                        imageStream = customIcon != null ?
            Severity: Major
            Found in src/NSWallet/Droid/Interfaces/ExportService.cs and 1 other location - About 1 hr to fix
            src/NSWallet/iOS/Interfaces/ExportService.cs on lines 166..176

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 133.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    static void CleanCache()
        {
            var backupPath = PlatformSpecific.GetBackupPath();
            var directories = Directory.EnumerateDirectories(backupPath);
            foreach(var directory in directories) {
            Severity: Major
            Found in src/NSWallet/Droid/Interfaces/ExportService.cs and 2 other locations - About 45 mins to fix
            src/NSWallet/NSWallet.Mac/Interfaces/ExportService.cs on lines 26..35
            src/NSWallet/iOS/Interfaces/ExportService.cs on lines 35..44

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 76.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status