Class BL
has 40 methods (exceeds 20 allowed). Consider refactoring. Open
public static partial class BL
{
static string lang;
static string lastCurrentID;
public static string CurrentFieldID { get; private set; }
File BusinessLayer.cs
has 381 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using NSWallet.Shared.Helpers.Logs.AppLog;
Method GetFieldTypeNameByShortName
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static string GetFieldTypeNameByShortName(string fieldTypeShortName)
{
switch (fieldTypeShortName) {
case GConsts.FLDTYPE_ACNT:
return TR.Tr("ACNT");
Method GetCurrentPath
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static string GetCurrentPath()
{
if (CurrentItemID == GConsts.EXPIRING_SOON_ID)
{
return "/" + TR.Tr("expiringsoon_folder") + "/";
Method CreateSampleItems
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static void CreateSampleItems()
{
var dal = DataAccessLayer.GetInstance();
// Banking
Method UpdateIcon
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public static bool UpdateIcon(string iconID, string name, byte[] blob = null, int groupID = -1, int isCircle = -1)
Method ResetData
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public static void ResetData(bool resetItems, bool resetFields, bool resetLabels, bool icons = false, bool groups = false)
Avoid too many return
statements within this method. Open
return bufferedPath[CurrentItemID];
Avoid too many return
statements within this method. Open
return bufferedPath[CurrentItemID];
Avoid too many return
statements within this method. Open
return "/" + TR.Tr("mostlyviewed_folder") + "/";
Avoid too many return
statements within this method. Open
return "/" + TR.Tr("mostlyviewed_folder") + "/" + GetCurrentItem().Name + "/";
Similar blocks of code found in 2 locations. Consider refactoring. Open
public static bool UpdateGroup(int groupID, string name)
{
var dal = DataAccessLayer.GetInstance();
var res = dal.UpdateGroup(groupID, name);
ResetData(false, false, false, false, true);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 77.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public static bool InsertGroup(int groupID, string name)
{
var dal = DataAccessLayer.GetInstance();
var result = dal.InsertGroup(groupID, name);
ResetData(false, false, false, false, true);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 77.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76