Sign upLogin

bykovme/nswallet

View on GitHub
Star
src/NSWallet/NSWallet.Shared/Security/SecurityStandard.cs

Summary

Maintainability
C
1 day
Test Coverage

Method DecryptStringAES has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public static string DecryptStringAES(byte[] encryptedData, string password, int reEncryptionCount, string hash, out bool ok)
        {
            ok = false;

            var key = prepareKey(password, hash, reEncryptionCount);
Severity: Minor
Found in src/NSWallet/NSWallet.Shared/Security/SecurityStandard.cs - About 1 hr to fix

    Method EncryptStringAES has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public static byte[] EncryptStringAES(string plainText, string password, int reEncryptionCount, string hash, out bool ok)
        {
            ok = false;
            byte[] bytes;
    Severity: Minor
    Found in src/NSWallet/NSWallet.Shared/Security/SecurityStandard.cs - About 1 hr to fix

      Method GenerateCleverPassword has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public static string GenerateCleverPassword(string passwordPattern)
        {
            Random rand = new Random(DateTime.Now.Millisecond);

            var generatedPassword = "";
      Severity: Minor
      Found in src/NSWallet/NSWallet.Shared/Security/SecurityStandard.cs - About 1 hr to fix

        Method DecryptStringAES has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                public static string DecryptStringAES(byte[] encryptedData, string password, int reEncryptionCount, string hash, out bool ok)
        Severity: Minor
        Found in src/NSWallet/NSWallet.Shared/Security/SecurityStandard.cs - About 35 mins to fix

          Method EncryptStringAES has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  public static byte[] EncryptStringAES(string plainText, string password, int reEncryptionCount, string hash, out bool ok)
          Severity: Minor
          Found in src/NSWallet/NSWallet.Shared/Security/SecurityStandard.cs - About 35 mins to fix

            Method GeneratePassword has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    public static string GeneratePassword(bool lowerCase, bool upperCase, bool digits, bool special, int len)
            Severity: Minor
            Found in src/NSWallet/NSWallet.Shared/Security/SecurityStandard.cs - About 35 mins to fix

              FIXME found
              Open

                          // FIXME: remove as soon as possible
              Severity: Minor
              Found in src/NSWallet/NSWallet.Shared/Security/SecurityStandard.cs by fixme

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          try
            {
                using (MemoryStream ms = new MemoryStream())
                {
                    using (AesManaged myAes = new AesManaged())
              Severity: Major
              Found in src/NSWallet/NSWallet.Shared/Security/SecurityStandard.cs and 1 other location - About 4 hrs to fix
              src/NSWallet/NSWallet.Shared/Security/SecurityiOSWorkAround.cs on lines 19..55

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 325.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status