bykovme/nswallet

View on GitHub
src/NSWallet/NSWallet/Controls/FlowListView/FlowListView.cs

Summary

Maintainability
D
1 day
Test Coverage

File FlowListView.cs has 383 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using Xamarin.Forms;
using System.Collections;
using System.Collections.Generic;
using System.Collections.ObjectModel;
Severity: Minor
Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListView.cs - About 5 hrs to fix

    Method ReloadGroupedContainerList has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            private void ReloadGroupedContainerList()
            {
                var colCount = DesiredColumnCount;
                var flowGroupsList = new List<FlowGroup>(FlowItemsSource.Count);
                var groupDisplayPropertyName = (FlowGroupDisplayBinding as Binding)?.Path;
    Severity: Minor
    Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListView.cs - About 1 hr to fix

      Method ReloadGroupedContainerList has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
      Open

              private void ReloadGroupedContainerList()
              {
                  var colCount = DesiredColumnCount;
                  var flowGroupsList = new List<FlowGroup>(FlowItemsSource.Count);
                  var groupDisplayPropertyName = (FlowGroupDisplayBinding as Binding)?.Path;
      Severity: Minor
      Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListView.cs - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              private void FlowListViewItemDisappearing(object sender, ItemVisibilityEventArgs e)
              {
                  var container = e.Item as IEnumerable;
                  if (container != null)
                  {
      Severity: Major
      Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListView.cs and 1 other location - About 1 hr to fix
      src/NSWallet/NSWallet/Controls/FlowListView/FlowListView.cs on lines 460..479

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              private void FlowListViewItemAppearing (object sender, ItemVisibilityEventArgs e)
              {
                  var container = e.Item as IEnumerable;
                  if (container != null)
                  {
      Severity: Major
      Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListView.cs and 1 other location - About 1 hr to fix
      src/NSWallet/NSWallet/Controls/FlowListView/FlowListView.cs on lines 481..500

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 137.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  for (int i = 0; i < FlowItemsSource.Count; i++)
                  {
                      if (i % colCount == 0)
                      {
                          position++;
      Severity: Major
      Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListView.cs and 1 other location - About 1 hr to fix
      src/NSWallet/NSWallet/Controls/FlowListView/FlowListView.cs on lines 565..578

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 109.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              for (int i = 0; i < gr.Count; i++)
                              {
                                  if (i % colCount == 0)
                                  {
                                      position++;
      Severity: Major
      Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListView.cs and 1 other location - About 1 hr to fix
      src/NSWallet/NSWallet/Controls/FlowListView/FlowListView.cs on lines 512..527

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 109.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              public BindingBase FlowGroupShortNameBinding
              {
                  get { return _flowGroupShortNameBinding; }
                  set
                  {
      Severity: Minor
      Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListView.cs and 1 other location - About 40 mins to fix
      src/NSWallet/NSWallet/Controls/FlowListView/FlowListView.cs on lines 93..110

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              public BindingBase FlowGroupDisplayBinding
              {
                  get { return _flowGroupDisplayBinding; }
                  set
                  {
      Severity: Minor
      Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListView.cs and 1 other location - About 40 mins to fix
      src/NSWallet/NSWallet/Controls/FlowListView/FlowListView.cs on lines 118..135

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status