Sign upLogin

bykovme/nswallet

View on GitHub
Star
src/NSWallet/NSWallet/Controls/FlowListView/FlowListViewInternalCell.cs

Summary

Maintainability
F
4 days
Test Coverage

Method OnBindingContextChanged has a Cognitive Complexity of 57 (exceeds 20 allowed). Consider refactoring.
Open

        protected override void OnBindingContextChanged()
        {
            base.OnBindingContextChanged();

            var container = BindingContext as IList;
Severity: Minor
Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListViewInternalCell.cs - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File FlowListViewInternalCell.cs has 386 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using Xamarin.Forms;
using System.Collections.Generic;
using System.Collections;
using System.Threading.Tasks;
Severity: Minor
Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListViewInternalCell.cs - About 5 hrs to fix

    Method AddViewToLayoutAutoHeightDisabled has a Cognitive Complexity of 43 (exceeds 20 allowed). Consider refactoring.
    Open

            void AddViewToLayoutAutoHeightDisabled(View view, int containerCount, int colNumber)
        {
            double desiredColumnWidth = 1d / _desiredColumnCount;
            Rectangle bounds = Rectangle.Zero;
    Severity: Minor
    Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListViewInternalCell.cs - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method AddViewToLayoutAutoHeightDisabled has 101 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            void AddViewToLayoutAutoHeightDisabled(View view, int containerCount, int colNumber)
        {
            double desiredColumnWidth = 1d / _desiredColumnCount;
            Rectangle bounds = Rectangle.Zero;
    Severity: Major
    Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListViewInternalCell.cs - About 4 hrs to fix

      Method OnBindingContextChanged has 93 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              protected override void OnBindingContextChanged()
        {
            base.OnBindingContextChanged();

            var container = BindingContext as IList;
      Severity: Major
      Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListViewInternalCell.cs - About 3 hrs to fix

        Method AddViewToLayoutAutoHeightEnabled has 61 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                void AddViewToLayoutAutoHeightEnabled(View view, int containerCount, int colNumber)
        {
            if (_desiredColumnCount > containerCount)
            {
                int diff = _desiredColumnCount - containerCount;
        Severity: Major
        Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListViewInternalCell.cs - About 2 hrs to fix

          Method ExecuteTapGestureRecognizer has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  async Task ExecuteTapGestureRecognizer(View view)
        {
            var flowCell = view as IFlowViewCell;
            if (flowCell != null)
            {
          Severity: Minor
          Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListViewInternalCell.cs - About 1 hr to fix

            Method GetDataTemplates has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    private IList<DataTemplate> GetDataTemplates(IList container)
        {
            List<DataTemplate> templates = new List<DataTemplate>();

            var flowTemplateSelector = _flowColumnTemplate as FlowTemplateSelector;
            Severity: Minor
            Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListViewInternalCell.cs - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  for (int i = 0; i < containerCount; i++)
                    {
                        var view = (View)templates[i].CreateContent();

                        view.GestureRecognizers.Add(new TapGestureRecognizer()
              Severity: Major
              Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListViewInternalCell.cs and 1 other location - About 1 hr to fix
              src/NSWallet/NSWallet/Controls/FlowListView/FlowListViewInternalCell.cs on lines 421..438

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 144.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  for (int i = 0; i < containerCount; i++)
                    {
                        var view = (View)templates[i].CreateContent();

                        view.GestureRecognizers.Add(new TapGestureRecognizer()
              Severity: Major
              Found in src/NSWallet/NSWallet/Controls/FlowListView/FlowListViewInternalCell.cs and 1 other location - About 1 hr to fix
              src/NSWallet/NSWallet/Controls/FlowListView/FlowListViewInternalCell.cs on lines 397..414

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 144.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status