Sign upLogin

bykovme/nswallet

View on GitHub
Star
src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs

Summary

Maintainability
F
6 days
Test Coverage

File MainScreenViewModel.cs has 1266 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using System.Collections.Generic;
using System.ComponentModel;
using NSWallet.Shared;
using Xamarin.Forms;
Severity: Major
Found in src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs - About 3 days to fix

    Class MainScreenViewModel has 43 methods (exceeds 20 allowed). Consider refactoring.
    Open

        public class MainScreenViewModel : INotifyPropertyChanged
    {
        public event PropertyChangedEventHandler PropertyChanged;
    Severity: Minor
    Found in src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs - About 5 hrs to fix

      Method ExecuteSelectedItemCommand has 88 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              void ExecuteSelectedItemCommand(object obj)
        {
            IsEditItemPanel = false;
            IsEditFolderPanel = false;
            if (obj == null) return;
      Severity: Major
      Found in src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs - About 3 hrs to fix

        Method ExecuteMenuTappedCommand has 86 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                void ExecuteMenuTappedCommand(object obj)
        {
            if (obj != null) {
                var popupItem = (PopupItem)obj;
                switch (popupItem.Action) {
        Severity: Major
        Found in src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs - About 3 hrs to fix

          Method ExecuteSelectedItemCommand has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
          Open

                  void ExecuteSelectedItemCommand(object obj)
        {
            IsEditItemPanel = false;
            IsEditFolderPanel = false;
            if (obj == null) return;
          Severity: Minor
          Found in src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method ExecuteBackCommand has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  void ExecuteBackCommand()
        {
            IsEditItemPanel = false;
            IsEditFolderPanel = false;
            ItemToScrollTo = BL.CurrentItemID;
          Severity: Minor
          Found in src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs - About 1 hr to fix

            Method ExecuteSearchLaunchCommand has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    protected void ExecuteSearchLaunchCommand()
        {
            if (!IsLocalClipboardActivated) {

                SearchEntryShowHideCommandCallback.Invoke(false);
            Severity: Minor
            Found in src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs - About 1 hr to fix

              Method setItemsList has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      void setItemsList(List<NSWItem> itemsList, bool setHeader = true)
        {
            var itemsStorage = new List<NSWFormsItemModel>();
            if (itemsList != null) {
                if (itemsList.Count == 0) {
              Severity: Minor
              Found in src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs - About 1 hr to fix

                TODO found
                Open

                                        // TODO:
                Severity: Minor
                Found in src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs by fixme

                FIXME found
                Open

                                //    // FIXME: the same code as in NSWFormsItemModel.cs: 214, unify!
                Severity: Minor
                Found in src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs by fixme

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        void ExecuteMoveCommand()
        {
            if (currentItemType != ItemTypes.Item) {
                if (!string.IsNullOrEmpty(pasteItemID)) {
                    BL.MoveItem(pasteItemID);
                Severity: Major
                Found in src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs and 1 other location - About 1 hr to fix
                src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs on lines 1406..1423

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 138.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        void ExecuteCopyCommand()
        {
            if (currentItemType != ItemTypes.Item) {
                if (!string.IsNullOrEmpty(pasteItemID)) {
                    BL.CopyItem(pasteItemID);
                Severity: Major
                Found in src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs and 1 other location - About 1 hr to fix
                src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs on lines 1432..1449

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 138.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                        Device.BeginInvokeOnMainThread(() => {
                            Application.Current.MainPage.DisplayAlert(TR.Tr("attention"), TR.Tr("main_paste_field_description"), TR.OK);
                            AddButtonVisible = false;
                            IsCopyEnabled = true;
                            IsMoveEnabled = false;
                Severity: Major
                Found in src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs and 1 other location - About 1 hr to fix
                src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs on lines 1277..1283

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            Device.BeginInvokeOnMainThread(() => {
                Application.Current.MainPage.DisplayAlert(TR.Tr("attention"), TR.Tr("main_paste_field_description"), TR.OK);
                AddButtonVisible = false;
                IsCopyEnabled = true;
                IsMoveEnabled = false;
                Severity: Major
                Found in src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs and 1 other location - About 1 hr to fix
                src/NSWallet/NSWallet/ViewModel/MainScreen/MainScreenViewModel.cs on lines 1308..1314

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status