bykovme/nswallet

View on GitHub
src/NSWallet/NSWallet/Views/LabelScreen/LabelScreenView.cs

Summary

Maintainability
C
1 day
Test Coverage

Method CreateLabel has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public void CreateLabel()
        {
            var popup = new EntryPopup(TR.Tr("create_label"), null, false);
            popup.PopupClosed += (o, closedArgs) => {
                if (closedArgs.OkClicked) {
Severity: Minor
Found in src/NSWallet/NSWallet/Views/LabelScreen/LabelScreenView.cs - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                    return GConsts.VALUETYPE_PHON;
    Severity: Major
    Found in src/NSWallet/NSWallet/Views/LabelScreen/LabelScreenView.cs - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return GConsts.VALUETYPE_TEXT;
      Severity: Major
      Found in src/NSWallet/NSWallet/Views/LabelScreen/LabelScreenView.cs - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return GConsts.VALUETYPE_MAIL;
        Severity: Major
        Found in src/NSWallet/NSWallet/Views/LabelScreen/LabelScreenView.cs - About 30 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  static string ValueTypeByTranslation(string translation)
                  {
                      if (translation == TR.Tr(GConsts.VALUETYPE_DATE))
                          return GConsts.VALUETYPE_DATE;
                      if (translation == TR.Tr(GConsts.VALUETYPE_TIME))
          Severity: Major
          Found in src/NSWallet/NSWallet/Views/LabelScreen/LabelScreenView.cs and 1 other location - About 2 hrs to fix
          src/NSWallet/NSWallet/Helpers/Labels/LabelsManagement.cs on lines 28..43

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 166.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                                  var labels = new string[]
                                  {
                                      TR.Tr(GConsts.VALUETYPE_TEXT),
                                      TR.Tr(GConsts.VALUETYPE_DATE),
                                      TR.Tr(GConsts.VALUETYPE_TIME),
          Severity: Major
          Found in src/NSWallet/NSWallet/Views/LabelScreen/LabelScreenView.cs and 1 other location - About 1 hr to fix
          src/NSWallet/NSWallet/Helpers/Labels/LabelsManagement.cs on lines 15..24

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 109.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  public void SystemMenuSelector()
                  {
                      DisplayActionSheet("Choose action", "Cancel", null, "Change label name", "Change icon").ContinueWith(t => {
                          if (pageVM.SystemMenuSelectedCommand.CanExecute(t.Result)) {
                              pageVM.SystemMenuSelectedCommand.Execute(t.Result);
          Severity: Minor
          Found in src/NSWallet/NSWallet/Views/LabelScreen/LabelScreenView.cs and 1 other location - About 50 mins to fix
          src/NSWallet/NSWallet/Views/LabelScreen/LabelScreenView.cs on lines 209..216

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  public void ContextMenuSelector()
                  {
                      DisplayActionSheet("Choose action", "Cancel", null, "Labels' filtration", "Reset labels").ContinueWith(t => {
                          if (pageVM.ContextSelectedCommand.CanExecute(t.Result)) {
                              pageVM.ContextSelectedCommand.Execute(t.Result);
          Severity: Minor
          Found in src/NSWallet/NSWallet/Views/LabelScreen/LabelScreenView.cs and 1 other location - About 50 mins to fix
          src/NSWallet/NSWallet/Views/LabelScreen/LabelScreenView.cs on lines 227..234

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status