Sign upLogin

bykovme/nswallet

View on GitHub
Star
src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs

Summary

Maintainability
F
4 days
Test Coverage

File SettingsScreenView.cs has 505 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System.Collections.Generic;
using FFImageLoading.Forms;
using NSWallet.Controls.EntryPopup;
using NSWallet.Helpers;
using NSWallet.NetStandard;
Severity: Major
Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs - About 1 day to fix

    Method AddCheckbox has 83 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            void AddCheckbox(StackLayout settingsLayout, string settingName, string checkedProperty, string menuIcon, string toggleCommand, string chosenSelectionProperty = null, bool isPremium = false)
        {
            var checkboxLayout = new StackLayout {
                VerticalOptions = LayoutOptions.CenterAndExpand,
                HorizontalOptions = LayoutOptions.Fill,
    Severity: Major
    Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs - About 3 hrs to fix

      Method AddSettingButton has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              void AddSettingButton(StackLayout stack, string modelCommand, string menuName, string menuIcon, string chosenSelectionProperty = null, bool isPremium = false)
        {
            var itemSettingLayout = new StackLayout {
                VerticalOptions = LayoutOptions.CenterAndExpand,
                HorizontalOptions = LayoutOptions.Fill,
      Severity: Major
      Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs - About 2 hrs to fix

        Method EnterPassword has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
        Open

                public void EnterPassword()
        {
            // FIXME: create correct model view separation, change password should go to model!!!
            var popup = new EntryPopup(TR.Tr("enter_new_password"), string.Empty, true);
            popup.PopupClosed += (o, closedArgs) => {
        Severity: Minor
        Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method EnterPassword has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public void EnterPassword()
        {
            // FIXME: create correct model view separation, change password should go to model!!!
            var popup = new EntryPopup(TR.Tr("enter_new_password"), string.Empty, true);
            popup.PopupClosed += (o, closedArgs) => {
        Severity: Minor
        Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs - About 1 hr to fix

          Method LanguageSelector has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  public void LanguageSelector()
        {
            var langs = Lang.availableLangs();
            var strLangs = new List<string>();
            var systemLang = "";
          Severity: Minor
          Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs - About 1 hr to fix

            Method ThemeSelector has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    public void ThemeSelector(bool premium)
        {
            string[] buttons = null;
            if (premium) {
                buttons = new string[]
            Severity: Minor
            Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs - About 1 hr to fix

              Method AddCheckbox has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      void AddCheckbox(StackLayout settingsLayout, string settingName, string checkedProperty, string menuIcon, string toggleCommand, string chosenSelectionProperty = null, bool isPremium = false)
              Severity: Major
              Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs - About 50 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                                    if (Settings.UsedFingerprintBefore) {
                                        Settings.FingerprintCount = 21;
                                        Settings.RememberedPassword = closedArgs.Text;
                                    }
                Severity: Major
                Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs - About 45 mins to fix

                  Method AddSettingButton has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          void AddSettingButton(StackLayout stack, string modelCommand, string menuName, string menuIcon, string chosenSelectionProperty = null, bool isPremium = false)
                  Severity: Minor
                  Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs - About 45 mins to fix

                    Method LanguageSelector has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
                    Open

                            public void LanguageSelector()
        {
            var langs = Lang.availableLangs();
            var strLangs = new List<string>();
            var systemLang = "";
                    Severity: Minor
                    Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    FIXME found
                    Open

                                // FIXME: create correct model view separation, change password should go to model!!!
                    Severity: Minor
                    Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs by fixme

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                                if (!string.IsNullOrEmpty(menuIcon)) {
                var itemImage = new CachedImage {
                    HeightRequest = Theme.Current.MenuIconHeight,
                    WidthRequest = Theme.Current.MenuIconWidth,
                    Source = ImageSource.FromStream(() => NSWRes.GetImage(menuIcon)),
                    Severity: Major
                    Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs and 2 other locations - About 2 hrs to fix
                    src/NSWallet/NSWallet/Views/ExportImportScreen/ExportImportScreenView.cs on lines 98..110
                    src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs on lines 541..553

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 179.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                                if (!string.IsNullOrEmpty(menuIcon)) {
                var itemImage = new CachedImage {
                    HeightRequest = Theme.Current.MenuIconHeight,
                    WidthRequest = Theme.Current.MenuIconWidth,
                    Source = ImageSource.FromStream(() => NSWRes.GetImage(menuIcon)),
                    Severity: Major
                    Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs and 2 other locations - About 2 hrs to fix
                    src/NSWallet/NSWallet/Views/ExportImportScreen/ExportImportScreenView.cs on lines 98..110
                    src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs on lines 440..452

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 179.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            public void AutoBackupSelector()
        {
            DisplayActionSheet(TR.Tr("settings_autobackup"), TR.Cancel, null,
                               TR.Tr("autobackup_no_backup"),
                               TR.Tr("autobackup_weekly"),
                    Severity: Major
                    Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs and 1 other location - About 1 hr to fix
                    src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs on lines 247..257

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 128.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            public void ExpiringPeriodSelector()
        {
            DisplayActionSheet(TR.Tr("settings_expiring_period"), TR.Cancel, null,
                               TR.Tr("settings_expiring_period_10"),
                               TR.Tr("settings_expiring_period_30"),
                    Severity: Major
                    Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs and 1 other location - About 1 hr to fix
                    src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs on lines 259..269

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 128.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    {
                    var premiumImage = new CachedImage
                    {
                        HeightRequest = 30,
                        HorizontalOptions = LayoutOptions.EndAndExpand,
                    Severity: Major
                    Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs and 1 other location - About 1 hr to fix
                    src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs on lines 596..610

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 114.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    {
                    var premiumImage = new CachedImage
                    {
                        HeightRequest = 30,
                        HorizontalOptions = LayoutOptions.EndAndExpand,
                    Severity: Major
                    Found in src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs and 1 other location - About 1 hr to fix
                    src/NSWallet/NSWallet/Views/SettingsScreen/SettingsScreenView.cs on lines 499..513

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 114.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status