Sign upLogin

bykovme/nswallet

View on GitHub
Star
src/NSWallet/iOS/Interfaces/ExportService.cs

Summary

Maintainability
D
2 days
Test Coverage

Method EnumerateItems has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        static void EnumerateItems(string id, bool recursive = false)
        {
            try {
                foreach (var item in BL.GetListByParentID(id, true)) {
                    if (!recursive)
Severity: Minor
Found in src/NSWallet/iOS/Interfaces/ExportService.cs - About 1 hr to fix

    Method getHTMLFromItems has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            static string getHTMLFromItems()
        {
            string html = null;
            foreach (var item in ExportedItems) {
                string marginLeft = null;
    Severity: Minor
    Found in src/NSWallet/iOS/Interfaces/ExportService.cs - About 1 hr to fix

      Method GenerateTXT has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public void GenerateTXT()
        {
            CleanCache();

            // Get NSWItems
      Severity: Minor
      Found in src/NSWallet/iOS/Interfaces/ExportService.cs - About 1 hr to fix

        Method EnumerateItems has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
        Open

                static void EnumerateItems(string id, bool recursive = false)
        {
            try {
                foreach (var item in BL.GetListByParentID(id, true)) {
                    if (!recursive)
        Severity: Minor
        Found in src/NSWallet/iOS/Interfaces/ExportService.cs - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                                        if(TR.Tr(field.FieldType) == field.FieldType) {
                                    fieldType = field.Label;
                                } else {
                                    fieldType = TR.Tr(field.FieldType);
                                }
        Severity: Major
        Found in src/NSWallet/iOS/Interfaces/ExportService.cs - About 45 mins to fix

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                  static void EnumerateItems(string id, bool recursive = false)
        {
            try {
                foreach (var item in BL.GetListByParentID(id, true)) {
                    if (!recursive)
          Severity: Major
          Found in src/NSWallet/iOS/Interfaces/ExportService.cs and 2 other locations - About 5 hrs to fix
          src/NSWallet/Droid/Interfaces/ExportService.cs on lines 36..87
          src/NSWallet/NSWallet.Mac/Interfaces/ExportService.cs on lines 37..88

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 352.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                  public static string[] WrapString(string text, int max)
        {
            var charCount = 0;
            var lines = text.Split(new[] { ' ' }, StringSplitOptions.RemoveEmptyEntries);
            return lines.GroupBy(w => (charCount += (((charCount % max) + w.Length + 1 >= max)
          Severity: Major
          Found in src/NSWallet/iOS/Interfaces/ExportService.cs and 2 other locations - About 2 hrs to fix
          src/NSWallet/Droid/Interfaces/ExportService.cs on lines 276..284
          src/NSWallet/NSWallet.Mac/Interfaces/ExportService.cs on lines 201..209

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 162.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (icon == null) {
                    if (item.Image != null) {
                        var customIcons = BL.GetIcons();
                        var customIcon = customIcons.Find(x => item.Image.Contains(x.IconID));
                        icon = customIcon != null ?
          Severity: Major
          Found in src/NSWallet/iOS/Interfaces/ExportService.cs and 1 other location - About 1 hr to fix
          src/NSWallet/Droid/Interfaces/ExportService.cs on lines 164..174

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 133.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  public static byte[] ReadFully(Stream input)
        {
            byte[] buffer = new byte[16 * 1024];
            using (MemoryStream ms = new MemoryStream()) {
                int read;
          Severity: Major
          Found in src/NSWallet/iOS/Interfaces/ExportService.cs and 1 other location - About 1 hr to fix
          src/NSWallet/NSWallet.Mac/Interfaces/ExportService.cs on lines 127..137

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 121.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                  static void CleanCache()
        {
            var backupPath = PlatformSpecific.GetBackupPath();
            var directories = Directory.EnumerateDirectories(backupPath);
            foreach (var directory in directories) {
          Severity: Major
          Found in src/NSWallet/iOS/Interfaces/ExportService.cs and 2 other locations - About 45 mins to fix
          src/NSWallet/Droid/Interfaces/ExportService.cs on lines 25..34
          src/NSWallet/NSWallet.Mac/Interfaces/ExportService.cs on lines 26..35

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 76.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          Device.BeginInvokeOnMainThread(() => {
                    checkSharing();
                    sharing.ShareFile(exportPath, TR.Tr("app_name"), "application/pdf", TR.Tr("export_data"), null);
                });
          Severity: Minor
          Found in src/NSWallet/iOS/Interfaces/ExportService.cs and 1 other location - About 40 mins to fix
          src/NSWallet/iOS/Interfaces/ExportService.cs on lines 130..133

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      Device.BeginInvokeOnMainThread(() => {
                checkSharing();
                sharing.ShareFile(exportPath, TR.Tr("app_name"), "text/*", TR.Tr("export_data"), null);
            });
          Severity: Minor
          Found in src/NSWallet/iOS/Interfaces/ExportService.cs and 1 other location - About 40 mins to fix
          src/NSWallet/iOS/Interfaces/ExportService.cs on lines 210..213

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status