camilosampedro/Aton

Similar blocks of code found in 2 locations. Consider refactoring.

Open

package dao.impl

import javax.inject.Inject

import com.google.inject.Singleton

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

package dao.impl

import javax.inject.Inject

import com.google.inject.Singleton

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      computers.groupBy(_._1).map { computerWithStatus =>
        // Computer
        val computer = computerWithStatus._1
        // Clean the computer from here
        val statusesCleaned = computerWithStatus._2.map { computersWithStatusGrouped =>

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      computers.groupBy(_._1).map { computerWithStatus =>
        // Computer
        val computer = computerWithStatus._1
        // Clean the computer from here
        val statusesCleaned = computerWithStatus._2.map { computersWithStatusGrouped =>

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    request.body.asJson match {
      case Some(json) => json.validate[Room] match {
        case JsSuccess(room, _) => roomService.update(room).map {
          case state.ActionCompleted => Ok(Json.toJson(new ResultMessage("Room updated")))
          case state.NotFound => NotFound(Json.toJson( ResultMessage("Room not found", Seq(("id", room.id.toString)))))

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    request.body.asJson match {
      case Some(json) => json.validate[Laboratory] match {
        case JsSuccess(laboratory, _) =>
          laboratoryService.update(laboratory).map {
            case state.ActionCompleted => Ok(Json.toJson(new ResultMessage("Laboratory updated")))

• Read up
  Read up

File SSHOrderServiceImpl.scala has 300 lines of code (exceeds 250 allowed). Consider refactoring.

Open

package services.impl

import java.io.{BufferedReader, IOException, InputStreamReader}
import java.net.NoRouteToHostException
import java.sql.Timestamp

Function executeWithSudoWorkaround has 66 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  private def executeWithSudoWorkaround(sshOrder: SSHOrder, settings: SSHOptions): (String,Int) = {
    play.Logger.debug(s"""Trying sudo workaround with $sshOrder""")
    settings.password.password match {
      case Some(password) =>
        val jsch = new JSch()

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  override def update(room: Room): Future[ActionState] = {
    db.run {
      val foundLaboratory = search(room.id)
      foundLaboratory.update(room).asTry
    }.map{

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  override def update(laboratory: Laboratory): Future[ActionState] = {
    db.run {
      val foundLaboratory = search(laboratory.id)
      foundLaboratory.update(laboratory).asTry
    }.map{

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        let result = this.laboratoryService.addNew(laboratory).subscribe(
            result =>{
                console.log(result);
                this.newLaboratoryModal.hide()
            },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        let result = this.roomService.addNew(room).subscribe(
            result =>{
                console.log(result);
                this.newRoomModal.hide()
            },

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            this.sshOrderService.sendOrder(this._sshOrder, this.computer).subscribe(
                result =>{
                    console.log(result);
                    this.computerFormModal.hide()
                },

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            this.computerService.addNew(this._computer).subscribe(
                result =>{
                    console.log(result);
                    this.computerFormModal.hide()
                },

• Read up
  Read up

Function get has 42 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def get(id: Long): Future[Option[(Laboratory, Map[Room, Seq[(Computer, Option[(ComputerState, Seq[ConnectedUser])])]])]] = {
    // Access to database using the laboratory's DAO
    laboratoryDAO.getWithChildren(id).map { res =>
      // res will have a sequence of (laboratory, room, computer, computerState, connectedUser)
      // Then group it by its first element: Laboratory

Function executeUntilResult has 40 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def executeUntilResult(computer: Computer, sshOrders: Seq[SSHOrder]): (String, Int) = {
    play.Logger.debug(s"""Executing: $sshOrders into: $computer""")
    val joinedSSHOrder = sshOrders.headOption match {
      case Some(sshOrder) =>
        sshOrder.copy(command = sshOrders.map(_.command).mkString(" & "))

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    implicit val (username: Option[String], isAdmin: Boolean) = loggedIn match {
      case Some(User(usernameString, password, Some(name), role)) => (Some(name), role == Role.Administrator)
      case Some(User(usernameString, password, None, role)) => (Some(usernameString), role == Role.Administrator)
      case _ => (None, false)
    }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    implicit val (username: Option[String], isAdmin: Boolean) = loggedIn match {
      case Some(User(usernameString, password, Some(name), role)) => (Some(name), role == Role.Administrator)
      case Some(User(usernameString, password, None, role)) => (Some(usernameString), role == Role.Administrator)
      case _ => (None, false)
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  def delete(ip: String) = AuthRequiredAction {
    implicit request =>
      computerService.delete(ip) map {
        case state.ActionCompleted => Ok(Json.toJson(new ResultMessage("Computer deleted successfully")))
        case state.NotFound => NotFound(Json.toJson(new ResultMessage("Computer not found")))

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  def delete(id: Long) = AuthRequiredAction { implicit request =>
    laboratoryService.delete(id) map {
      case state.ActionCompleted => Ok(Json.toJson(new ResultMessage("Laboratory deleted successfully")))
      case state.NotFound => NotFound(Json.toJson(new ResultMessage("Laboratory not found")))
      case _ => BadRequest(Json.toJson(new ResultMessage("A server problem occurred while trying to delete the laboratory")))

• Read up
  Read up