Sign upLogin

canax/htmlform

View on GitHub
Star

Showing 37 of 37 total issues

Function check has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
Open

    public function check($callIfSuccess = null, $callIfFail = null)
    {
        $remember = null;
        $validates = null;
        $callbackStatus = null;
Severity: Minor
Found in src/HTMLForm/Form.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Form.php has 456 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Anax\HTMLForm;

use Psr\Container\ContainerInterface;
Severity: Minor
Found in src/HTMLForm/Form.php - About 6 hrs to fix

    Method __construct has 161 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct(DIInterface $di)
    {
        parent::__construct($di);
        $this->form->create(
            [
    Severity: Major
    Found in src/HTMLForm/FormModelElementsAll.php - About 6 hrs to fix

      Method getHTMLDetails has 131 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getHTMLDetails()
    {
        // Add disabled to be able to disable a form element
        // Add maxlength
        $id =  $this->getElementId();
      Severity: Major
      Found in src/HTMLForm/FormElement.php - About 5 hrs to fix

        Method check has 123 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function check($callIfSuccess = null, $callIfFail = null)
    {
        $remember = null;
        $validates = null;
        $callbackStatus = null;
        Severity: Major
        Found in src/HTMLForm/Form.php - About 4 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            public function __construct() {
    parent::__construct();
    
    $this->AddElement(new \Mos\HTMLForm\CFormElementText('name'))
         ->AddElement(new \Mos\HTMLForm\CFormElementText('email'))
          Severity: Major
          Found in htdocs/_test/test-part4.php and 1 other location - About 3 hrs to fix
          htdocs/_test/test-part5.php on lines 15..27

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 159.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            public function __construct() {
    parent::__construct();
    
    $this->AddElement(new \Mos\HTMLForm\CFormElementText('name'))
         ->AddElement(new \Mos\HTMLForm\CFormElementText('email'))
          Severity: Major
          Found in htdocs/_test/test-part5.php and 1 other location - About 3 hrs to fix
          htdocs/_test/test-part4.php on lines 15..27

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 159.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method __construct has 91 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function __construct(ContainerInterface $di)
    {
        parent::__construct($di);
        $this->form->create(
            [
          Severity: Major
          Found in src/HTMLForm/FormModelElementsHTML5.php - About 3 hrs to fix

            Method __construct has 88 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function __construct(ContainerInterface $di)
    {
        parent::__construct($di);
        $this->form->create(
            [
            Severity: Major
            Found in src/HTMLForm/FormModelStyle.php - About 3 hrs to fix

              File FormElement.php has 312 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php

namespace Anax\HTMLForm;

/**
              Severity: Minor
              Found in src/HTMLForm/FormElement.php - About 3 hrs to fix

                Method __construct has 87 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function __construct(ContainerInterface $di)
    {
        parent::__construct($di);
        $this->form->create(
            [
                Severity: Major
                Found in src/HTMLForm/FormModelElementsHTML401.php - About 3 hrs to fix

                  Form has 24 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class Form implements \ArrayAccess
{
    /**
     * @var array $form       settings for the form
     * @var array $elements   all form elements
                  Severity: Minor
                  Found in src/HTMLForm/Form.php - About 2 hrs to fix

                    Method validate has 64 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function validate($rules, $form = null)
    {
        $regExpEmailAddress = '/\b[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}\b/i';
        $tests = [
            'fail' => [
                    Severity: Major
                    Found in src/HTMLForm/FormElement.php - About 2 hrs to fix

                      FormElement has 22 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      abstract class FormElement implements \ArrayAccess
{

    /**
     * @var array $attributes        settings to use to create element
                      Severity: Minor
                      Found in src/HTMLForm/FormElement.php - About 2 hrs to fix

                        Function initElements has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                        Open

                            protected function initElements($values)
    {
        // First clear all
        foreach ($this->elements as $key => $val) {
            // Do not reset value for buttons
                        Severity: Minor
                        Found in src/HTMLForm/Form.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method getHTMLLayoutForElements has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function getHTMLLayoutForElements($elements, $options = [])
    {
        $defaults = [
            'columns' => 1,
            'wrap_at_element' => false,  // Wraps column in equal size or at the set number of elements
                        Severity: Minor
                        Found in src/HTMLForm/Form.php - About 1 hr to fix

                          Method getHTML has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function getHTML($options = [])
    {
        $defaults = [
            // Only return the start of the form element
            'start'         => false,
                          Severity: Minor
                          Found in src/HTMLForm/Form.php - About 1 hr to fix

                            Function getHTMLLayoutForElements has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function getHTMLLayoutForElements($elements, $options = [])
    {
        $defaults = [
            'columns' => 1,
            'wrap_at_element' => false,  // Wraps column in equal size or at the set number of elements
                            Severity: Minor
                            Found in src/HTMLForm/Form.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Method create has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public static function create($name, $attributes)
    {
        // Not supported is type=image, <button>, list, output, select-optgroup
        $types = [
                            Severity: Minor
                            Found in src/HTMLForm/FormElementFactory.php - About 1 hr to fix

                              Method getHTMLForElements has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public function getHTMLForElements($options = [])
    {
        $defaults = [
            "use_buttonbar" => true,
        ];
                              Severity: Minor
                              Found in src/HTMLForm/Form.php - About 1 hr to fix
                                Severity
                                Category
                                Status
                                Source
                                Language