capejs/capejs

View on GitHub

Showing 65 of 65 total issues

File virtual_forms_test.js has 520 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict'

var isNode = typeof module !== 'undefined' && module.exports !== undefined

describe('VirtualForms', () => {
Severity: Major
Found in test/spec/virtual_forms_test.js - About 1 day to fix

    File router_test.js has 518 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict'
    
    describe('Router', () => {
      describe('constructor', () => {
        it('should have complete set of properties', () => {
    Severity: Major
    Found in test/spec/router_test.js - About 1 day to fix

      File routing_mapper_test.js has 479 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      'use strict'
      
      describe('RoutingMapper', () => {
        describe('page', () => {
          it('should add a route to specified component', () => {
      Severity: Minor
      Found in test/spec/routing_mapper_test.js - About 7 hrs to fix

        Function apply has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
        Open

          apply() {
            let forms, i, len, form, formName, tForm, j, elements, elem, elemName, k
        
            forms = this.component.root.getElementsByTagName('form')
        
        
        Severity: Minor
        Found in lib/cape/virtual_forms.js - About 7 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File markup_builder_test.js has 463 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        'use strict'
        
        var isNode = typeof module !== 'undefined' && module.exports !== undefined
        
        describe('MarkupBuilder', () => {
        Severity: Minor
        Found in test/spec/markup_builder_test.js - About 7 hrs to fix

          Function compile has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
          Open

            compile() {
              let forms, elements, i, j, elem, segments, lastSegment, obj, o, name
          
              this.realForms = {}
              forms = this.main.component.root.getElementsByTagName('form')
          Severity: Minor
          Found in lib/cape/virtual_forms.js - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File markup_builder.js has 432 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          'use strict'
          
          let virtualDom = require('virtual-dom')
          let Inflector = require('inflected')
          let Cape = require('./utilities')
          Severity: Minor
          Found in lib/cape/markup_builder.js - About 6 hrs to fix

            File resource_agent_test.js has 400 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            'use strict'
            
            class UserAgent extends Cape.ResourceAgent {
              constructor(client, options) {
                super(client, options)
            Severity: Minor
            Found in test/spec/resource_agent_test.js - About 5 hrs to fix

              Arrow function has too many statements (50). Maximum allowed is 30.
              Open

                  it('should create form with appropriate id attribute', () => {
              Severity: Minor
              Found in test/spec/markup_builder_test.js by eslint

              enforce a maximum number of statements allowed in function blocks (max-statements)

              The max-statements rule allows you to specify the maximum number of statements allowed in a function.

              function foo() {
                var bar = 1; // one statement
                var baz = 2; // two statements
                var qux = 3; // three statements
              }

              Rule Details

              This rule enforces a maximum number of statements allowed in function blocks.

              Options

              This rule has a number or object option:

              • "max" (default 10) enforces a maximum number of statements allows in function blocks

              Deprecated: The object property maximum is deprecated; please use the object property max instead.

              This rule has an object option:

              • "ignoreTopLevelFunctions": true ignores top-level functions

              max

              Examples of incorrect code for this rule with the default { "max": 10 } option:

              /*eslint max-statements: ["error", 10]*/
              /*eslint-env es6*/
              
              function foo() {
                var foo1 = 1;
                var foo2 = 2;
                var foo3 = 3;
                var foo4 = 4;
                var foo5 = 5;
                var foo6 = 6;
                var foo7 = 7;
                var foo8 = 8;
                var foo9 = 9;
                var foo10 = 10;
              
                var foo11 = 11; // Too many.
              }
              
              let foo = () => {
                var foo1 = 1;
                var foo2 = 2;
                var foo3 = 3;
                var foo4 = 4;
                var foo5 = 5;
                var foo6 = 6;
                var foo7 = 7;
                var foo8 = 8;
                var foo9 = 9;
                var foo10 = 10;
              
                var foo11 = 11; // Too many.
              };

              Examples of correct code for this rule with the default { "max": 10 } option:

              /*eslint max-statements: ["error", 10]*/
              /*eslint-env es6*/
              
              function foo() {
                var foo1 = 1;
                var foo2 = 2;
                var foo3 = 3;
                var foo4 = 4;
                var foo5 = 5;
                var foo6 = 6;
                var foo7 = 7;
                var foo8 = 8;
                var foo9 = 9;
                var foo10 = 10;
                return function () {
              
                  // The number of statements in the inner function does not count toward the
                  // statement maximum.
              
                  return 42;
                };
              }
              
              let foo = () => {
                var foo1 = 1;
                var foo2 = 2;
                var foo3 = 3;
                var foo4 = 4;
                var foo5 = 5;
                var foo6 = 6;
                var foo7 = 7;
                var foo8 = 8;
                var foo9 = 9;
                var foo10 = 10;
                return function () {
              
                  // The number of statements in the inner function does not count toward the
                  // statement maximum.
              
                  return 42;
                };
              }

              ignoreTopLevelFunctions

              Examples of additional correct code for this rule with the { "max": 10 }, { "ignoreTopLevelFunctions": true } options:

              /*eslint max-statements: ["error", 10, { "ignoreTopLevelFunctions": true }]*/
              
              function foo() {
                var foo1 = 1;
                var foo2 = 2;
                var foo3 = 3;
                var foo4 = 4;
                var foo5 = 5;
                var foo6 = 6;
                var foo7 = 7;
                var foo8 = 8;
                var foo9 = 9;
                var foo10 = 10;
                var foo11 = 11;
              }

              Related Rules

              • [complexity](complexity.md)
              • [max-depth](max-depth.md)
              • [max-len](max-len.md)
              • [max-nested-callbacks](max-nested-callbacks.md)
              • [max-params](max-params.md) Source: http://eslint.org/docs/rules/

              Function val has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
              Open

                val(arg1, arg2) {
                  let key1, key2, value
              
                  if (typeof arg1 === 'object') {
                    for (key1 in arg1) {
              Severity: Minor
              Found in lib/cape/virtual_forms.js - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File collection_agent_test.js has 297 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              'use strict'
              
              class UserCollectionAgent extends Cape.CollectionAgent {
                constructor(client, options) {
                  super(client, options)
              Severity: Minor
              Found in test/spec/collection_agent_test.js - About 3 hrs to fix

                File virtual_forms.js has 292 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                'use strict'
                
                let Cape = require('./utilities')
                
                // Cape.VirtualForms
                Severity: Minor
                Found in lib/cape/virtual_forms.js - About 3 hrs to fix

                  MarkupBuilder has 26 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class MarkupBuilder {
                    constructor(component, options) {
                      this._ = new _Internal(this)
                      this.component = component
                      if (options) {
                  Severity: Minor
                  Found in lib/cape/markup_builder.js - About 3 hrs to fix

                    Method 'apply' has a complexity of 17.
                    Open

                      apply() {
                    Severity: Minor
                    Found in lib/cape/virtual_forms.js by eslint

                    Limit Cyclomatic Complexity (complexity)

                    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

                    function a(x) {
                        if (true) {
                            return x; // 1st path
                        } else if (false) {
                            return x+1; // 2nd path
                        } else {
                            return 4; // 3rd path
                        }
                    }

                    Rule Details

                    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

                    Examples of incorrect code for a maximum of 2:

                    /*eslint complexity: ["error", 2]*/
                    
                    function a(x) {
                        if (true) {
                            return x;
                        } else if (false) {
                            return x+1;
                        } else {
                            return 4; // 3rd path
                        }
                    }

                    Examples of correct code for a maximum of 2:

                    /*eslint complexity: ["error", 2]*/
                    
                    function a(x) {
                        if (true) {
                            return x;
                        } else {
                            return 4;
                        }
                    }

                    Options

                    Optionally, you may specify a max object property:

                    "complexity": ["error", 2]

                    is equivalent to

                    "complexity": ["error", { "max": 2 }]

                    Deprecated: the object property maximum is deprecated. Please use the property max instead.

                    When Not To Use It

                    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

                    Further Reading

                    Related Rules

                    • [max-depth](max-depth.md)
                    • [max-len](max-len.md)
                    • [max-nested-callbacks](max-nested-callbacks.md)
                    • [max-params](max-params.md)
                    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                      detach(listener) {
                        for (let i = 0, len = this._.notificationListeners.length; i < len; i++) {
                          if (this._.notificationListeners[i] === listener) {
                            this._.notificationListeners.splice(i, 1)
                            break
                    Severity: Major
                    Found in lib/cape/router.js and 1 other location - About 2 hrs to fix
                    lib/cape/mixins/propagator_methods.js on lines 12..19

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 88.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                      detach: function(component) {
                        for (let i = 0, len = this._.components.length; i < len; i++) {
                          if (this._.components[i] === component) {
                            this._.components.splice(i, 1)
                            break
                    Severity: Major
                    Found in lib/cape/mixins/propagator_methods.js and 1 other location - About 2 hrs to fix
                    lib/cape/router.js on lines 166..173

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 88.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    File routing_mapper.js has 267 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    'use strict'
                    
                    let Inflector = require('inflected')
                    let Cape = require('./utilities')
                    
                    
                    Severity: Minor
                    Found in lib/cape/routing_mapper.js - About 2 hrs to fix

                      Function has too many statements (35). Maximum allowed is 30.
                      Open

                          it('should refresh counter', function() {

                      enforce a maximum number of statements allowed in function blocks (max-statements)

                      The max-statements rule allows you to specify the maximum number of statements allowed in a function.

                      function foo() {
                        var bar = 1; // one statement
                        var baz = 2; // two statements
                        var qux = 3; // three statements
                      }

                      Rule Details

                      This rule enforces a maximum number of statements allowed in function blocks.

                      Options

                      This rule has a number or object option:

                      • "max" (default 10) enforces a maximum number of statements allows in function blocks

                      Deprecated: The object property maximum is deprecated; please use the object property max instead.

                      This rule has an object option:

                      • "ignoreTopLevelFunctions": true ignores top-level functions

                      max

                      Examples of incorrect code for this rule with the default { "max": 10 } option:

                      /*eslint max-statements: ["error", 10]*/
                      /*eslint-env es6*/
                      
                      function foo() {
                        var foo1 = 1;
                        var foo2 = 2;
                        var foo3 = 3;
                        var foo4 = 4;
                        var foo5 = 5;
                        var foo6 = 6;
                        var foo7 = 7;
                        var foo8 = 8;
                        var foo9 = 9;
                        var foo10 = 10;
                      
                        var foo11 = 11; // Too many.
                      }
                      
                      let foo = () => {
                        var foo1 = 1;
                        var foo2 = 2;
                        var foo3 = 3;
                        var foo4 = 4;
                        var foo5 = 5;
                        var foo6 = 6;
                        var foo7 = 7;
                        var foo8 = 8;
                        var foo9 = 9;
                        var foo10 = 10;
                      
                        var foo11 = 11; // Too many.
                      };

                      Examples of correct code for this rule with the default { "max": 10 } option:

                      /*eslint max-statements: ["error", 10]*/
                      /*eslint-env es6*/
                      
                      function foo() {
                        var foo1 = 1;
                        var foo2 = 2;
                        var foo3 = 3;
                        var foo4 = 4;
                        var foo5 = 5;
                        var foo6 = 6;
                        var foo7 = 7;
                        var foo8 = 8;
                        var foo9 = 9;
                        var foo10 = 10;
                        return function () {
                      
                          // The number of statements in the inner function does not count toward the
                          // statement maximum.
                      
                          return 42;
                        };
                      }
                      
                      let foo = () => {
                        var foo1 = 1;
                        var foo2 = 2;
                        var foo3 = 3;
                        var foo4 = 4;
                        var foo5 = 5;
                        var foo6 = 6;
                        var foo7 = 7;
                        var foo8 = 8;
                        var foo9 = 9;
                        var foo10 = 10;
                        return function () {
                      
                          // The number of statements in the inner function does not count toward the
                          // statement maximum.
                      
                          return 42;
                        };
                      }

                      ignoreTopLevelFunctions

                      Examples of additional correct code for this rule with the { "max": 10 }, { "ignoreTopLevelFunctions": true } options:

                      /*eslint max-statements: ["error", 10, { "ignoreTopLevelFunctions": true }]*/
                      
                      function foo() {
                        var foo1 = 1;
                        var foo2 = 2;
                        var foo3 = 3;
                        var foo4 = 4;
                        var foo5 = 5;
                        var foo6 = 6;
                        var foo7 = 7;
                        var foo8 = 8;
                        var foo9 = 9;
                        var foo10 = 10;
                        var foo11 = 11;
                      }

                      Related Rules

                      • [complexity](complexity.md)
                      • [max-depth](max-depth.md)
                      • [max-len](max-len.md)
                      • [max-nested-callbacks](max-nested-callbacks.md)
                      • [max-params](max-params.md) Source: http://eslint.org/docs/rules/

                      ResourceAgent has 21 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      class ResourceAgent {
                        constructor(client, options) {
                          let adapterName, adapter
                      
                          options = options || {}
                      Severity: Minor
                      Found in lib/cape/resource_agent.js - About 2 hrs to fix

                        Method 'compile' has a complexity of 12.
                        Open

                          compile() {
                        Severity: Minor
                        Found in lib/cape/virtual_forms.js by eslint

                        Limit Cyclomatic Complexity (complexity)

                        Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

                        function a(x) {
                            if (true) {
                                return x; // 1st path
                            } else if (false) {
                                return x+1; // 2nd path
                            } else {
                                return 4; // 3rd path
                            }
                        }

                        Rule Details

                        This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

                        Examples of incorrect code for a maximum of 2:

                        /*eslint complexity: ["error", 2]*/
                        
                        function a(x) {
                            if (true) {
                                return x;
                            } else if (false) {
                                return x+1;
                            } else {
                                return 4; // 3rd path
                            }
                        }

                        Examples of correct code for a maximum of 2:

                        /*eslint complexity: ["error", 2]*/
                        
                        function a(x) {
                            if (true) {
                                return x;
                            } else {
                                return 4;
                            }
                        }

                        Options

                        Optionally, you may specify a max object property:

                        "complexity": ["error", 2]

                        is equivalent to

                        "complexity": ["error", { "max": 2 }]

                        Deprecated: the object property maximum is deprecated. Please use the property max instead.

                        When Not To Use It

                        If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

                        Further Reading

                        Related Rules

                        • [max-depth](max-depth.md)
                        • [max-len](max-len.md)
                        • [max-nested-callbacks](max-nested-callbacks.md)
                        • [max-params](max-params.md)
                        • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/
                        Severity
                        Category
                        Status
                        Source
                        Language