Sign upLogin

capejs/capejs

View on GitHub
Star

Showing 65 of 65 total issues

Function checkedOn has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  checkedOn(name) {
    let names, formName, attrName, forms, elements, cb, value

    names = this._.getNames(name)
    formName = names[0]
Severity: Minor
Found in lib/cape/virtual_forms.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  collectionPath() {
    let resources = Inflector.pluralize(Inflector.underscore(this.resourceName))
    return this._.pathPrefix() + resources
  }
Severity: Minor
Found in lib/cape/resource_agent.js and 1 other location - About 55 mins to fix
lib/cape/collection_agent.js on lines 151..154

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  collectionPath() {
    let resources = Inflector.pluralize(Inflector.underscore(this.resourceName))
    return this._.pathPrefix() + resources
  }
Severity: Minor
Found in lib/cape/collection_agent.js and 1 other location - About 55 mins to fix
lib/cape/resource_agent.js on lines 183..186

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

            if (elem.name.slice(-2) === '[]') {
              if (!Array.isArray(obj[elem.name])) obj[elem.name] = []
              if (elem.checked) obj[elem.name].push(elem.value)
            }
            else {
Severity: Major
Found in lib/cape/virtual_forms.js - About 45 mins to fix

    Function ajax has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      ajax: function(httpMethod, path, params, callback, errorHandler) {
    params = params || {}
    errorHandler = errorHandler || this.defaultErrorHandler

    this._.applyAdapter()
    Severity: Minor
    Found in lib/cape/mixins/agent_common_methods.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                for (k = 0; k < tForm[elemName].length; k++) {
              if (elem.value === tForm[elemName][k]) {
                elem.checked = true
                break
              }
    Severity: Major
    Found in lib/cape/virtual_forms.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                if (elem.value !== tForm[elemName])
            elem.value = tForm[elemName] ? tForm[elemName] : ''
      Severity: Major
      Found in lib/cape/virtual_forms.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                  else if (elem.type === 'radio') {
            if (elem.checked) obj[elem.name] = elem.value
          }
          else {
            obj[elem.name] = elem.value
        Severity: Major
        Found in lib/cape/virtual_forms.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                      for (key2 in value) {
              if (value.hasOwnProperty(key2)) {
                this._.setValue(key1 + '.' + key2, value[key2])
              }
            }
          Severity: Major
          Found in lib/cape/virtual_forms.js - About 45 mins to fix

            Function ajax has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              ajax: function(httpMethod, path, params, callback, errorHandler) {
            Severity: Minor
            Found in lib/cape/mixins/agent_common_methods.js - About 35 mins to fix

              Function merge has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              Cape.merge = function() {
  let i, key

  for (i = 1; i < arguments.length; i++)
    for (key in arguments[i])
              Severity: Minor
              Found in lib/cape/utilities.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                getValue(name) {
    let names, formName, attrName, form, _form

    names = this.getNames(name)
    formName = names[0]
              Severity: Minor
              Found in lib/cape/virtual_forms.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function extractClassNames has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                extractClassNames(classNames, options) {
    if (typeof options['className'] === 'object') {
      for (let name in options['className']) {
        if (options['className'][name]) classNames.push(name)
      }
              Severity: Minor
              Found in lib/cape/markup_builder.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function show has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                show(klass, params) {
    this.query = {}
    if (params !== undefined) {
      for (let prop in params) {
        if ({}.hasOwnProperty.call(params, prop)) {
              Severity: Minor
              Found in lib/cape/router.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getComponentClassFor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                getComponentClassFor(route) {
    let fragments = []
    if (route.container) {
      route.container.split('.').forEach(part => {
        fragments.push(Inflector.camelize(part))
              Severity: Minor
              Found in lib/cape/router.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function mount has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                mount(id) {
    if (id === undefined)
      throw new Error("The first argument is missing.")
    if (typeof id !== 'string')
      throw new Error("The first argument must be a string.")
              Severity: Minor
              Found in lib/cape/component.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function textareaField has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                textareaField(attrName, options) {
    let formName, vform, dasherized

    if (attrName && this.fieldNamePrefix)
      attrName = this.fieldNamePrefix + '/' + attrName
              Severity: Minor
              Found in lib/cape/markup_builder.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function redirectTo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                redirectTo(hash, params, options) {
    // For backward compatibility, if the second argument has a key 'notice'
    // or 'alert' and the third argument is undefined, the second argument
    // should be treated as options.
    if (typeof params === 'object' && options === undefined) {
              Severity: Minor
              Found in lib/cape/router.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function extend has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              Cape.extend = function() {
  let i, key

  for (i = 1; i < arguments.length; i++)
    for (key in arguments[i])
              Severity: Minor
              Found in lib/cape/utilities.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype.
              Open

                    for (let key in params) {
              Severity: Minor
              Found in lib/cape/mixins/agent_common_methods.js by eslint

              Require Guarding for-in (guard-for-in)

              Looping over objects with a for in loop will include properties that are inherited through the prototype chain. This behavior can lead to unexpected items in your for loop.

              for (key in foo) {
    doSomething(key);
}

              Note that simply checking foo.hasOwnProperty(key) is likely to cause an error in some cases; see [no-prototype-builtins](no-prototype-builtins.md).

              Rule Details

              This rule is aimed at preventing unexpected behavior that could arise from using a for in loop without filtering the results in the loop. As such, it will warn when for in loops do not filter their results with an if statement.

              Examples of incorrect code for this rule:

              /*eslint guard-for-in: "error"*/

for (key in foo) {
    doSomething(key);
}

              Examples of correct code for this rule:

              /*eslint guard-for-in: "error"*/

for (key in foo) {
    if (Object.prototype.hasOwnProperty.call(foo, key)) {
        doSomething(key);
    }
    if ({}.hasOwnProperty.call(foo, key)) {
        doSomething(key);
    }
}

              Related Rules

              • [no-prototype-builtins](no-prototype-builtins.md)

              Further Reading

              Severity
              Category
              Status
              Source
              Language