Showing 64 of 64 total issues
Function formatter
has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
var formatter = (function() {
var ymin = Infinity;
var ymax = -Infinity;
var yUnits;
Function exports
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
module.exports = function(opts, done) {
var REPORT_FILE = 'plot.html';
var input = opts.input;
var output = opts.output;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function decorateTest
has 55 lines of code (exceeds 25 allowed). Consider refactoring. Open
function decorateTest(testFunc, timeout, context) {
var categories = [];
var metrics = {};
function addCategory() {
Function makeGraph
has 54 lines of code (exceeds 25 allowed). Consider refactoring. Open
function makeGraph(series) {
var graph = new Rickshaw.Graph({
element: chartElem,
renderer: 'scatterplot',
stroke: true,
Function utils
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
function utils(opts) {
var objectMode = opts.objectMode;
var logger = Logger(opts);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function utils
has 47 lines of code (exceeds 25 allowed). Consider refactoring. Open
function utils(opts) {
var objectMode = opts.objectMode;
var logger = Logger(opts);
Function createWorkers
has 47 lines of code (exceeds 25 allowed). Consider refactoring. Open
function createWorkers(opts, done) {
var count = opts.threads;
// create as many threads as necessary
var forks = _.times(count, function(id) {
Function reporter
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
var reporter = (function() {
function ensureObj(obj) {
return _.isPlainObject(obj) ? obj : {};
}
Function startRunning
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
function startRunning(context, done) {
var timeout;
function markForDone() {
isRunning = false;
Function taskCreator
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
module.exports = function taskCreator(opts) {
var mode = opts.mode;
var paused = false;
var running = 0;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function exports
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function() {
var bins = {};
var api = {};
Function readJsonStats
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
function readJsonStats(input, done) {
var latencies = [];
var metrics = [];
var header = {};
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function stringifier
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
var stringifier = function(opts) {
function appendTimeUnit(val) {
return (+val).toFixed(3) + 'ms';
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function runCommand
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
function runCommand(argv) {
return argv.command('run <testname>', 'Run a test by name.', function(localYargs) {
localYargs = addCommonCommand(
localYargs,
'grandma run <testname> --duration=2m --rate=200'
Function TestRunner
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
function TestRunner(msg) {
var filepath = msg.filepath;
var timeout = msg.timeout;
var test;
Function Reporter
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
function Reporter(repOpts) {
function endStream(stream) {
if (!isStream.stdio(stream)) {
stream.end();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function stringifier
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
var stringifier = function(opts) {
function colorString(str, color) {
if (opts.color) {
return chalk[color](str);
}
Function exports
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function(jsonSummary, opts) {
var durationStr = 'NaN';
var stringify = stringifier(_.isPlainObject(opts) ? opts : {});
Similar blocks of code found in 2 locations. Consider refactoring. Open
latencies: function(latencies, name) {
return [name].concat([
latencies.mean,
latencies['50'],
latencies['95'],
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 59.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
metrics: function(metrics, name) {
return [name].concat([
metrics.mean,
metrics['50'],
metrics['95'],
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 59.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76