Sign upLogin

cclausen/petri_net

View on GitHub
Star

Showing 53 of 53 total issues

Method get_most_absolute_influence_on_path has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    def get_most_absolute_influence_on_path(start, node, sum = 0.01)
        prob_counter = 0
        prob_diff = Array.new
        paths = get_paths_without_loops(start, node)
        paths.each do |path|
Severity: Minor
Found in lib/petri_net/graph/graph.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Net has 43 methods (exceeds 20 allowed). Consider refactoring.
Open

class PetriNet::Net < PetriNet::Base
    include LUSolve
    # Human readable name
    attr_accessor :name
    # Storage filename
Severity: Minor
Found in lib/petri_net/net.rb - About 5 hrs to fix

    Method get_most_relative_influence_on_path has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_most_relative_influence_on_path(start, node, factor = 0.5)
        prob_counter = 0
        prob_diff = Array.new
        paths = get_paths_without_loops(start, node)
        paths.each do |path|
    Severity: Minor
    Found in lib/petri_net/graph/graph.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File net.rb has 347 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'yaml'
require 'graphviz'
require 'matrix'
require 'bigdecimal/ludcmp'
    Severity: Minor
    Found in lib/petri_net/net.rb - About 4 hrs to fix

      File graph.rb has 295 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'graphviz'
require 'graphviz/theory'
require 'rgl/adjacency'
require 'rgl/dijkstra'
class PetriNet::InfiniteReachabilityGraphError < RuntimeError
      Severity: Minor
      Found in lib/petri_net/graph/graph.rb - About 3 hrs to fix

        Class Graph has 25 methods (exceeds 20 allowed). Consider refactoring.
        Open

        class PetriNet::Graph < PetriNet::Base

    # The PetriNet this graph belongs to
    attr_reader :net
    # all nodes from this graph
        Severity: Minor
        Found in lib/petri_net/graph/graph.rb - About 2 hrs to fix

          Method coverability_helper has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

              def coverability_helper(markings, source, added_omega = false)
        @transitions.each_value do |tid|
            if @objects[tid].fire
                current_node = PetriNet::ReachabilityGraph::Node.new(@graph, markings: get_markings)
                current_node_id = @graph.add_node current_node
          Severity: Minor
          Found in lib/petri_net/net.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method reachability_helper has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

              def reachability_helper(markings, source)
        @transitions.each_value do |tid|
            raise PetriNet::ReachabilityGraph::InfinityGraphError if @objects[tid].inputs.empty? && !@objects[tid].outputs.empty?
            next if @objects[tid].inputs.empty?
            if @objects[tid].fire
          Severity: Minor
          Found in lib/petri_net/net.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method add_node has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

              def add_node(node)
        double = false
        inf = false
        @nodes.each_value do |n|
            begin
          Severity: Minor
          Found in lib/petri_net/coverability_graph/graph.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def <=>(object)
        return nil unless object.class.to_s == "PetriNet::ReachabilityGraph::Node"
        if @markings == object.markings
            return 0
        end
          Severity: Major
          Found in lib/petri_net/graph/node.rb and 1 other location - About 2 hrs to fix
          lib/petri_net/coverability_graph/node.rb on lines 86..120

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 85.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def <=>(object)
        return nil unless object.class.to_s == "PetriNet::CoverabilityGraph::Node"
        if @markings == object.markings
            return 0
        end
          Severity: Major
          Found in lib/petri_net/coverability_graph/node.rb and 1 other location - About 2 hrs to fix
          lib/petri_net/graph/node.rb on lines 106..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 85.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method <=> has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              def <=>(object)
        return nil unless object.class.to_s == "PetriNet::ReachabilityGraph::Node"
        if @markings == object.markings
            return 0
        end
          Severity: Minor
          Found in lib/petri_net/graph/node.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method <=> has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              def <=>(object)
        return nil unless object.class.to_s == "PetriNet::CoverabilityGraph::Node"
        if @markings == object.markings
            return 0
        end
          Severity: Minor
          Found in lib/petri_net/coverability_graph/node.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method validate has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

                  def validate(net)
            return false if @id < 1
            return false if @name.nil? or @name.length <= 0
            return false if @weight < 1
            return false if @source.nil? or @destination.nil?
          Severity: Minor
          Found in lib/petri_net/arc.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method generate_gv has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              def generate_gv(named = true)
        g = GraphViz.new( :G, :type => :digraph )

        @nodes.each_value do |node|
            if named
          Severity: Minor
          Found in lib/petri_net/graph/graph.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method <=> has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def <=>(object)
        return nil unless object.class.to_s == "PetriNet::CoverabilityGraph::Node"
        if @markings == object.markings
            return 0
        end
          Severity: Minor
          Found in lib/petri_net/coverability_graph/node.rb - About 1 hr to fix

            Method <=> has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def <=>(object)
        return nil unless object.class.to_s == "PetriNet::ReachabilityGraph::Node"
        if @markings == object.markings
            return 0
        end
            Severity: Minor
            Found in lib/petri_net/graph/node.rb - About 1 hr to fix

              Method add_omega has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  def add_omega object 
        ret = Array.new
        if object.class.to_s == "PetriNet::CoverabilityGraph::Node"
            if self < object
                counter = 0
              Severity: Minor
              Found in lib/petri_net/graph/node.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method generate_gv has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def generate_gv(named = true)
        g = GraphViz.new( :G, :type => :digraph )

        @nodes.each_value do |node|
            if named
              Severity: Minor
              Found in lib/petri_net/graph/graph.rb - About 1 hr to fix

                Method add_node has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    def add_node(node)
        double = false
        inf = false
        @nodes.each_value do |n|
            begin
                Severity: Minor
                Found in lib/petri_net/coverability_graph/graph.rb - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language