Sign upLogin

cclausen/petri_net

View on GitHub
Star

Showing 53 of 53 total issues

Method add_omega has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def add_omega object 
        ret = Array.new
        if object.class.to_s == "PetriNet::CoverabilityGraph::Node"
            if self < object
                counter = 0
Severity: Minor
Found in lib/petri_net/coverability_graph/node.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method add_omega has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def add_omega object 
        ret = Array.new
        if object.class.to_s == "PetriNet::CoverabilityGraph::Node"
            if self < object
                counter = 0
Severity: Minor
Found in lib/petri_net/graph/node.rb - About 1 hr to fix

    Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def initialize(options = {}, &block)
            @id = next_object_id
            @name = (options[:name] or "Arc#{@id}")
            @description = (options[:description] or "Arc #{@id}")
            @weight = (options[:weight] or 1)
    Severity: Minor
    Found in lib/petri_net/arc.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize(options = {}, &block)
        @id = next_object_id
        @name = (options[:name] or "Node#{@id}")
        @description = (options[:description] or "Node #{@id}")
        @inputs = Array.new
    Severity: Minor
    Found in lib/petri_net/coverability_graph/node.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize(graph, options = {}, &block)
        @graph = graph
        @id = next_object_id
        @name = (options[:name] or "Node#{@id}")
        @description = (options[:description] or "Node #{@id}")
    Severity: Minor
    Found in lib/petri_net/graph/node.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method sanitize_probabilities has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def sanitize_probabilities
        @nodes.each_value do |node|
            prob = 1.0
            @objects[node].outputs.each do |edge|
                prob = prob + @objects[edge].probability unless @objects[edge].probability.nil?
    Severity: Minor
    Found in lib/petri_net/graph/graph.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                if self < object
                counter = 0
                object.markings.each do |marking|
                    if @markings[counter] < marking 
                        @markings[counter] = Float::INFINITY
    Severity: Minor
    Found in lib/petri_net/coverability_graph/node.rb and 1 other location - About 35 mins to fix
    lib/petri_net/graph/node.rb on lines 53..63

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                if self < object
                counter = 0
                object.markings.each do |marking|
                    if @markings[counter] < marking 
                        @markings[counter] = Float::INFINITY
    Severity: Minor
    Found in lib/petri_net/graph/node.rb and 1 other location - About 35 mins to fix
    lib/petri_net/coverability_graph/node.rb on lines 48..58

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this method.
    Open

            return nil
    Severity: Major
    Found in lib/petri_net/coverability_graph/node.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return nil
      Severity: Major
      Found in lib/petri_net/graph/node.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return true
        Severity: Major
        Found in lib/petri_net/place.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return net.objects.include? @destination
          Severity: Major
          Found in lib/petri_net/arc.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return false
            Severity: Major
            Found in lib/petri_net/arc.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return false if @source == @destination
              Severity: Major
              Found in lib/petri_net/arc.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return net.objects_include? @source
                Severity: Major
                Found in lib/petri_net/arc.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return net.objects.include? @destination
                  Severity: Major
                  Found in lib/petri_net/arc.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return net.objects_include? @source
                    Severity: Major
                    Found in lib/petri_net/arc.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return true
                      Severity: Major
                      Found in lib/petri_net/arc.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return false
                        Severity: Major
                        Found in lib/petri_net/coverability_graph/graph.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return false if @source.class == @destination.class
                          Severity: Major
                          Found in lib/petri_net/arc.rb - About 30 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language