Sign upLogin

cclausen/petri_net

View on GitHub
Star
lib/petri_net/graph/graph.rb

Summary

Maintainability
D
2 days
Test Coverage

Method get_most_absolute_influence_on_path has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    def get_most_absolute_influence_on_path(start, node, sum = 0.01)
        prob_counter = 0
        prob_diff = Array.new
        paths = get_paths_without_loops(start, node)
        paths.each do |path|
Severity: Minor
Found in lib/petri_net/graph/graph.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_most_relative_influence_on_path has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    def get_most_relative_influence_on_path(start, node, factor = 0.5)
        prob_counter = 0
        prob_diff = Array.new
        paths = get_paths_without_loops(start, node)
        paths.each do |path|
Severity: Minor
Found in lib/petri_net/graph/graph.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File graph.rb has 295 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'graphviz'
require 'graphviz/theory'
require 'rgl/adjacency'
require 'rgl/dijkstra'
class PetriNet::InfiniteReachabilityGraphError < RuntimeError
Severity: Minor
Found in lib/petri_net/graph/graph.rb - About 3 hrs to fix

    Class Graph has 25 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class PetriNet::Graph < PetriNet::Base

    # The PetriNet this graph belongs to
    attr_reader :net
    # all nodes from this graph
    Severity: Minor
    Found in lib/petri_net/graph/graph.rb - About 2 hrs to fix

      Method generate_gv has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def generate_gv(named = true)
        g = GraphViz.new( :G, :type => :digraph )

        @nodes.each_value do |node|
            if named
      Severity: Minor
      Found in lib/petri_net/graph/graph.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method generate_gv has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def generate_gv(named = true)
        g = GraphViz.new( :G, :type => :digraph )

        @nodes.each_value do |node|
            if named
      Severity: Minor
      Found in lib/petri_net/graph/graph.rb - About 1 hr to fix

        Method sanitize_probabilities has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def sanitize_probabilities
        @nodes.each_value do |node|
            prob = 1.0
            @objects[node].outputs.each do |edge|
                prob = prob + @objects[edge].probability unless @objects[edge].probability.nil?
        Severity: Minor
        Found in lib/petri_net/graph/graph.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def worst_path(start, node)
        paths = get_paths_without_loops(start, node)
        prob = 1
        res_path = nil
        paths.each do |path|
        Severity: Minor
        Found in lib/petri_net/graph/graph.rb and 1 other location - About 20 mins to fix
        lib/petri_net/graph/graph.rb on lines 226..236

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def best_path(start, node)
        paths = get_paths_without_loops(start, node)
        prob = 0
        res_path = nil
        paths.each do |path|
        Severity: Minor
        Found in lib/petri_net/graph/graph.rb and 1 other location - About 20 mins to fix
        lib/petri_net/graph/graph.rb on lines 239..249

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def to_gv(output = 'png', filename = '')
        g = generate_gv
        if filename.empty?
            filename = "#{@name}_graph.png"
        end
        Severity: Minor
        Found in lib/petri_net/graph/graph.rb and 1 other location - About 20 mins to fix
        lib/petri_net/net.rb on lines 180..186

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status