Sign upLogin

cclausen/petri_net

View on GitHub
Star
lib/petri_net/graph/node.rb

Summary

Maintainability
C
1 day
Test Coverage

Method <=> has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def <=>(object)
        return nil unless object.class.to_s == "PetriNet::ReachabilityGraph::Node"
        if @markings == object.markings
            return 0
        end
Severity: Minor
Found in lib/petri_net/graph/node.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method <=> has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def <=>(object)
        return nil unless object.class.to_s == "PetriNet::ReachabilityGraph::Node"
        if @markings == object.markings
            return 0
        end
Severity: Minor
Found in lib/petri_net/graph/node.rb - About 1 hr to fix

    Method add_omega has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def add_omega object 
        ret = Array.new
        if object.class.to_s == "PetriNet::CoverabilityGraph::Node"
            if self < object
                counter = 0
    Severity: Minor
    Found in lib/petri_net/graph/node.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add_omega has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def add_omega object 
        ret = Array.new
        if object.class.to_s == "PetriNet::CoverabilityGraph::Node"
            if self < object
                counter = 0
    Severity: Minor
    Found in lib/petri_net/graph/node.rb - About 1 hr to fix

      Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize(graph, options = {}, &block)
        @graph = graph
        @id = next_object_id
        @name = (options[:name] or "Node#{@id}")
        @description = (options[:description] or "Node #{@id}")
      Severity: Minor
      Found in lib/petri_net/graph/node.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return nil
      Severity: Major
      Found in lib/petri_net/graph/node.rb - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def <=>(object)
        return nil unless object.class.to_s == "PetriNet::ReachabilityGraph::Node"
        if @markings == object.markings
            return 0
        end
        Severity: Major
        Found in lib/petri_net/graph/node.rb and 1 other location - About 2 hrs to fix
        lib/petri_net/coverability_graph/node.rb on lines 86..120

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 85.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    if self < object
                counter = 0
                object.markings.each do |marking|
                    if @markings[counter] < marking 
                        @markings[counter] = Float::INFINITY
        Severity: Minor
        Found in lib/petri_net/graph/node.rb and 1 other location - About 35 mins to fix
        lib/petri_net/coverability_graph/node.rb on lines 48..58

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status