Sign upLogin

cellog/react-selection

View on GitHub
Star

Showing 37 of 37 total issues

Function makeSelectable has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

function makeSelectable(Component) {
  // always force a ReferenceableContainer if a stateless functional component is passed in
  const useContainer = verifyComponent(Component)
  const componentDisplayName = Component.displayName || Component.name || 'Component'
  let displayName
Severity: Minor
Found in src/Selection.jsx - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function makeSelectable has 195 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function makeSelectable(Component) {
  // always force a ReferenceableContainer if a stateless functional component is passed in
  const useContainer = verifyComponent(Component)
  const componentDisplayName = Component.displayName || Component.name || 'Component'
  let displayName
Severity: Major
Found in src/Selection.jsx - About 7 hrs to fix

    Function Selectable has 93 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function Selectable(Component, options) {
  const useContainer = verifyComponent(Component)
  const componentDisplayName = Component.displayName || Component.name || 'Component'
  let displayName
  let ReferenceableContainer
    Severity: Major
    Found in src/Selectable.jsx - About 3 hrs to fix

      Function Selectable has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

      function Selectable(Component, options) {
  const useContainer = verifyComponent(Component)
  const componentDisplayName = Component.displayName || Component.name || 'Component'
  let displayName
  let ReferenceableContainer
      Severity: Minor
      Found in src/Selectable.jsx - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          render() {
      if (useContainer) {
        return (
          <ReferenceableContainer
            {...this.props}
      Severity: Major
      Found in src/Selection.jsx and 1 other location - About 2 hrs to fix
      src/Selectable.jsx on lines 94..111

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 83.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          render() {
      if (useContainer) {
        return (
          <ReferenceableContainer
            {...this.props}
      Severity: Major
      Found in src/Selectable.jsx and 1 other location - About 2 hrs to fix
      src/Selection.jsx on lines 212..229

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 83.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function constructor has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        constructor() {
    const self = this
    this.accessor = {
      nodes() {
        return [...self.nodes]
      Severity: Minor
      Found in src/selectedList.js - About 1 hr to fix

        Function selectItemsInRectangle has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          selectItemsInRectangle(selectionRectangle, props, findit = findDOMNode, mouse = mouseMath) {
    if (!this.transaction.previousSelection) {
      // fail-safe
      this.begin([])
    }
        Severity: Minor
        Found in src/selectedList.js - About 1 hr to fix

          Function exports has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function (config, extraoptions) {
  config.set({

    basePath: '',
          Severity: Minor
          Found in karma-common.conf.js - About 1 hr to fix

            Function addItem has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              addItem(idx, selectedIndices = this.selectedIndices) {
    if (!this.transaction.firstNode) {
      this.transaction.firstNode = this.nodes[idx]
    }
    const si = selectedIndices
            Severity: Minor
            Found in src/selectedList.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function addItem has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              addItem(idx, selectedIndices = this.selectedIndices) {
    if (!this.transaction.firstNode) {
      this.transaction.firstNode = this.nodes[idx]
    }
    const si = selectedIndices
            Severity: Minor
            Found in src/selectedList.js - About 1 hr to fix

              Function getCoordinates has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                static getCoordinates(e, id, con = console) {
    if (!e.touches && e.clientX) {
      return {
        clientX: e.clientX,
        clientY: e.clientY,
              Severity: Minor
              Found in src/mouseMath.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function shallowEqualScalar has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

              export default function shallowEqualScalar(objA, objB) {
  if (objA === objB) {
    return true
  }
              Severity: Minor
              Found in src/shallowEqualScalar.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getCoordinates has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                static getCoordinates(e, id, con = console) {
    if (!e.touches && e.clientX) {
      return {
        clientX: e.clientX,
        clientY: e.clientY,
              Severity: Minor
              Found in src/mouseMath.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  if (useContainer) {
    displayName = `Selectable(ReferenceableContainer(${componentDisplayName}))`
    ReferenceableContainer = makeReferenceableContainer(Component, componentDisplayName)
  } else {
    displayName = `Selectable(${componentDisplayName})`
                Severity: Major
                Found in src/Selectable.jsx and 1 other location - About 1 hr to fix
                src/Selection.jsx on lines 17..22

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 55.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  if (useContainer) {
    displayName = `Selection(ReferenceableContainer(${componentDisplayName}))`
    ReferenceableContainer = makeReferenceableContainer(Component, componentDisplayName)
  } else {
    displayName = `Selection(${componentDisplayName})`
                Severity: Major
                Found in src/Selection.jsx and 1 other location - About 1 hr to fix
                src/Selectable.jsx on lines 14..19

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 55.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    this.added.map(idx => (this.nodes[idx].callback ? this.nodes[idx].callback(true) : null))
                Severity: Minor
                Found in src/selectedList.js and 1 other location - About 55 mins to fix
                src/selectedList.js on lines 244..244

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 53.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    this.removed.map(idx => (this.nodes[idx].callback ? this.nodes[idx].callback(false) : null))
                Severity: Minor
                Found in src/selectedList.js and 1 other location - About 55 mins to fix
                src/selectedList.js on lines 245..245

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 53.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function selectItemsInRectangle has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                  selectItemsInRectangle(selectionRectangle, props, findit = findDOMNode, mouse = mouseMath) {
    if (!this.transaction.previousSelection) {
      // fail-safe
      this.begin([])
    }
                Severity: Minor
                Found in src/selectedList.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function pageOffset has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                  static pageOffset(dir, useLocal = false, win = window) {
    if (dir !== 'left' && dir !== 'top') {
      throw new Error(`direction must be one of top or left, was "${dir}"`)
    }
    const offsetname = dir === 'left' ? 'pageXOffset' : 'pageYOffset'
                Severity: Minor
                Found in src/mouseMath.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language