Sign upLogin

cerniglj1/osrs-quest-tool

View on GitHub
Star

Showing 336 of 336 total issues

Avoid too many return statements within this function.
Open

            return false;
Severity: Major
Found in lib/osrstools.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

              return false;
    Severity: Major
    Found in lib/model/quest/QuestTool.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                return false;
      Severity: Major
      Found in lib/osrstools.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return false;
        Severity: Major
        Found in lib/osrstools.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                        return false;
          Severity: Major
          Found in lib/model/quest/QuestTool.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return true;
            Severity: Major
            Found in lib/model/quest/QuestTool.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return false;
              Severity: Major
              Found in lib/osrstools.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                  return true;
                Severity: Major
                Found in lib/osrstools.js - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    if (quest.name === 'Recipe for Disaster') {
    // TODO
    // Pirate Pete Subquest of Recipe for Disaster
    return true;
  } else if (quest.name === 'Pirate Pete subquest of Recipe for Disaster') {
                  Severity: Minor
                  Found in lib/osrstools.js and 1 other location - About 30 mins to fix
                  lib/model/quest/QuestTool.js on lines 174..182

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if (quest.name === 'Recipe for Disaster') {
      // @todo
      // Pirate Pete Subquest of Recipe for Disaster
      return true;
    } else if (quest.name === 'Pirate Pete subquest of Recipe for Disaster') {
                  Severity: Minor
                  Found in lib/model/quest/QuestTool.js and 1 other location - About 30 mins to fix
                  lib/osrstools.js on lines 222..230

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Avoid too many return statements within this function.
                  Open

                    return true;
                  Severity: Major
                  Found in lib/osrstools.js - About 30 mins to fix

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        elif section_name in ['official difficulty', 'officialdifficulty', 'official_difficulty', 'difficulty']:

        difficulty_text = ''
        for tag in quest_details:
            difficulty_text += tag.text
                    Severity: Minor
                    Found in tools/getQuestData.py and 2 other locations - About 30 mins to fix
                    tools/getQuestData.py on lines 74..79
                    tools/getQuestData.py on lines 81..85

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 32.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        elif section_name in ['descri', 'description']:
        description_text = ''
        for tag in quest_details:
            description_text += tag.text
                    Severity: Minor
                    Found in tools/getQuestData.py and 2 other locations - About 30 mins to fix
                    tools/getQuestData.py on lines 67..73
                    tools/getQuestData.py on lines 81..85

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 32.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        elif section_name in ['official length', 'officiallength', 'officiallength', 'official_length']:
        length_text = ''
        for tag in quest_details:
            length_text += tag.text
        quest_data['length'] = length_text
                    Severity: Minor
                    Found in tools/getQuestData.py and 2 other locations - About 30 mins to fix
                    tools/getQuestData.py on lines 67..73
                    tools/getQuestData.py on lines 74..79

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 32.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function test has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function test() {
    var reqs = {

        "quests": [
            "Big Chompy Bird Hunting",
                    Severity: Minor
                    Found in lib/model/quest/Requirement.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function test has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function test(): void {
    const reqs = {
        "quests": [
            "Big Chompy Bird Hunting",
            "Jungle Potion"
                    Severity: Minor
                    Found in src/model/quest/Requirement.ts - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language