charliesome/better_errors

View on GitHub

Showing 13 of 13 total issues

Class ErrorPage has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

  class ErrorPage
    VariableInfo = Struct.new(:frame, :editor_url, :rails_params, :rack_session, :start_time)

    def self.template_path(template_name)
      File.expand_path("../templates/#{template_name}.erb", __FILE__)
Severity: Minor
Found in lib/better_errors/error_page.rb - About 3 hrs to fix

    Method show_error_page has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def show_error_page(env, exception=nil)
          request = Rack::Request.new(env)
          csrf_token = request.cookies[CSRF_TOKEN_COOKIE_NAME] || SecureRandom.uuid
          csp_nonce = SecureRandom.base64(12)
    
    
    Severity: Minor
    Found in lib/better_errors/middleware.rb - About 1 hr to fix

      Method inspect_value has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.inspect_value(obj)
            if BetterErrors.ignored_classes.include? obj.class.name
              "<span class='unsupported'>(Instance of ignored class. "\
              "#{obj.class.name ? "Remove #{CGI.escapeHTML(obj.class.name)} from" : "Modify"}"\
              " BetterErrors.ignored_classes if you need to see it.)</span>"
      Severity: Minor
      Found in lib/better_errors/error_page.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method internal_call has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def internal_call(env, id, method)
            return not_found_json_response unless %w[variables eval].include?(method)
            return no_errors_json_response unless @error_page
            return invalid_error_json_response if id != @error_page.id
      
      
      Severity: Minor
      Found in lib/better_errors/middleware.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method show_error_page has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def show_error_page(env, exception=nil)
            request = Rack::Request.new(env)
            csrf_token = request.cookies[CSRF_TOKEN_COOKIE_NAME] || SecureRandom.uuid
            csp_nonce = SecureRandom.base64(12)
      
      
      Severity: Minor
      Found in lib/better_errors/middleware.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method local_variables has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def local_variables
            return {} unless frame_binding
      
            lv = frame_binding.eval("local_variables")
            return {} unless lv
      Severity: Minor
      Found in lib/better_errors/stack_frame.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method editor= has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.editor=(editor)
          if editor.is_a? Symbol
            @editor = Editor.editor_from_symbol(editor)
            raise(ArgumentError, "Symbol #{editor} is not a symbol in the list of supported errors.") unless editor
          elsif editor.is_a? String
      Severity: Minor
      Found in lib/better_errors.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method editor_from_environment_editor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.editor_from_environment_editor
            if ENV["BETTER_ERRORS_EDITOR"]
              editor = editor_from_command(ENV["BETTER_ERRORS_EDITOR"])
              return editor if editor
              puts "BETTER_ERRORS_EDITOR environment variable is not recognized as a supported Better Errors editor."
      Severity: Minor
      Found in lib/better_errors/editor.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return invalid_csrf_token_json_response unless request.cookies[CSRF_TOKEN_COOKIE_NAME] == body['csrfToken']
      Severity: Major
      Found in lib/better_errors/middleware.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return not_acceptable_json_response unless request.content_type == 'application/json'
        Severity: Major
        Found in lib/better_errors/middleware.rb - About 30 mins to fix

          Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def initialize(exception)
                if exception.class.name == "ActionView::Template::Error" && exception.respond_to?(:cause)
                  # Rails 6+ exceptions of this type wrap the "real" exception, and the real exception
                  # is actually more useful than the ActionView-provided wrapper. Once Better Errors
                  # supports showing all exceptions in the cause stack, this should go away. Or perhaps
          Severity: Minor
          Found in lib/better_errors/raised_exception.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method url has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def url(raw_path, line)
                if virtual_path && raw_path.start_with?(virtual_path)
                  if host_path
                    file = raw_path.sub(%r{\A#{virtual_path}}, host_path)
                  else
          Severity: Minor
          Found in lib/better_errors/editor.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def execute(str)
                  "=> #{@binding.eval(str).inspect}\n"
                rescue Exception => e
                  "!! #{e.inspect rescue e.class.to_s rescue "Exception"}\n"
                end
          Severity: Minor
          Found in lib/better_errors/repl/basic.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language