Sign upLogin

cheikhshift/samb

View on GitHub
Star

Showing 24 of 24 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func TestExportExitCode(t *testing.T) {

    setupTestEnv()
    defer teardownTestEnv()
Severity: Major
Found in transpiler/transpiler_server_test.go and 1 other location - About 4 hrs to fix
transpiler/transpiler_server_test.go on lines 129..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 345.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func TestExportServer(t *testing.T) {

    setupTestEnv()
    defer teardownTestEnv()
Severity: Major
Found in transpiler/transpiler_server_test.go and 1 other location - About 4 hrs to fix
transpiler/transpiler_server_test.go on lines 186..242

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 345.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function TestExportRoutes has 84 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestExportRoutes(t *testing.T) {

    setupTestEnv()
    defer teardownTestEnv()
Severity: Major
Found in transpiler/transpiler_test.go - About 2 hrs to fix

    Function TestExportMain has 57 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TestExportMain(t *testing.T) {

    setupTestEnv()
    defer teardownTestEnv()
    Severity: Minor
    Found in transpiler/transpiler_server_test.go - About 1 hr to fix

      Function TestExportGlobals has 56 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func TestExportGlobals(t *testing.T) {

    setupTestEnv()
    defer teardownTestEnv()
      Severity: Minor
      Found in transpiler/transpiler_server_test.go - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func TestSetup(t *testing.T) {

    setupTestEnv()
    defer teardownTestEnv()
        Severity: Minor
        Found in transpiler/transpiler_test.go and 1 other location - About 50 mins to fix
        transpiler/transpiler_test.go on lines 27..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 119.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func TestMakePkgPaths(t *testing.T) {

    setupTestEnv()
    defer teardownTestEnv()
        Severity: Minor
        Found in transpiler/transpiler_test.go and 1 other location - About 50 mins to fix
        transpiler/transpiler_test.go on lines 11..25

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 119.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Your code does not pass gofmt in 4 places. Go fmt your code!
        Open

        package transpiler
        Severity: Minor
        Found in transpiler/transpiler_server_test.go by gofmt

        Your code does not pass gofmt in 3 places. Go fmt your code!
        Open

        package transpiler
        Severity: Minor
        Found in transpiler/http_gen.go by gofmt

        Your code does not pass gofmt in 2 places. Go fmt your code!
        Open

        package transpiler
        Severity: Minor
        Found in transpiler/transpiler_util_test.go by gofmt

        Your code does not pass gofmt in 1 place. Go fmt your code!
        Open

        package transpiler
        Severity: Minor
        Found in transpiler/transpiler_utils.go by gofmt

        comment on exported type Go should be of the form "Go ..." (with optional leading article)
        Open

        // Array of Go statements
        Severity: Minor
        Found in types.go by golint

        exported function GenerateHandler should have comment or be unexported
        Open

        func GenerateHandler(name, v string) (result string) {
        Severity: Minor
        Found in cmd/samb-handler/main.go by golint

        Your code does not pass gofmt in 1 place. Go fmt your code!
        Open

        // Package transpiler converts samb struct types into Go code.
        Severity: Minor
        Found in transpiler/package_gen.go by gofmt

        exported type Template should have comment or be unexported
        Open

        type Template struct {
        Severity: Minor
        Found in types.go by golint

        Your code does not pass gofmt in 1 place. Go fmt your code!
        Open

        package samb
        Severity: Minor
        Found in loader.go by gofmt

        Your code does not pass gofmt in 1 place. Go fmt your code!
        Open

        package transpiler
        Severity: Minor
        Found in transpiler/transpiler_vars_test.go by gofmt

        range var providerId should be providerID
        Open

            for _, providerId := range providers {
        Severity: Minor
        Found in transpiler/provider_utils.go by golint

        Your code does not pass gofmt in 1 place. Go fmt your code!
        Open

        package tools
        Severity: Minor
        Found in tools/http_tools.go by gofmt

        exported function GenerateRouter should have comment or be unexported
        Open

        func GenerateRouter(name string) (result string) {
        Severity: Minor
        Found in cmd/samb-handler/main.go by golint
        Severity
        Category
        Status
        Source
        Language