Sign upLogin

chessmodule/movegengo

View on GitHub
Star

Showing 11 of 12 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    for i := LSB(to); i != 64; i = NLSB(&to, i) {
        mg.mover.SetFrom(uint16(i + attackDirection))
        mg.mover.SetTo(uint16(i))
        mg.moves[mg.index] = mg.mover.GetMove()
        mg.index++
Severity: Major
Found in movegen.go and 3 other locations - About 40 mins to fix
movegen.go on lines 126..131
movegen.go on lines 196..201
movegen.go on lines 231..236

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    for i := LSB(to); i != 64; i = NLSB(&to, i) {
        mg.mover.SetFrom(uint16(i + attackDirection))
        mg.mover.SetTo(uint16(i))
        mg.moves[mg.index] = mg.mover.GetMove()
        mg.index++
Severity: Major
Found in movegen.go and 3 other locations - About 40 mins to fix
movegen.go on lines 161..166
movegen.go on lines 196..201
movegen.go on lines 231..236

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    for i := LSB(attacks); i != 64; i = NLSB(&attacks, i) {
        mg.mover.SetFrom(uint16(i + attackDirection))
        mg.mover.SetTo(uint16(i))
        mg.moves[mg.index] = mg.mover.GetMove()
        mg.index++
Severity: Major
Found in movegen.go and 3 other locations - About 40 mins to fix
movegen.go on lines 126..131
movegen.go on lines 161..166
movegen.go on lines 231..236

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    for i := LSB(attacks); i != 64; i = NLSB(&attacks, i) {
        mg.mover.SetFrom(uint16(i + attackDirection))
        mg.mover.SetTo(uint16(i))
        mg.moves[mg.index] = mg.mover.GetMove()
        mg.index++
Severity: Major
Found in movegen.go and 3 other locations - About 40 mins to fix
movegen.go on lines 126..131
movegen.go on lines 161..166
movegen.go on lines 196..201

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

package movegengo
Severity: Minor
Found in consts.go by gofmt

exported type GameState should have comment or be unexported
Open

type GameState struct {
Severity: Minor
Found in gamestate.go by golint

exported method MoveGen.GeneratePawnMoves should have comment or be unexported
Open

func (mg *MoveGen) GeneratePawnMoves() uint64 {
Severity: Minor
Found in movegen.go by golint

exported function DefaultGameStateColour should have comment or be unexported
Open

func DefaultGameStateColour() uint8 {
Severity: Minor
Found in gamestate.go by golint

exported function Perft should have comment or be unexported
Open

func Perft() {
Severity: Minor
Found in perft.go by golint

exported function NewGameState should have comment or be unexported
Open

func NewGameState() *GameState {
Severity: Minor
Found in gamestate.go by golint

exported var KnightMoves should have comment or be unexported
Open

var KnightMoves = [64]uint64{
Severity: Minor
Found in movetables.go by golint
Severity
Category
Status
Source
Language