src/Chippyash/Math/Matrix/Decomposition/GaussJordanElimination.php
Function decompose
has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring. Open
Open
public function decompose(NumericMatrix $mA, $extra = null)
{
$this->assertParameterIsMatrix($extra, 'Parameter extra is not a matrix')
->assertMatrixIsNumeric($extra, 'Parameter extra is not a numeric matrix')
->assertMatrixIsSquare($mA,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method decompose
has 60 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function decompose(NumericMatrix $mA, $extra = null)
{
$this->assertParameterIsMatrix($extra, 'Parameter extra is not a matrix')
->assertMatrixIsNumeric($extra, 'Parameter extra is not a numeric matrix')
->assertMatrixIsSquare($mA,
Avoid deeply nested control flow statements. Open
Open
if ($comp->eq($ipiv[$k], $zero())) {
$absVal = $dA[$j][$k]->abs();
if ($comp->gt($absVal, $big)) {
unset($big);
$big = clone $absVal;
Method addMultipleOfOtherRowToRow
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
protected function addMultipleOfOtherRowToRow(array &$a, $multiple, $rowToMultiplyWith,
$rowToAddTo, Calculator $calc)
The method decompose() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10. Open
Open
public function decompose(NumericMatrix $mA, $extra = null)
{
$this->assertParameterIsMatrix($extra, 'Parameter extra is not a matrix')
->assertMatrixIsNumeric($extra, 'Parameter extra is not a numeric matrix')
->assertMatrixIsSquare($mA,
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}