chippyash/Monad

View on GitHub
src/chippyash/Monad/Collection.php

Summary

Maintainability
D
1 day
Test Coverage

Collection has 27 functions (exceeds 20 allowed). Consider refactoring.
Open

class Collection extends ArrayObject implements Monadic
{

    /**
     * The Type of the items in the collection
Severity: Minor
Found in src/chippyash/Monad/Collection.php - About 3 hrs to fix

    File Collection.php has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * Monad
     *
     * @author Ashley Kitson
    Severity: Minor
    Found in src/chippyash/Monad/Collection.php - About 2 hrs to fix

      Method setTypeFromValue has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function setTypeFromValue(array $value): FTry
          {
              //required to be defined as a var so it can be called in next statement
              $basicTest = function () use ($value) {
                  if (count($value) > 0) {
      Severity: Major
      Found in src/chippyash/Monad/Collection.php - About 2 hrs to fix

        Avoid too many return statements within this method.
        Open

                            return new None();
        Severity: Major
        Found in src/chippyash/Monad/Collection.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                                          return new Some($v);
          Severity: Major
          Found in src/chippyash/Monad/Collection.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                            return new Some($v);
            Severity: Major
            Found in src/chippyash/Monad/Collection.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                              return new None();
              Severity: Major
              Found in src/chippyash/Monad/Collection.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return FTry::with(function () use ($matchLegalType) {
                            return $matchLegalType->value();
                        });
                Severity: Major
                Found in src/chippyash/Monad/Collection.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                                  return new Some($v);
                  Severity: Major
                  Found in src/chippyash/Monad/Collection.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                                    return new Some($v);
                    Severity: Major
                    Found in src/chippyash/Monad/Collection.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                                      return new Some($v);
                      Severity: Major
                      Found in src/chippyash/Monad/Collection.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                                        return new Some($v);
                        Severity: Major
                        Found in src/chippyash/Monad/Collection.php - About 30 mins to fix

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Open

                              public function vIntersect(Collection $other, \Closure $function = null)
                              {
                                  if (is_null($function)) {
                                      return new static(\array_intersect($this->getArrayCopy(), $other->getArrayCopy()), $this->type);
                                  }
                          Severity: Major
                          Found in src/chippyash/Monad/Collection.php and 2 other locations - About 1 hr to fix
                          src/chippyash/Monad/Collection.php on lines 262..269
                          src/chippyash/Monad/Collection.php on lines 288..295

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 100.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Open

                              public function vDiff(Collection $other, \Closure $function = null)
                              {
                                  if (is_null($function)) {
                                      return new static(\array_diff($this->getArrayCopy(), $other->getArrayCopy()), $this->type);
                                  }
                          Severity: Major
                          Found in src/chippyash/Monad/Collection.php and 2 other locations - About 1 hr to fix
                          src/chippyash/Monad/Collection.php on lines 288..295
                          src/chippyash/Monad/Collection.php on lines 324..331

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 100.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Open

                              public function kDiff(Collection $other, \Closure $function = null)
                              {
                                  if (is_null($function)) {
                                      return new static(\array_diff_key($this->getArrayCopy(), $other->getArrayCopy()), $this->type);
                                  }
                          Severity: Major
                          Found in src/chippyash/Monad/Collection.php and 2 other locations - About 1 hr to fix
                          src/chippyash/Monad/Collection.php on lines 262..269
                          src/chippyash/Monad/Collection.php on lines 324..331

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 100.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status