Sign upLogin

chippyash/Simple-Accounts

View on GitHub
Star

Showing 113 of 113 total issues

Method createTransactionFromElement has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function createTransactionFromElement(\DOMElement $txn, $crcyCode, \DOMXPath $xpath)
    {
        $drNodes = $xpath->query("./split[@type='DR']", $txn);
        $transaction = (new SplitTransaction(
            new \DateTime($txn->attributes->getNamedItem('date')->nodeValue),
Severity: Minor
Found in src/Chippyash/SAccounts/Storage/Journal/Xml.php - About 1 hr to fix

    Method buildTree has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function buildTree(Node $tree, \DOMNode $node, Chart $chart, array $accountTypes)
    {
        //create current node
        list($nominal, $type, $name, $id) = FFor::create()
            ->attributes(function () use ($node) {
    Severity: Minor
    Found in src/Chippyash/SAccounts/Accountant.php - About 1 hr to fix

      Avoid variables with short names like $id. Configured minimum length is 3.
      Open

          public function readTransaction(IntType $id)
      Severity: Minor
      Found in src/Chippyash/SAccounts/Storage/Journal/Xml.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $id. Configured minimum length is 3.
      Open

          public function __construct(IntType $id, StringType $name, Currency $crcy)
      Severity: Minor
      Found in src/Chippyash/SAccounts/Organisation.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $dr. Configured minimum length is 3.
      Open

          public function balance(Currency $dr, Currency $cr)
      Severity: Minor
      Found in src/Chippyash/SAccounts/AccountType.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $m. Configured minimum length is 3.
      Open

                  if (preg_match('/^DOMDocument::load\(\): (.+)$/', $error, $m) === 1) {
      Severity: Minor
      Found in src/Chippyash/SAccounts/ChartDefinition.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $id. Configured minimum length is 3.
      Open

              list($nominal, $type, $name, $id) = FFor::create()
      Severity: Minor
      Found in src/Chippyash/SAccounts/Accountant.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $id. Configured minimum length is 3.
      Open

          protected $id;
      Severity: Minor
      Found in src/Chippyash/SAccounts/Control/Link.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $cr. Configured minimum length is 3.
      Open

          public function balance(Currency $dr, Currency $cr)
      Severity: Minor
      Found in src/Chippyash/SAccounts/AccountType.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $id. Configured minimum length is 3.
      Open

          public function readTransaction(IntType $id)
      Severity: Minor
      Found in src/Chippyash/SAccounts/Journal.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $id. Configured minimum length is 3.
      Open

          public function __construct(StringType $name, Nominal $id)
      Severity: Minor
      Found in src/Chippyash/SAccounts/Control/Link.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $id. Configured minimum length is 3.
      Open

          public function readTransaction(IntType $id);
      Severity: Minor
      Found in src/Chippyash/SAccounts/JournalStorageInterface.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      The class Chart has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13.
      Open

      class Chart implements Identifiable
{
    use Identifying;

    /**@+
      Severity: Minor
      Found in src/Chippyash/SAccounts/Chart.php by phpmd

      CouplingBetweenObjects

      Since: 1.1.0

      A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

      Example

      class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

      Source https://phpmd.org/rules/design.html#couplingbetweenobjects

      The class Accountant has a coupling between objects value of 27. Consider to reduce the number of dependencies under 13.
      Open

      class Accountant
{
    /**@+
     * Error strings
     */
      Severity: Minor
      Found in src/Chippyash/SAccounts/Accountant.php by phpmd

      CouplingBetweenObjects

      Since: 1.1.0

      A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

      Example

      class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

      Source https://phpmd.org/rules/design.html#couplingbetweenobjects

      The class Account has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.
      Open

      class Account implements RecordStatusRecordable, Identifiable
{
    use RecordStatusRecording;
    use Identifying;
      Severity: Minor
      Found in src/Chippyash/SAccounts/Account.php by phpmd

      CouplingBetweenObjects

      Since: 1.1.0

      A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

      Example

      class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

      Source https://phpmd.org/rules/design.html#couplingbetweenobjects

      The class Xml has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.
      Open

      class Xml implements JournalStorageInterface
{
    /**
     * Path to journal storage file
     * @var StringType
      Severity: Minor
      Found in src/Chippyash/SAccounts/Storage/Journal/Xml.php by phpmd

      CouplingBetweenObjects

      Since: 1.1.0

      A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

      Example

      class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

      Source https://phpmd.org/rules/design.html#couplingbetweenobjects

      Method writeSplit has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          protected function writeSplit(\DOMDocument $dom, \DOMElement $txn, $type, $amount, $nominal)
      Severity: Minor
      Found in src/Chippyash/SAccounts/Storage/Journal/Xml.php - About 35 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function __construct(Nominal $drAc, Nominal $crAc, Currency $amount, StringType $note = null, \DateTime $date = null)
        Severity: Minor
        Found in src/Chippyash/SAccounts/Transaction/SimpleTransaction.php - About 35 mins to fix

          Expected 1 space after FUNCTION keyword; 0 found
          Open

                      ->Monad_Option_Some(function($parentId) use($amount) {
          Severity: Minor
          Found in src/Chippyash/SAccounts/Account.php by phpcodesniffer

          Spaces must be used for alignment; tabs are not allowed
          Open

           * @copyright      Ashley Kitson, UK, 2015
          Severity: Minor
          Found in src/Chippyash/SAccounts/JournalException.php by phpcodesniffer
          Severity
          Category
          Status
          Source
          Language