chippyash/Simple-Accounts

Spaces must be used for alignment; tabs are not allowed

Open

 * @author         Ashley Kitson

• Exclude checks
  • Disable engine
  • Disable check

Opening brace of a class must be on the line after the definition

Open

class Nominal extends DigitType {}

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after FUNCTION keyword; 0 found

Open

            ->Monad_Option_Some(function($parentId) use($amount) {

• Exclude checks
  • Disable engine
  • Disable check

There must be one blank line after the namespace declaration

Open

namespace SAccounts;

• Exclude checks
  • Disable engine
  • Disable check

Missing class import via use statement (line '141', column '22').

Open

        $xpath = new \DOMXPath($dom);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '63', column '28').

Open

                return new \DOMXPath($dom);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '341', column '20').

Open

        $dom = new \DOMDocument();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '179', column '22').

Open

        $xpath = new \DOMXPath($dom);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '55', column '20').

Open

        $dom = new \DOMDocument();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '297', column '20').

Open

        $dom = new \DOMDocument();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid too many return statements within this method.

Open

                return new IntType($attributes->getNamedItem('id')->nodeValue);

Missing class import via use statement (line '328', column '22').

Open

        $xpath = new \DOMXPath($this->getDom());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '232', column '17').

Open

            new \DateTime($txn->attributes->getNamedItem('date')->nodeValue),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '312', column '22').

Open

        $xpath = new \DOMXPath($dom);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '283', column '20').

Open

        $dom = new \DOMDocument();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '58', column '35').

Open

                $this->date = new \DateTime();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '203', column '22').

Open

        $xpath = new \DOMXPath($dom);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method writeJournal uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            return $this->createJournal($journal);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method balance uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            throw new AccountsException('Cannot determine account type to set balance: ' . $this->value);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid unused parameters such as '$number'.

Open

        set_error_handler(function($number, $error) use ($err) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}