Sign upLogin

chippyash/Simple-Accounts

View on GitHub
Star
src/Chippyash/SAccounts/Account.php

Summary

Maintainability
A
0 mins
Test Coverage

The class Account has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.
Open

class Account implements RecordStatusRecordable, Identifiable
{
    use RecordStatusRecording;
    use Identifying;
Severity: Minor
Found in src/Chippyash/SAccounts/Account.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Expected 1 space after FUNCTION keyword; 0 found
Open

            ->Monad_Option_Some(function($parentId) use($amount) {
Severity: Minor
Found in src/Chippyash/SAccounts/Account.php by phpcodesniffer

Expected 1 space after USE keyword; found 0
Open

            ->Monad_Option_Some(function($parentId) use($amount) {
Severity: Minor
Found in src/Chippyash/SAccounts/Account.php by phpcodesniffer

Expected 1 space after USE keyword; found 0
Open

            ->Monad_Option_Some(function($parentId) use($amount) {
Severity: Minor
Found in src/Chippyash/SAccounts/Account.php by phpcodesniffer

Expected 1 space after FUNCTION keyword; 0 found
Open

            ->Monad_Option_Some(function($parentId) use($amount) {
Severity: Minor
Found in src/Chippyash/SAccounts/Account.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    protected $acCr;
Severity: Minor
Found in src/Chippyash/SAccounts/Account.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    protected $acDr;
Severity: Minor
Found in src/Chippyash/SAccounts/Account.php by phpcodesniffer

Opening brace should be on a new line
Open

    public function getBalance() {
Severity: Minor
Found in src/Chippyash/SAccounts/Account.php by phpcodesniffer

There are no issues that match your filters.

Category
Status