src/Chippyash/SAccounts/AccountType.php
The method balance uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
throw new AccountsException('Cannot determine account type to set balance: ' . $this->value);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid variables with short names like $dr. Configured minimum length is 3. Open
Open
public function balance(Currency $dr, Currency $cr)- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $cr. Configured minimum length is 3. Open
Open
public function balance(Currency $dr, Currency $cr)- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
There must be one blank line after the namespace declaration Open
Open
namespace SAccounts;- Exclude checks
Line exceeds 120 characters; contains 195 characters Open
Open
* An account recording the capital or equity of an organisation. Positive value is shown as CR, negative as DR. Essentially a form of Liability as it is owed to the shareholders or owners.- Exclude checks
Expected 1 newline at end of file; 0 found Open
Open
}- Exclude checks